Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Jeff Layton <jlayton@redhat.com>
Subject: Re: [PATCH v6 09/14] NFSD: Clean up nfsd4_init_file()
Thread-Topic: [PATCH v6 09/14] NFSD: Clean up nfsd4_init_file()
Thread-Index: AQHY6jVM9OOkZaAuPUqeFrTes3TrR64i4XuAgAAG6AA=
Date:   Thu, 27 Oct 2022 23:46:58 +0000
Message-ID: <293CDB70-F274-425C-BB16-9276BCC48545@oracle.com>
References: <166689625728.90991.15067635142973595248.stgit@klimt.1015granger.net>
 <166689675530.90991.2630847343462195612.stgit@klimt.1015granger.net>
 <166691293591.13915.198182531468244072@noble.neil.brown.name>
In-Reply-To: <166691293591.13915.198182531468244072@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cvkcsMO7G743IDRbIf73fhTb84TPaybl7xjzX3OFSjy43CRed/nlikOOub+m?=
 =?us-ascii?Q?IVWoTgaSUwlytrUdaELMQ9lSRLU3gll6O5ofAVDcGVQxyHudkN5nMBpvjaP6?=
 =?us-ascii?Q?83QStXheuhIdenWyiX6EMGZB++CMlFiW+6ut11x61jZfGxwYI+J4+msHIHPC?=
 =?us-ascii?Q?vjfWmkV8hJzmdo6PUZ9ZS3MBUaiFUGUedUrUIsjxA+OdY5tO3XjReI2CzOfQ?=
 =?us-ascii?Q?psyNgLj5cqQHA3PKzqKv5MfMkG+v0v1SK9oz4OGMXIOyEvka5Z4JaXo2WYpb?=
 =?us-ascii?Q?l6GdN2apnSVIkgSqtHALAQYfDtAeEkIJFWqSQSdGxeZh/T8Lw7LbboohmXjS?=
 =?us-ascii?Q?bRtla6BAW7/VshBiYGPmcIC8OK/QgLR9Pfg+1mwtd59nZ5ejDtoRlsbFLgCB?=
 =?us-ascii?Q?NFL5TPCN1bE+KWbn/ltFK0Yz0JgqbWwUpl41lIy1K4ihkqtoHzu+OiimExai?=
 =?us-ascii?Q?uloM/eD8+1h7gNxoJ3XIRTrSrOB27TSXkJCFYDnwnreoBWXFVEfejrgZFYXg?=
 =?us-ascii?Q?CYZO7ltim22GE0lQOO6aCO4F39o5fxctB02z2rlsFeXOP312uTRpNV5PiTOj?=
 =?us-ascii?Q?EYkCk5rvFnkgbiVZr+up2jFCrqPSL4AOylG7EOvEPS16pQJSnTVv4B8gy7rR?=
 =?us-ascii?Q?zVcHbkHzKcD7FQQOW7dtz3zlhw90XMkR14qy0Pqxu6YY4hNlYwp/NK4YnKF/?=
 =?us-ascii?Q?mQgPyHw/RN5ffPjwNdcvD8ewJlsWO1QaB2+HN4ygY6BI/L6JOkOeN0YmM5VO?=
 =?us-ascii?Q?zmaCF8pYEKiXBdPzc3apOYapfk8vGrHWLITWJe/HQ50g0V7rhpjYJTDnzDRe?=
 =?us-ascii?Q?1U46149jnahgM1kRqBpryfU7zO/P/w53uTAzFwE2y3SVsRbCbMhIR/sSezpO?=
 =?us-ascii?Q?vR/9BM8n8yhooetNS7Z4Tezz0ppxgWrbf/GS5XwH/iAPnhV4Gl0i4dGHXLCt?=
 =?us-ascii?Q?OFr2nGwrgc36zrrUqeBQ76dqLcIr/lbnRDgGvDJ2huN4v5TQH1azN/FjOrE/?=
 =?us-ascii?Q?vaPAdqyipAnkLpoLPcNtpuPB2NBlrSQll2YWwJc28MDQFKn7uMEQ863qrP0u?=
 =?us-ascii?Q?lhlvb7pK9z7FYjA3OauEqOYgB+8HOVjBkdsQbQR24YrshSgJ8BcTsKhrcgck?=
 =?us-ascii?Q?IPZAs13N+1XuYkPxY8JkJQ615CoLBVYSQFprbL3sP9GwJ28m14pI0KDXxArK?=
 =?us-ascii?Q?1kXvV+piv+Lx5P4uA2lOxQpkVG3akrzYkjC0erh6W+eDr1kza9rZan9oSHUF?=
 =?us-ascii?Q?nS4Y528JD/gLiDtNMMAuLyh1TZfS9IIVRcVc67R67/3cRatQRT6lLeMf/1jn?=
 =?us-ascii?Q?VGxjvd3u/EkYZb1AvsUQxgSrNpoqDmkC92qw/FTcPCuGyIiPHbBgdSdQzKsV?=
 =?us-ascii?Q?V+ty+skFh4BFPG4ojkuxKGcEPOmZGzqP/eWbI4m0pJaD8/XdNn7k+yx+3qET?=
 =?us-ascii?Q?jKxKWagrSNda5msLwcIdqsl0sAAdRTJjjnQxJMtBTu4FaQKNOPVIrg52YIuV?=
 =?us-ascii?Q?OF8I0l6RauHPXVPQ4GG9y1njKwEwP5+87Fd8EuDgSn59wfiXmQ6LALgeKDcY?=
 =?us-ascii?Q?W1f3kZmSKpPuxD6OwqJTwf3KG0oV0OXo0Ar3sWetmS7C1BUS22wKnYFkDoOo?=
 =?us-ascii?Q?0g=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <14B14E55EF948149A5F3B504D8BD7E60@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89a2767d-eb11-43c0-6c9c-08dab87589cb
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2022 23:46:58.8528
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RAfCDntSU5IeZITSVDmPS+KYBH3VhwovvldBLn9EugNtimhhcQwGiGdXqi4ZigWifnBjCAArHras3qUw37D/QQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6114
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-27_07,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999
 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210270135
X-Proofpoint-GUID: XL9bRwt-XQI8C3vKnE3VkW6wG3cPyLQw
X-Proofpoint-ORIG-GUID: XL9bRwt-XQI8C3vKnE3VkW6wG3cPyLQw
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 27, 2022, at 7:22 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Fri, 28 Oct 2022, Chuck Lever wrote:
>> Name nfs4_file-related helpers consistently. There are already
>> nfs4_file_yada functions, so let's go with the same convention used
>> by put_nfs4_file(): init_nfs4_file().
>=20
> I don't understand.  You say "consistently", then you say that as we
> have lots of "nfs4_file_yada" functions, this new one will NOT follow
> that pattern.

Patch description is admittedly terse.

I want a naming convention that sets apart the helpers that
deal with the nfs4_file hash table. Maybe nfs4_file_hash_yada
would be a better choice?

But we already have put_nfs4_file()...


> Surely "consistency" means renaming put_nfs4_file() to nfs4_file_put(),
> and introducing nfs4_file_init().
>=20
> Not that I really care that much about the naming, but would like to be
> able to follow your logic.
>=20
> Thanks,
> NeilBrown

--
Chuck Lever