Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2510784rwi; Fri, 28 Oct 2022 07:56:30 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7UFbYoKq9jduRyYNaLw6iG8Ih7mTPbHMBjjcDEfJypn98N999Y8ug8mhvwoaK8RlDms3Nm X-Received: by 2002:a17:902:d58f:b0:186:fd58:c6fc with SMTP id k15-20020a170902d58f00b00186fd58c6fcmr2606554plh.125.1666968990586; Fri, 28 Oct 2022 07:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666968990; cv=none; d=google.com; s=arc-20160816; b=I/1A7kaAkmossiWgnNSzKd6m6p0xVlhBIPzTXgLfixENxgPTLR86r+Vogj0chm6Utg SP9c6Rua55uR3FPgAsgtZDnFr5JlzzuG3sTM/QY+YRbKJTMZdgeVzc/jufXzYqv/+ixa ccIIS0RQpWiDSLqBGLAZrNcGIIlxcoGSSiFFXHFc3iN/haa/H2ARLd4WJXJzFz44W1Sb MPEsixsAeKomXAKREZTr0lon5dQ0DjDrjOkwVsRpMg6fqbkBuWorCnhwkytoiAsiOgMa 2tEWitcV8L/cyr8wG+QmPPeX1UCADmHIL6CeXdDo4oZz1zIsybjSHNX6OoEL5jk6oyLU FJRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=Bs4VyP+pHgXWFiclkFQveF5Jl17o+M3pv0+xoK2Ab+U=; b=ELiuUTYQ0BGccFYDQ8PzxbWcDzXRZ/dEwaWyIfDpph5/vBGZJCNf3FHIPbFmEXSFUC +O6qrJ0HxWbROcUqaeOJ+Os+Vx4Y1BirlJSejzcYILbXTQ5EltaQpr+0A+9NUNYc4Q95 c1JOWCgMsbSAjALLcoAPqqdmMeO3u3JzNtNcutkHyqQa19Qbb4GAM9PxCOwUg9BDIE0D Wm3NtuLpavO0qGQqbalov1Kl0DRPsVD9DsECf5g+NLJlrZTx23NxMLq5k6l1Vh5q4y4r Z0TjUvZoUWR2TBPjXe+epvRjavgCZqfVuyRF8a7hY1nTIvP9GQ4sd+dpCdbKK+OUZCZT eOKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j73-20020a638b4c000000b00439a5dfc7absi393143pge.365.2022.10.28.07.56.08; Fri, 28 Oct 2022 07:56:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231391AbiJ1Osp (ORCPT + 99 others); Fri, 28 Oct 2022 10:48:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231434AbiJ1OsX (ORCPT ); Fri, 28 Oct 2022 10:48:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72B4E207504 for ; Fri, 28 Oct 2022 07:47:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7A9E628DA for ; Fri, 28 Oct 2022 14:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0DADEC433C1; Fri, 28 Oct 2022 14:47:16 +0000 (UTC) Subject: [PATCH v7 07/14] NFSD: Use const pointers as parameters to fh_ helpers From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: neilb@suse.de, jlayton@redhat.com Date: Fri, 28 Oct 2022 10:47:16 -0400 Message-ID: <166696843614.106044.3338299073600201465.stgit@klimt.1015granger.net> In-Reply-To: <166696812922.106044.679812521105874329.stgit@klimt.1015granger.net> References: <166696812922.106044.679812521105874329.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev3+g9561319 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Enable callers to use const pointers where they are able to. Signed-off-by: Chuck Lever Tested-by: Jeff Layton Reviewed-by: Jeff Layton Reviewed-by: NeilBrown --- fs/nfsd/nfsfh.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/nfsd/nfsfh.h b/fs/nfsd/nfsfh.h index c3ae6414fc5c..513e028b0bbe 100644 --- a/fs/nfsd/nfsfh.h +++ b/fs/nfsd/nfsfh.h @@ -220,7 +220,7 @@ __be32 fh_update(struct svc_fh *); void fh_put(struct svc_fh *); static __inline__ struct svc_fh * -fh_copy(struct svc_fh *dst, struct svc_fh *src) +fh_copy(struct svc_fh *dst, const struct svc_fh *src) { WARN_ON(src->fh_dentry); @@ -229,7 +229,7 @@ fh_copy(struct svc_fh *dst, struct svc_fh *src) } static inline void -fh_copy_shallow(struct knfsd_fh *dst, struct knfsd_fh *src) +fh_copy_shallow(struct knfsd_fh *dst, const struct knfsd_fh *src) { dst->fh_size = src->fh_size; memcpy(&dst->fh_raw, &src->fh_raw, src->fh_size); @@ -243,7 +243,8 @@ fh_init(struct svc_fh *fhp, int maxsize) return fhp; } -static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_size != fh2->fh_size) return false; @@ -252,7 +253,8 @@ static inline bool fh_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) return true; } -static inline bool fh_fsid_match(struct knfsd_fh *fh1, struct knfsd_fh *fh2) +static inline bool fh_fsid_match(const struct knfsd_fh *fh1, + const struct knfsd_fh *fh2) { if (fh1->fh_fsid_type != fh2->fh_fsid_type) return false;