Received: by 2002:a05:6358:1087:b0:cb:c9d3:cd90 with SMTP id j7csp2858789rwi; Fri, 28 Oct 2022 12:13:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4CtnFtmm9MHa2Xb5PCylcCvpIuf4cqjeYC164Jh9hhFZ1FvVEzAmKrTWZqEWj/65q7QZwq X-Received: by 2002:a17:90b:1e0c:b0:213:7030:6b11 with SMTP id pg12-20020a17090b1e0c00b0021370306b11mr11258208pjb.29.1666984411358; Fri, 28 Oct 2022 12:13:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666984411; cv=none; d=google.com; s=arc-20160816; b=N7ZWWBJb/Tx0gKkwGqJJCFyhXLnu8AENSkWc2Y9Szsoa4C+r3U0WQQPOeavmlJf9NS MBVoOCNFxui+8yN610n+9KARrzi0xOFAq60Htl3vdKo9LqIYxop1ZiZqyz9aLJOMp6t9 pDmLfGEkznysiEC2dGyMCUgQYmvtRxLiAcIjGwoDbQSyow/luSmAs4/Ep1kAFbDOQCFH ClidpzgmL691x27Q9LuIUIo0U5nHik7LLlVRt1niexjZenHhBMxJv2N9CpCv90HsRIfF AaDa0xxJY1gknYPbkxr6yd5CC69qgLkJ5R1LJXGwd0Q4YoV8N6YUfFXgLuEzXpBV+7Xe su5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lAXwQNER0JDMhfYCH4MqkUdiKZ+SSan0DgdQv/KqqeM=; b=hI5nmwkuDg/cC/RBpMLiywQ69vwrQL0MVT5ls+oBFa07dVkQZGA8bDtGg2+LHloLqh CBO1rIkj9ebnu5fkXMca61uHsvZIbdTbO0wnRcmPV7VSDDCByhsodhbfeEkHvz7mSuzw ijxsKgRBuxMwaZKB3c8CZapSsUXuuOtkRxlRh3bWN9S6SUtfmgiXmYG/TxRQYSaIlEI2 1shL2dQJajHsEYgvT7DR4ZErkEhmcfm1luBgLeHlEJnAguQ852K77AkLJKJZQYtOW8J6 riNoON0XkKtidNLd5Dz+517g5jHo0BVNH4YgNZg7FTj8KaQiD7NNbELy960TauZ1R032 duUA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lIQpPvHD; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a6-20020a170902710600b0017f7fffb591si5472768pll.374.2022.10.28.12.13.18; Fri, 28 Oct 2022 12:13:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lIQpPvHD; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229647AbiJ1S5S (ORCPT + 99 others); Fri, 28 Oct 2022 14:57:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229455AbiJ1S5R (ORCPT ); Fri, 28 Oct 2022 14:57:17 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB4DD1ABA3B for ; Fri, 28 Oct 2022 11:57:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 59C9862A02 for ; Fri, 28 Oct 2022 18:57:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50AD2C433C1; Fri, 28 Oct 2022 18:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666983434; bh=ijn71jGjX0bw1vwKouyS8d1FFrhwN608ZiFlLBS7OcE=; h=From:To:Cc:Subject:Date:From; b=lIQpPvHDjneQ+nygzoz7NQHu2r7AJW/PC9D1Q8crO479fmrr1mmDljFsDudcuiU5o D/HqIjHI1vu0l5p6Dlb7+USlpcgFjZCUharzk97NHLz9bSmt4HSTtllqfUDb0raCEc i4QOj9zrYRd1XP8lssxtIqt3I072t4g0X0jSnJTf1/BqE+gMnqmsQQiSVABFZn71nB 9iKCNjgpk5ATSr5VlwL3rnn9ByKPj89Btl3N0Lo1/VJ+v3XcsFjzXjFBml1Y+z2ucS 54RMc6ppTFK3XJ+AmWqCsSU9mb405r/ScMLc3XRJcXOC2JaJryhIPNkaAmaoi8hVuT wenN0pIclN3kg== From: Jeff Layton To: chuck.lever@oracle.com Cc: linux-nfs@vger.kernel.org, neilb@suse.de Subject: [PATCH v3 0/4] nfsd: clean up refcounting in the filecache Date: Fri, 28 Oct 2022 14:57:08 -0400 Message-Id: <20221028185712.79863-1-jlayton@kernel.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org There are a number of changes here from the last set, but I've tried to address Neil and Chuck's comments (thanks for the review, btw). I think I've solved the race between adding to the LRU and unhashing. That's in patch #3. We may want to squash that into #2 before merging. Jeff Layton (4): nfsd: remove the pages_flushed statistic from filecache nfsd: rework refcounting in filecache nfsd: close race between unhashing and LRU addition nfsd: start non-blocking writeback after adding nfsd_file to the LRU fs/nfsd/filecache.c | 385 +++++++++++++++++++++++--------------------- fs/nfsd/filecache.h | 1 + fs/nfsd/trace.h | 5 +- 3 files changed, 207 insertions(+), 184 deletions(-) -- 2.37.3