Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Neil Brown <neilb@suse.de>
Subject: Re: [PATCH v3 1/4] nfsd: remove the pages_flushed statistic from
 filecache
Thread-Topic: [PATCH v3 1/4] nfsd: remove the pages_flushed statistic from
 filecache
Thread-Index: AQHY6v8bB16g4C3tmkCl+UsoZ0akuq4kNGsA
Date:   Fri, 28 Oct 2022 19:41:01 +0000
Message-ID: <14EFB870-5222-43B7-ACB4-E249190C7EE2@oracle.com>
References: <20221028185712.79863-1-jlayton@kernel.org>
 <20221028185712.79863-2-jlayton@kernel.org>
In-Reply-To: <20221028185712.79863-2-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C1OQVyyVJe7wbWYPGkwede1nNZ8BXGYIIE7KaT2DblE1o/FyaEjtvXHSbe2T?=
 =?us-ascii?Q?d+Z44Z3tpYxOG5/ojjVVc5Fbj9zzUwi6mqgwsJc6fz5AyUHOgIoNGOh6eg2T?=
 =?us-ascii?Q?m1fBzMheVJeelUQenxW2uCLCBK4tWy4+MaCWTVHs/yHQ3PTsVuT15DNaMq9p?=
 =?us-ascii?Q?Cx0aFo2FUIp0RicRp5mJqMXm0DET8eVyIxCHw6D8bOkoxFvUYbG5zIbvlXQJ?=
 =?us-ascii?Q?fmocmF/IXqjvwb4pzCeloiFsvaLppWryP6mzH4q6KR9lpCfhaNvuJpGgnX00?=
 =?us-ascii?Q?HjI8eivwDjxuvn2gsdZC7AbAQec2LBGUD0x2rwumdbMI3126o5EqZKlUxOlw?=
 =?us-ascii?Q?m3wwb2/nZSjA5Hzk8kpGmQ/Equiz2NOg1AXshsTXSDtjWLtnSU3KkSkK+gAa?=
 =?us-ascii?Q?HrYG+WHkLmda+W0VqrUaFJG2AsfIXIeXVguZDi4+GLbfgge546a6/OPmJOm9?=
 =?us-ascii?Q?px6UyGqPcAHU2QtFyqRP1RWHrbVASkJk1GJZdn7marikXniuHHYGJAFVIEzv?=
 =?us-ascii?Q?73Knt9/Zwb9rnidmUSwf1j8bNXrhGxpShQsHkwEudPvTwQzAxGNn7DpIbeMc?=
 =?us-ascii?Q?DAYEkzGkvMD/U7hqSZUrHIuJiDnMjvluvltenxSLYM02/wi2sx/4noT7Nynd?=
 =?us-ascii?Q?hw0Hphzk6MfBJpOsrbXJ7crdEKqBGSkeTttQzUn2dMOMsHEVb9OxAmFyRS4K?=
 =?us-ascii?Q?gNHfJ4P5iECuBDknL6eMlYTZyNxRnQVN0gbsYzPcrlOt2hvgb/W3DHB8BrKQ?=
 =?us-ascii?Q?5MBpMelY224d+63RaKMYayENaOe5FhUUyXJHxVroXgLToRvX89+ZhAkyTU39?=
 =?us-ascii?Q?WkIq9S3mC7VIRGLL+0j64Qcd3/icg8PgGQDjBCznk6g+XvpKDaq5jIXLvyh2?=
 =?us-ascii?Q?28jPNn7W/345hYbJnVZdnALKB9PtakVOQQLBL/kItQgPFNGs9dnRE79A848c?=
 =?us-ascii?Q?8unneacD0MBiKnl+f2cinaLz8ycNVZGgE5+muf+VuMon7mH04F0zFD4otxtG?=
 =?us-ascii?Q?ESax+ADQoSkkWVzU12gFOFhET/RsRj2fbPWuCkMs6zE7hg4tYQs1H1E5L2tC?=
 =?us-ascii?Q?ttU+851bMvs6BopwM64RwBb5Vlj3KDbnlFz3mIzKhHuS8bSnBt04UkJqLTkn?=
 =?us-ascii?Q?o+E63qDgUc0ZAcxJO0AomedI++1XSsNfZVl6UEjYFLmNDkDem7nuN98acaM6?=
 =?us-ascii?Q?jRDhzQikZj93GEVOg0RT1btHsb8mFFNlVER2QlubifmbYzW/Cp0Fu6vRQcgV?=
 =?us-ascii?Q?TTnjr5GYNQewxRBNT7jPkSaRjofWxN1fZsY6aeYopXttxEo9xiSJOHaHsPOd?=
 =?us-ascii?Q?uDUvH0tbwEfvBGETZsH5UN5GuUL44Y4grO8jGIrg8RnLfhVo4OOHThIwVH9L?=
 =?us-ascii?Q?oM0M7tRoBRV9xxLG0fk8KJS/+OFjJ5zGuW9oQ3KSooknOF09fZFQ3UeqteEe?=
 =?us-ascii?Q?2r4YWUIwPSo2NUlZzhRJeSupgvhJm9kobIqzrLtcqeAHxLX/BgbppDOBbbij?=
 =?us-ascii?Q?peQWczzcxRIE5Quu0hkLNs9T4P9zNGi9WaUE6m8wFZ+ueVXFEJ82SSczAkV9?=
 =?us-ascii?Q?NagBeNErX3vo0g9OVUQSZcNDlliIuxj2L5Hb/td2050GvWZOEtRi97yIU6Xy?=
 =?us-ascii?Q?EA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87DFE4556CDF1F4088BC81CBB151ECF0@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b22839c8-b77d-4a83-16e6-08dab91c5826
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2022 19:41:01.4828
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5qcLzdSKYcSd0bL54IV7GauWXjEWr1sSLpiqysffpxL1PE+AJIIY2LukHtuSOgPJlBOcDZsZnNvS+iCpkPv7Wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR10MB6005
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-10-28_10,2022-10-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2210280123
X-Proofpoint-ORIG-GUID: 7ZVNkGIIRN5zxZ9YOGSj4VysEyOyKC9_
X-Proofpoint-GUID: 7ZVNkGIIRN5zxZ9YOGSj4VysEyOyKC9_
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Oct 28, 2022, at 2:57 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> We're counting mapping->nrpages, but not all of those are necessarily
> dirty. We don't really have a simple way to count just the dirty pages,
> so just remove this stat since it's not accurate.

OK. I'll apply this one when the others are ready, so just leave it
in this series when you re-post.


> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/nfsd/filecache.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>=20
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 98c6b5f51bc8..f8ebbf7daa18 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -32,7 +32,6 @@ static DEFINE_PER_CPU(unsigned long, nfsd_file_cache_hi=
ts);
> static DEFINE_PER_CPU(unsigned long, nfsd_file_acquisitions);
> static DEFINE_PER_CPU(unsigned long, nfsd_file_releases);
> static DEFINE_PER_CPU(unsigned long, nfsd_file_total_age);
> -static DEFINE_PER_CPU(unsigned long, nfsd_file_pages_flushed);
> static DEFINE_PER_CPU(unsigned long, nfsd_file_evictions);
>=20
> struct nfsd_fcache_disposal {
> @@ -370,7 +369,6 @@ nfsd_file_flush(struct nfsd_file *nf)
>=20
> 	if (!file || !(file->f_mode & FMODE_WRITE))
> 		return;
> -	this_cpu_add(nfsd_file_pages_flushed, file->f_mapping->nrpages);
> 	if (vfs_fsync(file, 1) !=3D 0)
> 		nfsd_reset_write_verifier(net_generic(nf->nf_net, nfsd_net_id));
> }
> @@ -998,7 +996,6 @@ nfsd_file_cache_shutdown(void)
> 		per_cpu(nfsd_file_acquisitions, i) =3D 0;
> 		per_cpu(nfsd_file_releases, i) =3D 0;
> 		per_cpu(nfsd_file_total_age, i) =3D 0;
> -		per_cpu(nfsd_file_pages_flushed, i) =3D 0;
> 		per_cpu(nfsd_file_evictions, i) =3D 0;
> 	}
> }
> @@ -1212,7 +1209,7 @@ nfsd_file_create(struct svc_rqst *rqstp, struct svc=
_fh *fhp,
>  */
> int nfsd_file_cache_stats_show(struct seq_file *m, void *v)
> {
> -	unsigned long releases =3D 0, pages_flushed =3D 0, evictions =3D 0;
> +	unsigned long releases =3D 0, evictions =3D 0;
> 	unsigned long hits =3D 0, acquisitions =3D 0;
> 	unsigned int i, count =3D 0, buckets =3D 0;
> 	unsigned long lru =3D 0, total_age =3D 0;
> @@ -1240,7 +1237,6 @@ int nfsd_file_cache_stats_show(struct seq_file *m, =
void *v)
> 		releases +=3D per_cpu(nfsd_file_releases, i);
> 		total_age +=3D per_cpu(nfsd_file_total_age, i);
> 		evictions +=3D per_cpu(nfsd_file_evictions, i);
> -		pages_flushed +=3D per_cpu(nfsd_file_pages_flushed, i);
> 	}
>=20
> 	seq_printf(m, "total entries: %u\n", count);
> @@ -1254,6 +1250,5 @@ int nfsd_file_cache_stats_show(struct seq_file *m, =
void *v)
> 		seq_printf(m, "mean age (ms): %ld\n", total_age / releases);
> 	else
> 		seq_printf(m, "mean age (ms): -\n");
> -	seq_printf(m, "pages flushed: %lu\n", pages_flushed);
> 	return 0;
> }
> --=20
> 2.37.3
>=20

--
Chuck Lever