Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 31 Oct 2022 20:05:34 +0100
From:   Petr Vorel <pvorel@suse.cz>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2] nfsd: fix net-namespace logic in
 __nfsd_file_cache_purge
Message-ID: <Y2AcfsN3PvwfjRhA@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20221031154921.500620-1-jlayton@kernel.org>
 <BCEEEF05-11E3-4E31-BDE1-DDCA65A5AB6F@oracle.com>
 <Y2AXrMEim07Y0LLY@pevik>
 <433f431a3684eb296a62f8f3cdbf34e185a5a84d.camel@kernel.org>
 <1E40B5C0-1E8A-4FBD-80FB-3432037F101D@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1E40B5C0-1E8A-4FBD-80FB-3432037F101D@oracle.com>
Precedence: bulk


> > On Oct 31, 2022, at 2:46 PM, Jeff Layton <jlayton@kernel.org> wrote:

> > On Mon, 2022-10-31 at 19:45 +0100, Petr Vorel wrote:

> >>>> On Oct 31, 2022, at 11:49 AM, Jeff Layton <jlayton@kernel.org> wrote:

> >>>> If the namespace doesn't match the one in "net", then we'll continue,
> >>>> but that doesn't cause another rhashtable_walk_next call, so it will
> >>>> loop infinitely.

> >>>> Fixes: ce502f81ba88 ("NFSD: Convert the filecache to use rhashtable")
> >>>> Reported-by: Petr Vorel <pvorel@suse.cz>
> >>>> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> >>>> ---
> >>>> fs/nfsd/filecache.c | 5 ++---
> >>>> 1 file changed, 2 insertions(+), 3 deletions(-)

> >>> Thank you! Applied and pushed to for-rc. I'll send a PR in a few days.

> >> Thanks for a quick action!


> > No problem. 

> >> What a shame you didn't put link to the report, which contains reproducer.
> >> https://lore.kernel.org/ltp/Y1%2FP8gDAcWC%2F+VR3@pevik/

> >> Kind regards,
> >> Petr


> > Chuck, could you add that link to the changelog when you merge it?

> In progress, I'll push the update in a moment.

Thanks a lot!

Kind regards,
Petr


> > Thanks,
> > Jeff

> >>>> The v1 patch applies cleanly to v6.0, but not to Chuck's for-next
> >>>> branch. This one should be suitable there.
> >>>> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> >>>> index 98c6b5f51bc8..4a8aa7cd8354 100644
> >>>> --- a/fs/nfsd/filecache.c
> >>>> +++ b/fs/nfsd/filecache.c
> >>>> @@ -890,9 +890,8 @@ __nfsd_file_cache_purge(struct net *net)

> >>>> 		nf = rhashtable_walk_next(&iter);
> >>>> 		while (!IS_ERR_OR_NULL(nf)) {
> >>>> -			if (net && nf->nf_net != net)
> >>>> -				continue;
> >>>> -			nfsd_file_unhash_and_dispose(nf, &dispose);
> >>>> +			if (!net || nf->nf_net == net)
> >>>> +				nfsd_file_unhash_and_dispose(nf, &dispose);
> >>>> 			nf = rhashtable_walk_next(&iter);
> >>>> 		}

> >>>> -- 
> >>>> 2.38.1

> > -- 
> > Jeff Layton <jlayton@kernel.org>