Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ondrej Valousek <ondrej.valousek.xm@renesas.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "trond.myklebust@hammerspace.com" <trond.myklebust@hammerspace.com>,
        "anna@kernel.org" <anna@kernel.org>,
        Chuck Lever III <chuck.lever@oracle.com>
Subject: RE: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h
Thread-Topic: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h
Thread-Index: Adjp191PvyyHwERbQa6sSzLdPAGESQDJ022AAG/74zA=
Date:   Wed, 2 Nov 2022 13:37:52 +0000
Message-ID: <OSAPR01MB1843224082D47CC4C1E7352BD9399@OSAPR01MB1843.jpnprd01.prod.outlook.com>
References: <TYXPR01MB1854FB85D24BDED2B490B8E6D9339@TYXPR01MB1854.jpnprd01.prod.outlook.com>
 <Y1+BKY/nrDtTqkEZ@infradead.org>
In-Reply-To: <Y1+BKY/nrDtTqkEZ@infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?6NBD/kadcPdNl759Pf8sL6JXBD+iVjs3IL0RocEE0+YUMTbdn5iQ+6HRVR?=
 =?iso-8859-2?Q?Rze2IC5qEIdrkfM2kyV9ieYrtuKx2mCAHHkb3jnIDZJF1foCOCTH+GGkYb?=
 =?iso-8859-2?Q?vyDmxkyQRNBjinIQv9VWTsVWgu4r2jG8ZiyrmiQo45frebubx6dZq/nZo+?=
 =?iso-8859-2?Q?EWjuAG1GlhqxLsjxbpZf2743GV6NtWBdA7uP1sr1IuJhaogHVLYNXZy01E?=
 =?iso-8859-2?Q?PVe15poCmwQmUOhqjeYVYSp0B/jaBtKxfkc3NW693P3AGVILt5GnpUuRdV?=
 =?iso-8859-2?Q?Dq5rjjFN8fTqiC40JQEcqQXBY1/hB1D1vkZXsSRI4ApOyG76cvN7HjfOZq?=
 =?iso-8859-2?Q?xNTyIU/qGJ/5b81q1b0b7+0TW/AvFQo4vWLrNn1U5zIelR8KPAXbMv4wZL?=
 =?iso-8859-2?Q?PC5vzt6ZKAjOjnlYlManSlOxX+bXIBGX9yS06N3CdXX/aorNcD3c51Wu8Q?=
 =?iso-8859-2?Q?EnN4XVQ+uH7qN/VmcdXx52bzTMkD6GeMDTMXfn1xAORMBrUBCznis9J+dD?=
 =?iso-8859-2?Q?38UEMFphzJIwMHKn6fob4XHprdMO9JEp527LwLhR+u4jx/xh/G9pFEMlXo?=
 =?iso-8859-2?Q?LpwEG8g2yX9QsL3Sib5Q6UONZdw6U0uA5VTVzdYvewi8G+6z5VHPIsoS3W?=
 =?iso-8859-2?Q?zi7kmonfd9+VwjJC9ysVdielo/lJZvSILWkDW9h9qBFULRGWtuttZixhsL?=
 =?iso-8859-2?Q?tP2lZGG004ThvpRhZv9QDDN55WaVWTffV8mVaxpzwjM/zzNlkLFUkRT6/4?=
 =?iso-8859-2?Q?u9wAcgQGyLta31496Iw7fm+dY+jsMb7T+QoHyv12jQYJS0URtF/wGDgQ+z?=
 =?iso-8859-2?Q?EBoVLQ3fMKoCPf4u+7SVTr4DGyZEOIfY8tqKGbPSGBHVkafZE6OByYd12b?=
 =?iso-8859-2?Q?KbfN8ImgrmwZJjIweabYpwnxK6dFexcTRpa6VtKTPlQsbrC0DAyHv5lLHb?=
 =?iso-8859-2?Q?UOBNLL0p0tvBcUzYGEZaaTG43i1ix5xWkBJUc83UuHBMUC+MmFnVBiPCEI?=
 =?iso-8859-2?Q?/Y5BoHKgMLGrgdS3/ld2nydcTVxP16un2+rzVlinBjCa3AqLisXJ+CQ3iM?=
 =?iso-8859-2?Q?2Jzb/5n88Xcog4DK6GsSR1Vzm+4gdTmvKGBIdl4WVj0x1tppzebc8r0kNT?=
 =?iso-8859-2?Q?9ccAZElmh0Lacn6kpRAiapaGAZCgsGexV5EeKnuewdiLtzP3cJJqh00XP9?=
 =?iso-8859-2?Q?uUNYqfsc6TmKDMQDjHKwGAFdd/G05EgWo/RsDZDHKj+1rMiUsoA/UM3TYZ?=
 =?iso-8859-2?Q?aTnQUJSwLdI/84dVZ5B5VY1umojWnFjLI79AyYlkaQqZ7sK78bmhzYZ/rx?=
 =?iso-8859-2?Q?17FrClPTOEXUDE3G37yY9SoV96Ikv7ccz1lf6hAQ/anL8xnZCCJKArQXgg?=
 =?iso-8859-2?Q?g7t7sh6XZmnbMZNz0Mi5Ou0lD4UpGMj+xrR4D6cyiONRR8NrQ66PjG6b9b?=
 =?iso-8859-2?Q?DNlas+yar75H7LregUDBLZ0iZmoGJyiZiwIP02iUFcxFQKLFnmLbKuSUae?=
 =?iso-8859-2?Q?RgcKlH5WkIQRSIVEitw/8ZMTmpWmhRMhdbNQAMinntEXjFGlL+EOS5aa6K?=
 =?iso-8859-2?Q?G3FfohjftGnDNqADH4GE4CpBtK2W4HQhjd4DedNT373yzvjt2ZoTc4nu8S?=
 =?iso-8859-2?Q?sioKrh0iPBvzB8Asf9Nf8AeNYeoLU9hQ3JSjrPny1bUuik5XkkDeHWpw?=
 =?iso-8859-2?Q?=3D=3D?=
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OSAPR01MB1843.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dff7fb25-f980-4cf0-8ca3-08dabcd770f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2022 13:37:52.4787
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: X9m+H7+2BY8Rvbp76O+mdFZWnZvJhlq4i2pIa4KAeIsjZ75rEQ9pgRW2Y/vEbkTLiDAOaG1+TgSY5KJqh1APkpRoFqTSUrhieFOFdXcNv9E=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB7702
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Christoph,
> Well, for that a proper formatted mail really helps.

Yeah for the first main I used Outlook to send, the second email with patch=
 was sent directly using GIT so should be formatted well.
Sorry I am beginner here.

> And these identifiers do not belong into xattr.h.  They are a non-sanctio=
ned NFS side API, not a VFS API.

Ah yes, I forgot about VFS, true. What is the best place to keep them then?
Or is it a big issue to extend VFS with them?
I mean NFSv4 - style ACLs are IMHO even better than Posix ACLs - if not for=
 anything else then because Posix ACLs have never been ratified - maybe we'=
ll see them on local FS at some stage, too.

Thanks,
Ondrej

-----Original Message-----
From: Christoph Hellwig <hch@infradead.org>=20
Sent: pond=ECl=ED 31. =F8=EDjna 2022 9:03
To: Ondrej Valousek <ondrej.valousek.xm@renesas.com>
Cc: linux-kernel@vger.kernel.org; linux-nfs@vger.kernel.org; trond.myklebus=
t@hammerspace.com; anna@kernel.org; Chuck Lever III <chuck.lever@oracle.com=
>
Subject: Re: [PATCH 1/1] nfs: Move ACL xattr definitions to linux/xattr.h

On Thu, Oct 27, 2022 at 07:43:58AM +0000, Ondrej Valousek wrote:
> Hi kernel maintainers,
>=20
> Please help to submit the following patch into kernel

Well, for that a proper formatted mail really helps.

And these identifiers do not belong into xattr.h.  They are a non-sanctione=
d NFS side API, not a VFS API.