Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e67efff3f5f72d7bcdf90b972cd758e0e98e853.camel@kernel.org>
Subject: Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions
From:   Jeff Layton <jlayton@kernel.org>
To:     Li zeming <zeming@nfschina.com>, chuck.lever@oracle.com,
        trond.myklebust@hammerspace.com, anna@kernel.org
Cc:     linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 03 Nov 2022 05:43:55 -0400
In-Reply-To: <20221103013510.3062-1-zeming@nfschina.com>
References: <20221103013510.3062-1-zeming@nfschina.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  include/linux/sunrpc/svc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
> =20
>  static inline void svc_ungetu32(struct kvec *iov)
>  {
> -	__be32 *vp =3D (__be32 *)iov->iov_base;
> +	__be32 *vp =3D iov->iov_base;
>  	iov->iov_base =3D (void *)(vp - 1);
>  	iov->iov_len +=3D sizeof(*vp);
>  }

Reviewed-by: Jeff Layton <jlayton@kernel.org>