Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <229b424a647bfbd18942eefef4cbf6332607ca2b.camel@kernel.org>
Subject: Re: [PATCH] sunrpc: svc: Remove unnecessary (void*) conversions
From:   Trond Myklebust <trondmy@kernel.org>
To:     Li zeming <zeming@nfschina.com>, chuck.lever@oracle.com,
        jlayton@kernel.org, trond.myklebust@hammerspace.com,
        anna@kernel.org
Cc:     linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 03 Nov 2022 08:49:24 -0400
In-Reply-To: <20221103013510.3062-1-zeming@nfschina.com>
References: <20221103013510.3062-1-zeming@nfschina.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-11-03 at 09:35 +0800, Li zeming wrote:
> The iov_base pointer does not need to cast the type.
> 
> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  include/linux/sunrpc/svc.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..4b0eead91c94 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -222,7 +222,7 @@ static inline __be32 svc_getu32(struct kvec *iov)
>  
>  static inline void svc_ungetu32(struct kvec *iov)
>  {
> -       __be32 *vp = (__be32 *)iov->iov_base;
> +       __be32 *vp = iov->iov_base;
>         iov->iov_base = (void *)(vp - 1);
>         iov->iov_len += sizeof(*vp);
>  }

If you're going to submit a patch just in order to strip unnecessary
casts, then why are you leaving the equally unnecessary cast in the
next line?

That said, why waste time "fixing" an inlined function that is not
actually called anywhere in the kernel? svc_ungetu32() should just be
removed.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com