Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Neil Brown <neilb@suse.de>
Subject: Re: [PATCH v6 0/4] nfsd: clean up refcounting in the filecache
Thread-Topic: [PATCH v6 0/4] nfsd: clean up refcounting in the filecache
Thread-Index: AQHY7us2x4AE6NdJ9E+wA555QW0aUa4tlKCA
Date:   Thu, 3 Nov 2022 19:19:46 +0000
Message-ID: <5952CF99-C6B4-4CFB-B518-395FF597344F@oracle.com>
References: <20221102184450.130397-1-jlayton@kernel.org>
In-Reply-To: <20221102184450.130397-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rvsFpmHzE1GCrGj1hRIgpE7m+3rB7A3f57ZmOKO6gLFII0fQZvfQMP+GvvkX?=
 =?us-ascii?Q?o7rRsNfFBt1LdX4TNnVqimKTwp4jKYWKHhbvgwSuO1ExnEKDMvsZ32dzo1xA?=
 =?us-ascii?Q?DFBxDz9FYyzl+yx86gx1DAx+P5lKrrdvt5MvNdGJpXnQHqi4sIwDfhF6kXG0?=
 =?us-ascii?Q?tfcSeiu/+rxOGZt2geIiKwZjMIwsVp1bfrxYncHFxHauxWeAPJHfO22bR1h0?=
 =?us-ascii?Q?copX+xxj+bf1rBVzNCLVt9GJOErkmx5TEwwJbERY4xgUlnVkLWLQI8yMFH64?=
 =?us-ascii?Q?M2mXhUqLIXVdCaf/lh8qldq7gyZ21p3IH8aD1dTl/B+dL3WF/iHu9dHlQX+O?=
 =?us-ascii?Q?YgAPLADiQVTkrUiF4/UngtL2PLj2py4164BGVLwyYGVsybJYX1TOzxSK1O5+?=
 =?us-ascii?Q?i8r03bSmYWYZSpIkSOJhnrj/ZFJhRJMc/77d882Cny/TTIymMkqLeHNd5AqB?=
 =?us-ascii?Q?5ZKXlzgYOaHkFXfu8/XdtyqrZU4+Koo28utaMQVFES4wym3P7O7wAYQebEva?=
 =?us-ascii?Q?HNywA/rMUV5NAGTtwjBeQu59rUHrFQtjfr1/cdKMAGWvsNkrKzpQjqPhO1Vt?=
 =?us-ascii?Q?ufzc3y8oPGycRxFmhXRuI9R2Fjn8bXwP3RJlaSkSHki4iIvdxOiGtHYXNNAY?=
 =?us-ascii?Q?hGx9LS49eSqW4Y2iYfCui2SdV8WKwcl6+u4tlXGYlz9Aj/4oqEnOoyC3F8r9?=
 =?us-ascii?Q?/MYzohNXIAsj9UJB/9x0mlAounOhoNogdSrfsuaIM23YGzIfbJiR9UNMZpWL?=
 =?us-ascii?Q?2OClXY4dOZXZASbxlM7/ZI1+Q5ptnJdR/AmU8ND4dSVN39zUw3g+T+DHGd9V?=
 =?us-ascii?Q?qaLEOoM2Ioz5Is+XwM+8RetXwYL41+fpWQPkyDaxFGYYbg55lOFsbB57oK70?=
 =?us-ascii?Q?YAGOH05RK7J4CharSrxzr77WwJta0mF5Wnfu6s+GRDYGcTTnL4fmWtI/RikW?=
 =?us-ascii?Q?hcgaUHIsyBJHMc2XUzigQYbh0hARZXBG+RxH30w5U0QUxpzzt3VPv+Yr0iXf?=
 =?us-ascii?Q?pgyBa/3PKko0imE7O9cvSA4A0tk6eS7k4iq8o1Hz7yZBvtD3n912OX1/uE/5?=
 =?us-ascii?Q?uafXEIgOLI429Bc8vQRy4iFGF2UMGdM1tR1Dcizzqr0RVI13fkbuBxf39Zg9?=
 =?us-ascii?Q?OgN4lK6P8234AeqtmHNGDXg2/wWbzDkHnlU/1ggyn5xln75yAFGQf+y+CpIy?=
 =?us-ascii?Q?EfIw+uXJD58SsypvB3f8jNp8YG1e0W6fxEM+cVjiu5fd/nKrLAEoe0Y4jSLw?=
 =?us-ascii?Q?v0rgaKNri7Yp4uwejX/8QAAXZKj2sDY8JBXLv9POPz4ymnrlwN/dGwq8kxJj?=
 =?us-ascii?Q?aOCOWI75JmwbpoSUxR3wF598/7v1qLwZGKd2Sx7vbGO7UJ1izbJ2Y8tJH+w4?=
 =?us-ascii?Q?wChcr7uxhD8Ya3wHneORgAeU70rUCKrlpKVy7bsadKDmKmb83FzxGkGecPhT?=
 =?us-ascii?Q?Jn9NVhpFb5O9pyyEDl2ULwGsZ3Pwn9v91Rc/OXLvulM1GcrU4EwzjM/GBk3G?=
 =?us-ascii?Q?eRotZhKVu18AMdVy0ezT/hMirjbv7l67mGGj1mc8NhwdPAZH6l+8w+/5xNSW?=
 =?us-ascii?Q?3K7t+hqsvlPHGtxoWATE5z+qXAYVvUbRVxuBt+gkdWZ84WA9sTNkIJYrtOR7?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0236AA3762AD964C8BEE60C681F89C60@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd91bb3a-d0fb-4996-2764-08dabdd05edb
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2022 19:19:46.8301
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3cI0Y/h9iecDsFYVaLw0GF93kS+vTmwP0fQL74aJe0K6t1gGeh/SZlJVpPSZCa+wSXpLC4UYKuXckrxDjvoVKg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5380
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-03_04,2022-11-03_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxscore=0
 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211030130
X-Proofpoint-GUID: M8MvEZFyCnIqyrzw_QhxD8mQyVlgyZvI
X-Proofpoint-ORIG-GUID: M8MvEZFyCnIqyrzw_QhxD8mQyVlgyZvI
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Jeff-

> On Nov 2, 2022, at 2:44 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> v6:
> - merge the LRU handling fixes into the refcount fixing patches
> - call nfsd_file_close_inode from the notifier callbacks, which
>  decrements and queues any objects to be freed by the disposal
>  workqueue job
>=20
> Only two main changes in this patchset. I folded two patches together
> to avoid a problem that Chuck hit while testing. The other significant
> change is to have the notifier callbacks use the disposal workqueue
> job instead of freeing things themselves. Those don't need to be done
> synchronously.
>=20
> Jeff Layton (4):
>  nfsd: remove the pages_flushed statistic from filecache
>  nfsd: reorganize filecache.c
>  nfsd: rework refcounting in filecache
>  nfsd: fix up the filecache laundrette scheduling
>=20
> fs/nfsd/filecache.c | 406 +++++++++++++++++++++++---------------------
> fs/nfsd/filecache.h |   1 +
> fs/nfsd/trace.h     |  11 +-
> 3 files changed, 222 insertions(+), 196 deletions(-)

Tested and applied v6 to nfsd's for-next. Thanks!


--
Chuck Lever