Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Li zeming <zeming@nfschina.com>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sunrpc: svc: Remove an unused static function
 svc_ungetu32()
Thread-Topic: [PATCH] sunrpc: svc: Remove an unused static function
 svc_ungetu32()
Thread-Index: AQHY7+7RIkBteehaLUSI+nX8T10Ar64ux1KA
Date:   Fri, 4 Nov 2022 13:44:43 +0000
Message-ID: <A9993DD4-5A7C-42FF-9CAB-6BFD61075981@oracle.com>
References: <20221104014303.3146-1-zeming@nfschina.com>
In-Reply-To: <20221104014303.3146-1-zeming@nfschina.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1eTRFB0dqmmrBljO6ZR+ogG7ta5+h+D41jsgRFtbJ8p3BJp1t+5HDnbsZE1Y?=
 =?us-ascii?Q?6O/qhldQQCK8c+YNaHNS0hU8YnVMEZC/y6znFNyhVt3lFP+j0ZCwncRkJw0K?=
 =?us-ascii?Q?3geAhYfZCQ6SO1Z8FkEDEiLdySoq8v8EpJnPZCcTEF97YLUK39RkMbSz8d0T?=
 =?us-ascii?Q?SOFU4LxED5Y2eunL99PKHtpuYrx30UqXXhH1Qa9EjhZLTrNnH/fG11VIfk8J?=
 =?us-ascii?Q?SReti54jjr85CnXwk3sqc1bKOMwtV4pBREyjEOkRZXrZ9TFzqUiua2CbUrSe?=
 =?us-ascii?Q?DQ70LVpjzcPV3Z2DiX/INZjar7gwnQ2+SEn5fM/EA/uNjaiaT1P+0MJKUhvk?=
 =?us-ascii?Q?34+Xi/h/TvwWjNiu34dTKx7Bv+4+0Tas+7dorPWY5k6eDLQ9FbDyv3X9e02I?=
 =?us-ascii?Q?CbfWfXSNBDYJLQvAnl6JaoEl0R5OoseGtJrshKALQdY+rKEgnVS+gU1iF6Ms?=
 =?us-ascii?Q?4hxTm+txrLJr6UNxv+cImxjg5oYg/IDQOcBCuGMQjY6y53JAFovb3agLMByr?=
 =?us-ascii?Q?GO3OMXFaUtXX02B9yNRtuOdmlT8kHMLg0sh2LdZZ+cIT2svcAFzxy5dCqFTo?=
 =?us-ascii?Q?xAZIvJ+TN9CLJN9ggIuuogsT90fW7w/dxfCG9y6+JdbdPvPrsDZP/drFhuD3?=
 =?us-ascii?Q?eyRFuB02G66raRi7Yhto2X09Iafbg2hUnM4htsgdFynJQvsl9aAP3ruE2IKq?=
 =?us-ascii?Q?5hN2PqhmFgcWmwb1zov739fSK0Fex+sgyYVCi/nXE9UIvBK1ydF5UQx/JMdH?=
 =?us-ascii?Q?FGvWYKNn5cGi5fOJCYpzHyCAfs8IFOxjpfjXjzBHJ6vw+F6aeWBpPqxfJ2WZ?=
 =?us-ascii?Q?Ja3oIOwtHKGutr3KSYYS4jmfpkYqtau4QEAV7HD6lffoXSZSEnvZSyjtrP73?=
 =?us-ascii?Q?W1QjRkQb3P5pHTd5lbzyAYeA/bhgxcxw2Osk0MsW0ZLUUjy8LG7GNV5z9/+o?=
 =?us-ascii?Q?QeGmMaKxK5UUYjawG6Bpb9ndCLK8uDoSd3Vy058wOm9tnDXdptmrsmhSeTTv?=
 =?us-ascii?Q?m5OQvNOt6efS/f/MnJKIW6aeGUhSTLLggY1yhrSTvm1RmRBW2PPYsSDz/IBh?=
 =?us-ascii?Q?RtTn0c/9PBlMb9xIgkErSlYQRwRGawOEUNG9OKVQyudKXt4dSZh3UmRkcTA6?=
 =?us-ascii?Q?pM9qvyrFvGona8vQOlLR2p6LnI3LZ+l4/WxtYE/S/Fq0OmYaqvx5W0TGNYq2?=
 =?us-ascii?Q?HEWvDUgos9e1nIDiO5PAV1sd+TMR9V0e2KiSgWmN2sU6L3kxB1MRdDhplMZx?=
 =?us-ascii?Q?zleU/+cKLH7JIhTzb2YXDJ64sbB+pscjGgTb/599CCANiFkcHVed1+sTMYQr?=
 =?us-ascii?Q?uAchT3ulikSYUhFvtGWfZrGflNmUX+ZW0Fff4SsQAkb3nT2C2Y6/ub2mqcyE?=
 =?us-ascii?Q?482ghKMc8vQprf+oI3UmkPGVxV04BKE409RphlWylnDkH/FXcwFRweVApFZJ?=
 =?us-ascii?Q?kgLpIrQAyOXokFzAdrx2feILTrUWlK7o1aEt6CaOfL8aw7bSkyvL2lBup2LA?=
 =?us-ascii?Q?SA1l/yHcrg6sRSaAdEqEMtuZShoPpceysmSqT9x/araPkTH6GRi+UVEdh2rq?=
 =?us-ascii?Q?SoA+gTj5zee4I2d/COvbEMXKgNYleaQROZ/dp5XWdO1IAFKZVlxWW5GbHrz1?=
 =?us-ascii?Q?hw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E4DF6AED329C0F478774C043AC39ED61@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38cacc22-831f-4eb3-31ad-08dabe6abad6
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Nov 2022 13:44:43.6444
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: S/6NRLhsYSx/yjyK7GVh9/5oR7hLnZeWnkZKub6lPIRDpBUsJbXEiPP3qJckVbHt7A1ULelxZjJzGh03M6KqOg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4535
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-04_09,2022-11-03_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 mlxscore=0
 suspectscore=0 mlxlogscore=989 malwarescore=0 bulkscore=0 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211040091
X-Proofpoint-ORIG-GUID: LSjrp4yXN9H16-2dwMifTTHG1qmffoJA
X-Proofpoint-GUID: LSjrp4yXN9H16-2dwMifTTHG1qmffoJA
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 3, 2022, at 9:43 PM, Li zeming <zeming@nfschina.com> wrote:
>=20
> The svc_ungetu32 function is not used, you could remove it.
>=20
> Signed-off-by: Li zeming <zeming@nfschina.com>

Applied to nfsd's for-next. Thanks!


> ---
> include/linux/sunrpc/svc.h | 7 -------
> 1 file changed, 7 deletions(-)
>=20
> diff --git a/include/linux/sunrpc/svc.h b/include/linux/sunrpc/svc.h
> index daecb009c05b..6990867470ca 100644
> --- a/include/linux/sunrpc/svc.h
> +++ b/include/linux/sunrpc/svc.h
> @@ -220,13 +220,6 @@ static inline __be32 svc_getu32(struct kvec *iov)
> 	return val;
> }
>=20
> -static inline void svc_ungetu32(struct kvec *iov)
> -{
> -	__be32 *vp =3D (__be32 *)iov->iov_base;
> -	iov->iov_base =3D (void *)(vp - 1);
> -	iov->iov_len +=3D sizeof(*vp);
> -}
> -
> static inline void svc_putu32(struct kvec *iov, __be32 val)
> {
> 	__be32 *vp =3D iov->iov_base + iov->iov_len;
> --=20
> 2.18.2
>=20

--
Chuck Lever