Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Neil Brown <neilb@suse.de>, Yongcheng Yang <yoyang@redhat.com>
Subject: Re: [PATCH] nfsd: return error if nfs4_setacl fails
Thread-Topic: [PATCH] nfsd: return error if nfs4_setacl fails
Thread-Index: AQHY8qBNetvl8sasZkCTSpe8OKZOT64zg0AA
Date:   Mon, 7 Nov 2022 14:21:40 +0000
Message-ID: <E4578066-9B1F-4CF2-BD22-958A649900EA@oracle.com>
References: <20221107115841.26380-1-jlayton@kernel.org>
In-Reply-To: <20221107115841.26380-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vWFyciaI82C/JLUGSkSvB6R8E0mm4bb+N65SHLPZpSJO58X7CR9cPz1EmeBZ?=
 =?us-ascii?Q?xaAfrHo4Y6sOY8Ju+72uXYCd0gQdhvgD4KkfZU+/r2CJsv83+wZuxWabtOAi?=
 =?us-ascii?Q?SAJRJJTV394L9ObQ5DbEKIMMW/IUQVhZYygPommIr5n0heX2h2EF9hM8Ngmt?=
 =?us-ascii?Q?37/8UjaqIVrJzdW7TbDpf2VmIb30PersEkoZL90LaeIFd39ymhZm07VD+HFZ?=
 =?us-ascii?Q?i1EEOe/mLsI3OzXMCLmS3lbSAzRQlPxSdP2EY3TKFjWbXBswgFqJwMDgCxNC?=
 =?us-ascii?Q?jGmJceopQcIYeKRr7obKyNmq/681VBIQ3jtDbM8AZ5mh7MtlksbO5dTpZop3?=
 =?us-ascii?Q?EI3FiyGtqVgAZY90++FS/H5gcnAU2QTJ0Q3TP7TjXFXp0nfNtSUyMxrZrSqA?=
 =?us-ascii?Q?VXSeSuvIP7Gp8k4mriqk+L7PxVF+Or5bCxYrgBXEiL8AoHzqPpUrJYAPbpVm?=
 =?us-ascii?Q?kzQSWc+eTjR4Y7q6GfjKFci+DW/MEpU6Ao3xoZd91mdWVSiLjbLZkZZCWi4F?=
 =?us-ascii?Q?fuze4+G94Wsxzy57Jt5Qo07nILgYIcAfBLhuRbsmLd8BdYJbMkgtKKUa1aAg?=
 =?us-ascii?Q?t+P45rprnSNQL6ci/V9Kw+VyLnd2q6BhVLBKztZV4+yr6Ae3hcXiurvyHehX?=
 =?us-ascii?Q?CCSSYRgWeVIjlI2Us49OxFY6OToiMiH0xeY+KStFCCp7jXRECviCYT55DneM?=
 =?us-ascii?Q?BzZGozqATrMoTe8xSxFrt5I7iZGpe6Ua5LbHqQeSd0nxT72T8sSvRG3q3yUo?=
 =?us-ascii?Q?8du0hlOOdJfLMt/8LCP41zRlX4dW6GBMP0gx4FOyHytLacP0Dc4mud9z+a7s?=
 =?us-ascii?Q?QloMcywiGXgGjWIKM9XUsxlK2KWLldB6/VHzC5B4C62TIgyQLyRDS8YGmHY9?=
 =?us-ascii?Q?6I9SRn+qZFKslLzm/fs52JoT823+NFf1C4Q09cMXZQ5zaXY+xMXSBHeoJU6I?=
 =?us-ascii?Q?DLSVkl+O+ZtHZJE0r2MLGb1anbMWqk+GyY8Esx2OkqWUyEag57RRA66Yk6vu?=
 =?us-ascii?Q?9qJbr2Nu9dOitsbbG0a7b7keo5m3E3cPPPSEiniBZRYBymO1GpXh8rAS4DYy?=
 =?us-ascii?Q?pvZ3KgM7s1dwsWofMHNTQl34/suPboL9TB59b/qNs/glRiuUqkCk0bYH+BIH?=
 =?us-ascii?Q?EY/i35bhZ0u0Tb+7fQ4VKkcseSI41/rT967+qSVtWZh2+clSB9/nM0cQ5hZX?=
 =?us-ascii?Q?AzKZjTltbdAmxX2yBMfxErijAX/pOqMq2hFiiOebPOGCjiO1nrN8baZSEH3i?=
 =?us-ascii?Q?51Cbm3SQgbVPhSEfZaC/xoX6/The8h8LXT64D96HCKYpaIVQ3PZnHKJoxiAj?=
 =?us-ascii?Q?EHeKsEbFHYAg+xixoRX0v0d/xNooix4IVzMLkxAcjs8+y7CZXDI48i4dBlUg?=
 =?us-ascii?Q?TXtAzByHRz38LEgtac8/HEjNKy+AZFNyrJCABtVty3UwDnaWqA8KCTDX8JJu?=
 =?us-ascii?Q?b1IIQTsejFnU9drReImvtr045+9r8FnNO578LKPWRns7DNprnnyrW2uUT6AX?=
 =?us-ascii?Q?IQKPeVXYoCTNpiXFdM8pTnsJmtYwHUt8V1vcFiJ8fydyrcmHbE6ZsJno0emZ?=
 =?us-ascii?Q?LF3K1XgcT3aOPj4uGiJmMSSVMc5yN2rz5jcg0EUtEhNGSIBgSAOOD2ibyfzQ?=
 =?us-ascii?Q?Nw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5BBEE5BF7C2227439A193B0B975C45DA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 82264880-8335-4f77-e10f-08dac0cb63bc
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 14:21:41.0094
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0f3AgN5H29BNJ6+3jRPUPDs6zwiQ+pru0ixr7HyegBPwjDN9cz6YsWwtTzIxlX6VXXLziGpjDy21/Kt1Xgnnhw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4458
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_06,2022-11-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211070115
X-Proofpoint-ORIG-GUID: UA8IlZquoTcyDG62gguXhnvkWS0Jkr86
X-Proofpoint-GUID: UA8IlZquoTcyDG62gguXhnvkWS0Jkr86
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 7, 2022, at 6:58 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> With the addition of POSIX ACLs to struct nfsd_attrs, we no longer
> return an error if setting the ACL fails. Ensure we return the na_aclerr
> error on SETATTR if there is one.
>=20
> Fixes: c0cbe70742f4 ("NFSD: add posix ACLs to struct nfsd_attrs")
> Cc: Neil Brown <neilb@suse.de>
> Reported-by: Yongcheng Yang <yoyang@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Applied to nfsd's for-next tree (6.2). Thanks!


> ---
> fs/nfsd/nfs4proc.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 6f7e0c5e62d2..a6173677b766 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1135,6 +1135,8 @@ nfsd4_setattr(struct svc_rqst *rqstp, struct nfsd4_=
compound_state *cstate,
> 				0, (time64_t)0);
> 	if (!status)
> 		status =3D nfserrno(attrs.na_labelerr);
> +	if (!status)
> +		status =3D nfserrno(attrs.na_aclerr);
> out:
> 	nfsd_attrs_free(&attrs);
> 	fh_drop_write(&cstate->current_fh);
> --=20
> 2.38.1
>=20

--
Chuck Lever