Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: queue laundrette to filecache_wq instead of
 system_wq
Thread-Topic: [PATCH] nfsd: queue laundrette to filecache_wq instead of
 system_wq
Thread-Index: AQHY8rndf59pLVGVO065DXdRZAFKja4zkPUA
Date:   Mon, 7 Nov 2022 15:11:26 +0000
Message-ID: <2FC9BEB2-189B-4EF6-AC61-40263BC47737@oracle.com>
References: <20221107150128.46951-1-jlayton@kernel.org>
In-Reply-To: <20221107150128.46951-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W6o5QXdqMVIqpCQZr8qZZ+OIqFNtq23I+tjrRftFbYFsbqpg295SSYsl/RtJ?=
 =?us-ascii?Q?BLxBlIe/hCiE48bCwcd/z1Az4MhoyPR0YqLamUVRtLHJa4ExH24TUuCplel1?=
 =?us-ascii?Q?EXao6v7sLhH9dPkKEGV1TnPIKUnvYeWrJ2MpRGXfHk7VlMFhoXs3xuVLb/IA?=
 =?us-ascii?Q?XoGpt2UMuFWLJwrMv6oZUQ/q3QLyekmWWzs8CrhqSU6m4TED6Z9fxinGg+th?=
 =?us-ascii?Q?fZ0LSSHnuECcQIIt5+JLx/pT7JPrp8Jt3BiMpooI1r/xAlZmPRXUbziIGa4F?=
 =?us-ascii?Q?A3uTmtAWUzO0QHtBgeOnJfDVYpOX3YQtXsvgKy3IKvJbSG367U9byQCUVn7C?=
 =?us-ascii?Q?1MrT22/YIEncoLCjWnIcLM/LdzYvgwYpiHfBfp4tO/QAP0yTP16JLbROTmXR?=
 =?us-ascii?Q?xa+fn9H1KOIbRePxumvpzXtSfzgFy1qBbN/c48tCRcXuKI+Sh0C8P/8beoWc?=
 =?us-ascii?Q?3RLrVvQ4lpQXS1gHRzo+rKcQjK3V5HeDyjFMIdsdgKsCUyE5I7y7A1Uat30b?=
 =?us-ascii?Q?Nj4iH4IWWO0Yuj4OSUc8OtwK5swYEV1rcdTUrh4kNkOEl/ptTlUzxMfca1Di?=
 =?us-ascii?Q?/hVnvcS23T1Ud/o3LBWlwaEpKqJoGhdhJnBs+CmrOChb3vriXi/6pavy8vvA?=
 =?us-ascii?Q?MyVVYdx96n0yga3Oyys69dTscL5UBlWJFu63cM2xEBTkhETFz+6bAc25kFWw?=
 =?us-ascii?Q?mh4mFpHH6C9zozDzvR/SXH3pNlW2GmCDG6FtIJsArcZ8UqQWxBJ38sFBAcc1?=
 =?us-ascii?Q?ybHAvf8ShYOlf1vY1OLFEKu4u5u4GSQxytXWeCAly5mzQOdC8vzuItzY8eHK?=
 =?us-ascii?Q?/tFpoVfUimUywY/LHSJryfnPFe8jZ/qK1jP2QUL4+XWxNKp59oU1Yy9r3HOq?=
 =?us-ascii?Q?FkgbT7aJ/gli6J6TdtmCyule+5IJ3yZ+Ey14AwqkYNWPOxz8lGHdQGyNveUm?=
 =?us-ascii?Q?cMBO/xljrlBU4PpCwmxKVx63+3QwhN1ajeU+PdXzshL+a15IZN16OMOKv/jC?=
 =?us-ascii?Q?4oUwMkyIgNXttHMjE3o4Sfi3SjzsXEaFBwF383HrxNLLHsbAANrR885taV/W?=
 =?us-ascii?Q?vc92GPpJUj2Z2OgB+OtVBbrnuponG4tO7RGq3m5ubCCfiR8RR9CeYgVUfRt+?=
 =?us-ascii?Q?ye/UpXJkPxnYeWr+RPjDTzOlPZSaxDr4Og/QQx7hqP18i+RFttj75zSG5OOv?=
 =?us-ascii?Q?+AR/b/8Ds9R+0mKydwIN9tYSRBJVdUjxp3zaHZ3E3feoK3p4El2F4hQzM8YS?=
 =?us-ascii?Q?uo4HFmpQTBa+ITjC47NmFCqRwOc6n3rQMvVxX2pTVPQHNM7Vvl2xHyyGZ8eh?=
 =?us-ascii?Q?inydZ04IHif6352WGQ1Kw7/SCWvmGv2FmX9LTAK6ss0y1QIb77bWj4jSc/7f?=
 =?us-ascii?Q?yEjazgJwqSLH9kg4SOMT1y9jklM+omoqrNyGC6pez/Khf0QvaiHhw6vUNLbk?=
 =?us-ascii?Q?b2yvuM/1KAEyqB0hUjBhodgd1xXUDFSdUkDvk3tGNEorSn17X6qF0KH6ZcJi?=
 =?us-ascii?Q?jkpiStP58KU2ws2h8ivLLZ4yCTW1qK6IGe3Ea/UQvlBPKPmW5kA1K7Q2LWK7?=
 =?us-ascii?Q?CzVcH5cZfA6lkiAxS0GuLpSKsEMi7shZAka86YAhPQxTGne9gnoXeKSPf7UE?=
 =?us-ascii?Q?Ew=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <869FEF4BA627A1499735EA5DECDE8E5B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b8d5df39-a61a-4b7b-574f-08dac0d25781
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Nov 2022 15:11:26.9636
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /J1+yVar8VG/8nIN4khm3QxDCZbb8iX8bUXFi1vu76mh9tbh++D3fBs3l2X+GzyAluYzdx0wvMYzSN/MDmm1Kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6475
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_08,2022-11-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0
 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211070122
X-Proofpoint-GUID: ZRqC11sgTN_yDPtpw3DI2cMmf5pTOC00
X-Proofpoint-ORIG-GUID: ZRqC11sgTN_yDPtpw3DI2cMmf5pTOC00
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Jeff -

> On Nov 7, 2022, at 10:01 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> nfsd has grown a dedicated workqueue for the filecache, but this job is
> still queued to the system_wq. Change it to use the filecache_wq.

Actually... there doesn't seem to be anything special about
nfsd_filecache_wq. 9542e6a643fc ("nfsd: Containerise filecache
laundrette") does not make clear why it was added.

Playing devil's advocate: why not make the converse change and
replace it with system_wq?


> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/nfsd/filecache.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/filecache.c b/fs/nfsd/filecache.c
> index 1e76b0d3b83a..018fd1565193 100644
> --- a/fs/nfsd/filecache.c
> +++ b/fs/nfsd/filecache.c
> @@ -212,7 +212,7 @@ static void
> nfsd_file_schedule_laundrette(void)
> {
> 	if (test_bit(NFSD_FILE_CACHE_UP, &nfsd_file_flags))
> -		queue_delayed_work(system_wq, &nfsd_filecache_laundrette,
> +		queue_delayed_work(nfsd_filecache_wq, &nfsd_filecache_laundrette,
> 				   NFSD_LAUNDRETTE_DELAY);
> }
>=20
> --=20
> 2.38.1
>=20

--
Chuck Lever