Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>,
        Yongcheng Yang <yoyang@redhat.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] nfsd: put the export reference in
 nfsd4_verify_deleg_dentry
Thread-Topic: [PATCH] nfsd: put the export reference in
 nfsd4_verify_deleg_dentry
Thread-Index: AQHY845pDsdDj46Z8UGbnOuwZh9Al641OkwA
Date:   Tue, 8 Nov 2022 16:39:44 +0000
Message-ID: <A91EAEB8-4EDE-4AEE-AA5A-6DBBE6AA6866@oracle.com>
References: <20221108162311.320755-1-jlayton@kernel.org>
In-Reply-To: <20221108162311.320755-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/gmRFuUkksTE0YRjRzHpcEiT+SEhp+DEEI0v2xcTBpGeEL2vQuxrrjZ7T3tB?=
 =?us-ascii?Q?p5iAW71fVtc8fKgvFxcrg62MghynvsjBNpOqAShRvQiDkAxQMlprDURB2XHB?=
 =?us-ascii?Q?/imKKIiNRAtWOP7YekJ3mRpi5n89IgKgaqOGRwujfILmBEDPvaJSUICWtTsm?=
 =?us-ascii?Q?o1pqMh6S4tW5fCGfr6lvF8HfQjl2wtH/txjgRfA291Wmq8Au0O0hC7UQbVkW?=
 =?us-ascii?Q?UdIYA7wYQwEz9uH476Np2LHXDr679hfjW+CuBsCDEJvWmjqfx2s+Gz7jOOyt?=
 =?us-ascii?Q?NkCuw3iyivAbxbtEd54bgHdj/KnzQwZDwMMRMm/E+RYm9AuKDAnDTLS5nZmn?=
 =?us-ascii?Q?G6LBhe2A49jKWvbd7nzA09Ov4JtpM4Jmk2G7MGqL4xeeLNfCEnsKxJUBacgy?=
 =?us-ascii?Q?XZMZpspT3kcfFm7HyWWPy+eVoQMnmB0yIcGw+p6st5zp+Rq6gC6zB6ohKhg3?=
 =?us-ascii?Q?Aku9gmRFpyP8gpSeB/tms+LOgpGPXBuwfX7qlZ07hyKWux235PqXwIKsqANO?=
 =?us-ascii?Q?joiib4DklSdOr7ZGRDyhVf//qGwljAlO9+F9pjCXoOAq8qhjpydLq403m9P2?=
 =?us-ascii?Q?1Wr9I4cqxEdN53GhRfA37pA5bW4KoN/gHbidLxsOuF1szJqxprJxLJSwwsJU?=
 =?us-ascii?Q?UV6MyQmbkWY2ioyLgHp31exjlsU32nLYwGZgBs+h39IapTETgsHH2lEB4DbH?=
 =?us-ascii?Q?xdi0GIztJeJw4WmLDE7HgifhoJUuGE1m0kyP1BSFq+ZpVBd8dvBP0YkWp1/C?=
 =?us-ascii?Q?c+zI/OEveOwMb71k+gj+dsBMEOqj0gBqtWfnfxV76VcLtUy9DRbenvASb+GD?=
 =?us-ascii?Q?E0vt96t/vRk+eWkNhGugbuIC+cOH7gOfNISVkhBKeKOCBqmMhz813iycnMLm?=
 =?us-ascii?Q?binmLlD7tgbylbThg7FlZnPGPIBNIKWkFfar9hdd8CbVx+C5rMDott/aYmt+?=
 =?us-ascii?Q?+TDx6YkCpk426SV0lFxyejjHE26ZWiknL1ij3VsXNHjVN7cFMruNL8ZmTTNu?=
 =?us-ascii?Q?+2ZK8dAkx6Z7eqAILFlRnRkNzKlA7BFtKtG028mzo0kmSLivpppjfIxYoJiE?=
 =?us-ascii?Q?q8IrOeVPC1M2AYD8wsVr08SYezwcE2PgE0E1YQhuQIIOtc3nIOgDWJ+fy+Gg?=
 =?us-ascii?Q?aY9BbqLzaeTohwLbQfbiSFCVo1IyVmbne53NtjXByM94UO9zxxYUgm6UarNY?=
 =?us-ascii?Q?FXGvAv1ofFMh+uGAnQQuS4PTrqEIWd7NOVKx1keJGUC8C0yiQZS0HZhllEiG?=
 =?us-ascii?Q?fJ0WC0lgxbD3EkIYuecCdZLnM+Au0gSHc3yKMYaKptdbmrIs3Nwr9xYpvWqs?=
 =?us-ascii?Q?HtLRfRtPkcoVFBpsJvIt9LjU1Ex7+BIVFZYVE+3uhofXUtEyR3OspuQbdy5j?=
 =?us-ascii?Q?fJ4b9HnN/mLR8lWGRRvKjrNlXOV0o3+Z7LEHK5D6hfwxfrbZkN0IfPr7/Nib?=
 =?us-ascii?Q?MR4rrqMbSyHcMFSXYTcOYxz/TI8H4WfMt0NtFcdP3ERpty666/aRp/9TZ4o2?=
 =?us-ascii?Q?BjPrekAgPtkOqvWEYBtgCMjsPF4wLup5/Q7SJmOSTVDFzKMHmWvkj2idQyZN?=
 =?us-ascii?Q?E/yy4eCoYvDGhL1FoH4+1oPGfQVn838B8x0K5AC1WLCo4vrz2cVyNqDKKlz4?=
 =?us-ascii?Q?Pg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F6C12283B9F3654B98F9622A52596762@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4c623e-370e-447f-1d1b-08dac1a7d78f
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2022 16:39:44.5900
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W0iXY6CHtZswcZpnYOkWhYQjhgeLPqsHGI6TYBcWMGH6ox4yYdcd/OZLdMrcdNoG8Ycsd+L5mJ9rG8Emu4tJJw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB6960
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-07_11,2022-11-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 adultscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211080103
X-Proofpoint-GUID: Ycn-9rDWKj015Rd-nQ-pDLz6wFDGgeJR
X-Proofpoint-ORIG-GUID: Ycn-9rDWKj015Rd-nQ-pDLz6wFDGgeJR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 8, 2022, at 11:23 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> nfsd_lookup_dentry returns an export reference in addition to the dentry
> ref. Ensure that we put it too.
>=20
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=3D2138866
> Fixes: 876c553cb410 ("NFSD: verify the opened dentry after setting a dele=
gation")
> Reported-by: Yongcheng Yang <yoyang@redhat.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Applied to nfsd's for-rc (-> 6.1-rc). Thank you both!


> ---
> fs/nfsd/nfs4state.c | 1 +
> 1 file changed, 1 insertion(+)
>=20
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 554c4e50caf8..2ec981fd2985 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -5407,6 +5407,7 @@ nfsd4_verify_deleg_dentry(struct nfsd4_open *open, =
struct nfs4_file *fp,
> 	if (err)
> 		return -EAGAIN;
>=20
> +	exp_put(exp);
> 	dput(child);
> 	if (child !=3D file_dentry(fp->fi_deleg_file->nf_file))
> 		return -EAGAIN;
> --=20
> 2.38.1
>=20

--
Chuck Lever