Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dave Wysochanski <dwysocha@redhat.com>
CC:     Anna Schumaker <anna.schumaker@netapp.com>,
        Benjamin Coddington <bcodding@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] Documentation: Fix sysfs path for the NFSv4 client
 identifier
Thread-Topic: [PATCH] Documentation: Fix sysfs path for the NFSv4 client
 identifier
Thread-Index: AQHY9D/UHAS9TN3bW0a4ulUjeWuAMa42mHuA
Date:   Wed, 9 Nov 2022 13:38:04 +0000
Message-ID: <CC98B38C-2E79-40CE-BD9B-6E336BBD6552@oracle.com>
References: <20221109133306.167037-1-dwysocha@redhat.com>
In-Reply-To: <20221109133306.167037-1-dwysocha@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gO5cmtJvgINazb8bQBiWChGHEljgBYSxHb3RSXjVefsVMmVXJ2RMG+CyHfza?=
 =?us-ascii?Q?U6W3YLzjSL3m+Ma6aihF+Rf9CGNiwnCgLMBOcmnwZOwRVa9ESU6VVDqJkiW9?=
 =?us-ascii?Q?wpCTOMS7ONuisB2frMpt46sn96R1RGRQ+B004WB79cdoA4oo1KVq6oC+AiWQ?=
 =?us-ascii?Q?XFOb5t8+PdA/KM/OoYh9oNKRNwQ1Zynsrm5sy3U7CJGtC+mWM0048J+PGMjC?=
 =?us-ascii?Q?RQgyStTN7Uvw8D4RQnwh8FWOTIKFd8kVUl7eAhpNY06IwlevtnAasf4dqD/K?=
 =?us-ascii?Q?ER9hl4VI36a+uTed/qu3/UKNnolFucwR8x/bzfbnlWWcW5NJQa/imicEUfZV?=
 =?us-ascii?Q?WwiP1qsdRDtMBYZk7CUsJPLDsqldAibwITbqfZlNFT1tPQfKwp3ogRGdYZ6k?=
 =?us-ascii?Q?qt6ZL2TYmvhhOOZUngjLIrlb8hSOqShwYamePsxWlDz4wSXQpdqGlBu/G4n+?=
 =?us-ascii?Q?Se/BQckLsiTlHYRMuBe8D7YEv4z/dm13vqAuZOo+oxNVTVweKsCtVPbnoqKl?=
 =?us-ascii?Q?Vc4woZWT0LstFxnxxViFIKVEzS5wsZGiPiMd8gXvmDxzzf5nhDLlfnoEhQye?=
 =?us-ascii?Q?J++PmhLJYk5DGZ0k3RTfOInlYo2ru9g94jCPM/JXnDJGMOsNUKz8Gv7y6p07?=
 =?us-ascii?Q?oS9ra7y7hmldLffQsktnLq4K0+kvwSFFltF2fXtAjvs+hdD95kwl/Du6zhNv?=
 =?us-ascii?Q?kOkdWusl+H+YRXtyzCXsI45NH9cP5J/OUE+U2vCEaAJHLqM4+Y2oV2+HLOta?=
 =?us-ascii?Q?q8PZAQtsqkhA5FHjDQw0mx++smDpTbQZpnbX55NL+Kd3ixFx2+aMVTGuu0Oj?=
 =?us-ascii?Q?4T74MlqcCbWtFZaGpenCKTKdQhrFK4fm5xNrvs3/rkqN6jENcDs5Cgw/lTCA?=
 =?us-ascii?Q?WSjazolmg8n4Z/58Zpy5bvZH/9SAZc8vOfiPH/SFpr2G/sX/bzSOhcsuJpmy?=
 =?us-ascii?Q?RWuSwBWKDHmEg7kI1rmicRn+ISg1MgG4y2arzjf5Qgc5USXgtOJwy4kRZ5Be?=
 =?us-ascii?Q?l90Qmk/dLGs7dAuF/eUckiQTr+t08S6Lq4EQc0m9FaFVuIu9aMpZgbHa9dbd?=
 =?us-ascii?Q?iGiq8zmo6OpOsiYGPyB+/mjWAmKjtRN3eTEmUw0o2xy//KvZuOH9L/lZTeGI?=
 =?us-ascii?Q?+GmI3wjPb83Z3WAjHBKF7FnGMTd10sj9hWNxAiqYaShh1QXqBN0TVOB4oDy5?=
 =?us-ascii?Q?sDIkAtQKtm/y8jb6Tga3FV6BJ6NwkO4+K3eywaR59000f2iM/5ds4DMLNnZJ?=
 =?us-ascii?Q?0um7nLHz1exlBXPpkfFJ87bVfuVo4phxgLRFVzFWc+ohdcAbVr+ziSyLrj3I?=
 =?us-ascii?Q?bAyv+MNYnehkMQql/2FUFZ49sC661+XlqcoMiYtJSjVgZOR7BcQosxeOfLNR?=
 =?us-ascii?Q?fAVXMG9VPIjo9Qy08lhjo9lE856+J9FX9DwjdvoQezH62rOlgFYp6/ZDm6YM?=
 =?us-ascii?Q?e4dVE8bDde3V8NcfwWyTh2ZkOLtIsBOQLOWUFIs/n9ICaKEpemz0MZayACVz?=
 =?us-ascii?Q?+AdJBlBAZpEZhf4ewnCD881uukXFNclRMv7xUxa615pVoTPUtgO2N6FJBy+C?=
 =?us-ascii?Q?+1f6uVDdHFDyAAxMhBDPT6LdrlIMUi3/STojY9C8DdUXtTmFqLy7+qpZ3EEg?=
 =?us-ascii?Q?EQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4FAD31376C40884F8DE9EF61B0C07193@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3d68911c-ae42-4a6c-2e72-08dac257a0c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2022 13:38:04.0745
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: dKY/H4nZZO5jJQbw3uitikaRMqGac/tkz+BsfCjKfX1gR3fYwHzYVQZ/1oE5M5yc2hBDzEgu4PX+8bfwSgZZEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6204
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 spamscore=0
 bulkscore=0 suspectscore=0 adultscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211090104
X-Proofpoint-GUID: AyywZ9NjV-FbFQwL36gZfiiX7b_MHBUP
X-Proofpoint-ORIG-GUID: AyywZ9NjV-FbFQwL36gZfiiX7b_MHBUP
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 9, 2022, at 8:33 AM, Dave Wysochanski <dwysocha@redhat.com> wrote:
>=20
> The sysfs path for the NFS4 client identfier should start with
> the path component of 'nfs' for the kset, and then the 'net'
> path component for the netns object, followed by the
> 'nfs_client' path component for the NFS client kobject,
> and ending with 'identifier' for the netns_client_id
> kobj_attribute.

Seems like the redundancy has some purpose and is baked-in to
the path. I'd rather leave the sleeping dog as it is, enjoying
the morning sun.

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>


> Fixes: a28faaddb2be ("Documentation: Add an explanation of NFSv4 client i=
dentifiers")
> Signed-off-by: Dave Wysochanski <dwysocha@redhat.com>
> ---
> Documentation/filesystems/nfs/client-identifier.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/Documentation/filesystems/nfs/client-identifier.rst b/Docume=
ntation/filesystems/nfs/client-identifier.rst
> index 5147e15815a1..a94c7a9748d7 100644
> --- a/Documentation/filesystems/nfs/client-identifier.rst
> +++ b/Documentation/filesystems/nfs/client-identifier.rst
> @@ -152,7 +152,7 @@ string:
>       via the kernel command line, or when the "nfs" module is
>       loaded.
>=20
> -    /sys/fs/nfs/client/net/identifier
> +    /sys/fs/nfs/net/nfs_client/identifier
>       This virtual file, available since Linux 5.3, is local to the
>       network namespace in which it is accessed and so can provide
>       distinction between network namespaces (containers) when the
> @@ -164,7 +164,7 @@ then that uniquifier can be used. For example, a uniq=
uifier might
> be formed at boot using the container's internal identifier:
>=20
>     sha256sum /etc/machine-id | awk '{print $1}' \\
> -        > /sys/fs/nfs/client/net/identifier
> +        > /sys/fs/nfs/net/nfs_client/identifier
>=20
> Security considerations
> -----------------------
> --=20
> 2.31.1
>=20

--
Chuck Lever