Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3372681rwb; Sat, 12 Nov 2022 04:42:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7xiQd4Xhdx0G/QNMpACCLw7JZd/JKkpRuIm53jlWom8j1CId9YXDxvRRVCf4ewoVDX6c7c X-Received: by 2002:a63:1549:0:b0:46f:d2d4:bae2 with SMTP id 9-20020a631549000000b0046fd2d4bae2mr5065874pgv.506.1668256939152; Sat, 12 Nov 2022 04:42:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668256939; cv=none; d=google.com; s=arc-20160816; b=KVeSoRq52W1TbrefUvY1O1jBnk3tj/qbuVVrZeE5dr2Id4AKJNrUbSncX+/5ZBhtUa x4NwJzPLxhcFPaVVzanAYMm3RCOAY7llEUGZWbad/nAFBuhV5JYVa7ShZe8z/RILek14 D8JBpwIRQaRnpSWQ4u07pEbtokkwoLPEc7QDs7yVv+OR8bte/y0dEvvsqgfjc6jewXmK c6G/tia2txwaoSz5mBbm8DfGl4sD6OSYc5kSLQs4UBySECNRJEgVe1/WN+KOvxBjx7BB HbCCUkP4DDlvAXjRL6cIVUQS//qK06ygYpf2GpvN/myJxdJDPQXD02ZIorRVp4STdz81 x3PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=69SXSVqTL8jyyMGCM3W5UY/LeCYwAjyeNVNyt6HnN3I=; b=ffEoAcmQwIEMIAPfYfGn+GmglDSl6iGYfQrfc0lP+ikCWuZUK0vw1MfutSOgx+NSxS Px/lPafAjYpKkjSPcr3aGiEPHD3Iu/vuNT8yP1zM9vQJFkoSquI99otm11SdReNTjTkm oeUya7Gs96UTBP5efs46cUTm/q2MBDVsWG/o+VyaocTDQIiBEN0qFiXgu6Rb3/6eOVuR OmTw/qjkZl5jZaMguAGq+H0YZD70GVrjSyzK3i5i80Nv6v00DOthWbFjpHSrWyLZZSMA DAFTNRE9xNOSD7pFPSOpEfoYcdV5H/sbrp19fpNO+zLff74hU6OgAzxylxgA5ff0VqLr SRXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o14-20020a63e34e000000b0046edb8cdbf7si4847389pgj.795.2022.11.12.04.41.42; Sat, 12 Nov 2022 04:42:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231404AbiKLM1t (ORCPT + 99 others); Sat, 12 Nov 2022 07:27:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbiKLM1s (ORCPT ); Sat, 12 Nov 2022 07:27:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DB531929C; Sat, 12 Nov 2022 04:27:47 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 39554B80315; Sat, 12 Nov 2022 12:27:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6357EC433D6; Sat, 12 Nov 2022 12:27:44 +0000 (UTC) Date: Sat, 12 Nov 2022 07:27:42 -0500 From: Steven Rostedt To: Chuck Lever , Trond Myklebust Cc: LKML , linux-nfs@vger.kernel.org Subject: Files in include/trace/events Message-ID: <20221112072742.065df70a@rorschach.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hi Chuck, I was just looking over some files in include/trace/events/ and noticed that there's sunrpc_base.h, fs.h and nfs.h that are not event files. The include/trace/events/ directory should only hold files that are to create events, not headers that hold helper functions. Can you please move them out of include/trace/events/ as that directory is "special" in the creation of events. Perhaps we could create a new directory include/linux/trace/ or include/trace/linux/ specific for these types of files? Thanks! -- Steve