Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 12 Nov 2022 07:33:05 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Chuck Lever <chuck.lever@oracle.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-nfs@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: Files in include/trace/events
Message-ID: <20221112073305.0346b827@rorschach.local.home>
In-Reply-To: <20221112072742.065df70a@rorschach.local.home>
References: <20221112072742.065df70a@rorschach.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sat, 12 Nov 2022 07:27:42 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> Hi Chuck,
> 
> I was just looking over some files in include/trace/events/ and noticed
> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
> 
> The include/trace/events/ directory should only hold files that are to
> create events, not headers that hold helper functions.
> 
> Can you please move them out of include/trace/events/ as that directory
> is "special" in the creation of events.
> 
> Perhaps we could create a new directory include/linux/trace/ or
> include/trace/linux/ specific for these types of files?
> 

Hi Vlastimil,

I also noticed that mmflags.h is in that directory too.

I'd like to keep only headers defining TRACE_EVENT() in that directory,
as files there have special meaning.

Thanks,

-- Steve