Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Files in include/trace/events
Thread-Topic: Files in include/trace/events
Thread-Index: AQHY9pIxS7zdpDkDakqjuyvnBhQ08K47ceuA
Date:   Sat, 12 Nov 2022 15:57:57 +0000
Message-ID: <23D84506-BC58-4269-BD71-A88DDBCC92BA@oracle.com>
References: <20221112072742.065df70a@rorschach.local.home>
In-Reply-To: <20221112072742.065df70a@rorschach.local.home>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?7P2CPPXTM9XlUN1JGXKM+ufGcfpJTLWvFux1q9x7gDqBTwZxlr4ol3U1sfMo?=
 =?us-ascii?Q?iwhP/Os45r770IKvMVx1Pc2vyJr8M25ccjNQYSzVksBufx3Aj39VdegiiBQl?=
 =?us-ascii?Q?7Fgr//kKJPaTdiN+GicWNcKJmfYWIbmf+mSmES9NDrd77cVQqTS/YUbjprkZ?=
 =?us-ascii?Q?F9bXS0h782+28uF73MBoimLNKBGA9BSj2M7q4B4cRJ4XrWPT8rW1PkPj5yEC?=
 =?us-ascii?Q?0WV3q9ML4oNMmusSJC8u0AXaEiS9dKM6DWW9Hv3Yb7+oTZVKf/IphLqWQne7?=
 =?us-ascii?Q?fU0Yn4uFnmsQAJeNXXm74nAgaiY4zxPE59/lgyeCBXm3w+Coodwb9UU4Cc6/?=
 =?us-ascii?Q?FAv/tkgMSQLZBr40+F4KVNt6zJ47CY6hk9Z95VBkCbqWcGgrbNRt//iEC1Or?=
 =?us-ascii?Q?cj9RwfJqWvDr4PRb3PGjlAV1qla4/HhCmK7mglYJ7+bHov2XbWutZut6+UTN?=
 =?us-ascii?Q?/XPrUj4S/q9v4kxGehHgslJQ+to30Z/d8akdZg3afa82trDcURpv/h4kSiPr?=
 =?us-ascii?Q?EJ10kLZinXVh2q6Izfc/yqQZrgaynZIa0M7Zm4dLWfw4iV4CvQjXJ5QN/2+h?=
 =?us-ascii?Q?CusHFShui2Y7EN2yStE4zMLKd8xXwt0TNaSC9YP1mJs3Ohuy2FyPH4lrU/x5?=
 =?us-ascii?Q?zsxFC8kZHYVVRwke4M89t3VTlY8m8fCRQlz6Bs+E3/AgMPrkSrHACKX5yf8z?=
 =?us-ascii?Q?LMOkuK/ToAQgWcVQWZToBtSmjF1hnXTgap+I9+iAyKw3sa3oiYWGprgrGHkx?=
 =?us-ascii?Q?XNrCPKoBYQF5ZOPHF42hhr5gfT4xtX71EokjMJwUd6yC7rZfneJsSpcCz2am?=
 =?us-ascii?Q?sN8QZnKQEN3TyLuRmNGefGzMfEgXSZTwkaUr615V6fVhYKHqLbWVoCjVYTFv?=
 =?us-ascii?Q?5G9k8rw/6wyB9niGSh/psbsD4TUnkfrSd3juBMku2v01ywqQmAqAMpp0fe+b?=
 =?us-ascii?Q?SVz+ecQt5/GCGHqCN4C41ibQnUpN5NxpqOhgVrbxR8Zl344D6mkAeHH5O4AL?=
 =?us-ascii?Q?7Seq6IJUj+CmBQrKPP4unOsmeE189OJjVwrYbXy56R2Rstri7DS0ajj8MuvC?=
 =?us-ascii?Q?ydd/LgsaXgo8+lN2OvKD8Ok416UePlnrZ/fAm1HPU5b0vQKwR5QNGcisKy+l?=
 =?us-ascii?Q?vAgHBwNWMCQW5itFY1r2SIbzI/CAPGnG3YG+d6CVBMP/K0XBU+9wMaplEN0l?=
 =?us-ascii?Q?l71ro4bf8qUEQNKk0YfpC9Ir2n0M3WJvnnzgtxa9/Oinh+dPmGodAmAbrRzM?=
 =?us-ascii?Q?mP0jLypgMe2Hwde4JMS/qYwCXOmyEdgARimS4qH517Vgpw83bqX7riRlKemx?=
 =?us-ascii?Q?wjRKShK59i7f3bGEenzUqXbVoQseuEImG7UR1mtiyOH1z2Muw9kknXCXW+0d?=
 =?us-ascii?Q?oVI7e18ZaW/MrVwt+YxGRl9/moFfU1BhZygz4D+iAwQhiG/fEGVq+vV4QXyE?=
 =?us-ascii?Q?cCWwwGhkFiCnslMoZHNyYBlZauX5cMESmRfFaRwL2QK+eqCqiuaP/QKAaHdn?=
 =?us-ascii?Q?HpG0z5dF1yfCiNXsDWt3XOkoLKc2YyDtlYgSdQt5zg+WyTQgHT6rYhHWByyE?=
 =?us-ascii?Q?AJgVfoM6kTw7QFKCSqIcStLrkpHoiE8rKU5DW4ew8QP7bZLlVcCOK+tWRLCB?=
 =?us-ascii?Q?RQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <42A8DF03D99ADA43AB084A4076C53E1C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: df4KsYIYFfRwpy2Y+KuqKqTtKGzMZotPtmhCh32rHEb4iWvTTZM7icp0svQi92OwSZ6uYH9WDqBttE/8sB+BKDEoQtYNDklvJOfZpyvMJ8u74nv5tSkc1RAjXSKcC02dVjtDJDIIwGaPbyaPWux8e5QthyttDC7rk2tvm6+SS4qX0R1HZJw+wezPSlZbZX61OIcK6KCdI0ENAsyg4Jlhiax/JrHtEgN1ns2bYwPSWpjOP7WrOwaZ6iOfbYHGvaf55tsZPSNQ+GyWILiEoJ6rM3ypRbctJ6yl2Vy47l/paBrkXHztQDM4Adyq8RY5XNsuTYGyBCqldkzN+13WU5qXIXV9nd8YCh34lTwEfLospYCqOekb5U9jz0eE5JKoDnG+iyiXTssUtuqFEOs7FOcBYdwjhxrM9q9BvdYQQc4MbjaP4JQu67P2uVuLBS2AyhRTrm4ffVk5Z/XnzFtOo7wmCGK46rnIucrGKXTMXyvj6Dly3Mk9ivJf4mn27Piqy3wEqBlqj3qERlfGVepr3uExqgaJfj9PKZfjOdw6NDCVP2WTsomLp84nbOXiqM6uAy4T44XSOXn1CToLlRePcIj9107pRuKOe1z2z3LxkRa3v6v94Mrh4M8XUcDRBFdXFrVeChgRQXnqDgd8JhAFbcJ2mDkv/VT9QdlyvEPFQR/SIC4ywxwU55CXcFvOrh4tCV/Svo59gSu1Bb9G0SsqJpe6l/LLa/L4qvq35D+RDeaMzoba8RcXAd4+TA4Z1WfLOy+xDfyAm1dCjbQ5MJUNPO2IzYj3bYzZneJBdTY27TyG7ewq8z71maHSB+M0c84JDn+TK3+WWzU/Pc0xN8y89dW/JNXuHYaoYQx57+IA/2E1vCp4J1K8UfxzZVAGLgGFUSqN
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc09041d-5cb1-4c5d-6809-08dac4c6ab07
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Nov 2022 15:57:57.8148
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jzcGF3GlBAKXw665cdLOninZh1m1pwurWzGwRNZVck3fL/6hEDvrUVjhHBhWsYb7GFiUiOsI9JXpe86DXHovrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5807
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-12_11,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 adultscore=0
 spamscore=0 mlxlogscore=976 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211120122
X-Proofpoint-GUID: cf6-YenKW6UUPuJ1DfSMuSOT96iYdr07
X-Proofpoint-ORIG-GUID: cf6-YenKW6UUPuJ1DfSMuSOT96iYdr07
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 12, 2022, at 7:27 AM, Steven Rostedt <rostedt@goodmis.org> wrote:
>=20
> Hi Chuck,
>=20
> I was just looking over some files in include/trace/events/ and noticed
> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
>=20
> The include/trace/events/ directory should only hold files that are to
> create events, not headers that hold helper functions.
>=20
> Can you please move them out of include/trace/events/ as that directory
> is "special" in the creation of events.
>=20
> Perhaps we could create a new directory include/linux/trace/ or
> include/trace/linux/ specific for these types of files?

I can take responsibility for moving the helper files I created.
IIRC there are a few from the RDMA core subsystem as well.

But let's first decide on a proper destination for such files.
A sister directory to include/trace/events, like

  include/trace/ < something >

makes sense to me.


--
Chuck Lever