Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] filelock: remove redundant filp arguments from API
Thread-Topic: [PATCH 0/3] filelock: remove redundant filp arguments from API
Thread-Index: AQHY+Do5vmCcmi57O0qMMT1RNEW8Uq4+hVMA
Date:   Mon, 14 Nov 2022 15:08:03 +0000
Message-ID: <3C490193-AFF8-479E-ACEF-ADD02E3E15D5@oracle.com>
References: <20221114150240.198648-1-jlayton@kernel.org>
In-Reply-To: <20221114150240.198648-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eYYrbUQ8ODIxCCJZ6d9HZk1kc7DSvZiAYfL6+LiZAbffeJFpm+/On+hJMN0q?=
 =?us-ascii?Q?XpQxfi8fDiJ2oaKLOKGR9aT4NCuyPp5WKYYIptK2E2/0WjhkE0q4zPDJJfV+?=
 =?us-ascii?Q?FQKN6UFXA1MybflaDUDYIwKmNAWxBFTtNW5kK4jenjS/iWY23ECG1zzD1RAC?=
 =?us-ascii?Q?v+rErGsIHZfB4psak1PN9M0nK/4X316SwZIJHG2PX5SVI5lJX+buz0EWCOcf?=
 =?us-ascii?Q?dl3AipPZKigeuQyDQFu/Y0ArNtEe+0SeCf+9GhvX7hfzv88px4iH982DWp6M?=
 =?us-ascii?Q?5blKrGkkh1rrpwGlzlhetbeCesj0TDyxS3GpQ70HZT2RA2Z3FoOwvO1tU6ha?=
 =?us-ascii?Q?dg1mzAPGS/3R5TEGApqVK1wCGiDVY2uEVkmHlSYsMu8SyPQt3mEnjGwfBm5s?=
 =?us-ascii?Q?uUP2GEymzmRwExNqg/o9otAz47BbAT47cv1hHAH+/kX8q1U9S3udurSboeDe?=
 =?us-ascii?Q?oRh9AfnwJlPXlGTrRRDakAjn9g9ihKDlWcoR97vobh0uIVSGzaJQo4PB32/z?=
 =?us-ascii?Q?EYm+8AafH8QNuHPXd3vMABcl1yjJkqnS9F/8ssdXN8NQoTX6T82Y/+zsAyEN?=
 =?us-ascii?Q?woEXosEXO1ojnoK+IBDBipq/db6mR8TkQR5fNhxRe59MK8ozZo3Ox390utor?=
 =?us-ascii?Q?0rBVmvhmqMKT7FgkRqlOrsSCN/8llKhACdkvichTtAX7+N1Xl4H1IdAI9syy?=
 =?us-ascii?Q?BaRw5nW41qaAbtp+Ll+sQ5lf88W4n5uPaPgjYITl+xOhaltQirMB0HfPtYQN?=
 =?us-ascii?Q?UnxlOMLk+LPJrk6o1x5eSb6D6qMf49BJ6z2jcu0lpgo1pc0AftAQ24eitpJn?=
 =?us-ascii?Q?MukPXHXhUuK92R5ZYt/fgiRDndFTJEySAe/V2r4qacTw6p+Mc0CwDlBo1lZL?=
 =?us-ascii?Q?8QiinV7nDP89k0pTdkZoeCoIdBZ8w/ngHpJ//qRmWvsLJAKKqf+LSDAODASF?=
 =?us-ascii?Q?tg6GpoKM1ly0fG0Jb/FaHPXIJS92r3NJxqnsPQQEPE0EnGIbTJ3XjSAUhRXM?=
 =?us-ascii?Q?lq2WzxvIBF5vCA52vOZSpk8Yd86HGcoFHLl1daGUofWqx8Kzhmq7w8xmt38M?=
 =?us-ascii?Q?91LKgCuhX1rrfhVIXNCbDwY3wclYRUAC0/Piz1kBuEGPfZNObWaV7wC23RWc?=
 =?us-ascii?Q?jwC35xlhS05vIXkxyrE0zj/k+0qv/F4Uu9sdDgPq30dS6QWZ2tHxrtE/cYVS?=
 =?us-ascii?Q?IZp9xPPp8d2Ljpht3yMBEJ82flfijtucSa3oweGoBlW8MmLTjRSzFFQCpX26?=
 =?us-ascii?Q?u992ywhLQIolSOUS629UYghxn9MkS+at4XGdq3ZN2YIn3AhgUF2GWFdGj7Zf?=
 =?us-ascii?Q?4IFl1B9QRp9DOU6M/DopSNM/VvTZINZv9O7hw9QclX4vfUi8vuGsdNbisyl2?=
 =?us-ascii?Q?v90Znh3HJ1BLZuyFN8HBiwm8iotBZX0AM7G7MRC+qXzHxGzyQaZLfOdnRZw1?=
 =?us-ascii?Q?W0BjhPXodRuR5GD4xlgMXcNbCQaQ5bDyVHKhxiVH7UuKt8W3pg+FOK4+Ver1?=
 =?us-ascii?Q?zBZxvQwYiufOuKXKAm0EbLH0X7CW9rclScK3ZOVLLoiH2SF0yBVcZiq46bAC?=
 =?us-ascii?Q?Om2J5a93ax52krVNgG9tPAbtu67CPDM1bwthFwPC3lHzDHe2lnBYAbTF975R?=
 =?us-ascii?Q?Pw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <49AD734A75E4CC4498DB364FC8B3A4A6@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Jx/52xO53UB6RKmkxaNahDfV24fQDhQHWQN+QvXUogGb53V2hFDbmgXJqsbz0MUOX7OObqrqDVI93PI1RRA+fM4vUFXNCI1HglfhJnANPbzv62nC0qaKqust098X7grqc4r/ExENu656nZftJ2650FJ541f2/KjMlndU8BGYPCV2RS52FKaAka+IaUsfImDvUPXAbpRkGjBIH3x5kxBtliCnBHQbaQ9b1fF1fspnWaPVP/NlrbLalHL0UZ+CpXMWxUwT4nlHLLwL8v7lyMJUpShpxSoJeek3oepBcznTXyRbHQ8jNjGeyi35/P/RX/0jjSmSgAq7NGdRW4IjWweezbdDlbA+W10IrchW5+nB7/SGutC8Qg+JViDEHA3EvYAn31VE1Tv+3GVhtSqrZtXsT5SUXj6bcadUYHJwh/1ZE9tVzuBtxVB7bONTbcHawqs9C0Kf1CLsXXuxReKSExfASyDwQzNg/8nJGfbw/QP+OrYESVBEntQVYjxnKPvdsOCLDr2pk4nRGQfHkl2p/eNmwJ8bWMxmq1M+Fv5McZVr5D+mc75pIEqfCZ/uaNk6IbXGfBRuSW0cQcHE/V+alicqSnYAAFNPTIJe4eThm0Ur2wj/pSSwEO3t7rfqyq2b499D9w55L2QAOqNk9cCLaLNeW2G07VdKvL89dvhkAr1TINhMg49FHNiTAcD78Yj8jRDsF3c5kjFr3wQtkGdvtmcIhMs/8KobLuEVYzfcfXVFIA98MrR4fatKTtd4NhFpaBjesSdvTjSvxX442yLRhIH7ObbNS44AcXgu4CdN2zxljnYPn+ozphY8H3ePAxrWxm1cplzGOB6lTXM0u8145oqIR3mH2zvTROKwn9FKchr/EGjkljqR4pF5/BikdW/Ief0h
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6546ded0-3139-4ece-6fe1-08dac65206f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 15:08:03.1760
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: znxLHjlIJ6/7ggZKyvazeKKt5zXsx5dxsXOtQv0VqkpPCN6DGj7b67H9UJYDKI2FHnSfX+jaL5GIKw2Q2yxiiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6819
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-14_12,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 phishscore=0
 spamscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211140108
X-Proofpoint-ORIG-GUID: Umt5e3LpSmmclj1t1vz6yslrdtMRQlAR
X-Proofpoint-GUID: Umt5e3LpSmmclj1t1vz6yslrdtMRQlAR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 14, 2022, at 10:02 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> Some of the exported functions in fs/locks.c take both a struct file
> argument and a struct file_lock. struct file_lock has a dedicated field
> to record which file it was set on (fl_file). This is redundant, and
> there have been some cases where the two didn't match [1], leading to
> bugs.

Hi Jeff, doesn't the same argument apply to f_ops->lock ? Do you
have a plan for updating that API as well?


> This patchset is intended to remove this ambiguity by eliminating the
> separate struct file argument from vfs_lock_file, vfs_test_lock and
> vfs_cancel_lock.
>=20
> Most callers are easy to vet to ensure that they set this correctly, but
> lockd had a few places where it wasn't doing the right thing. This
> series depends on the lockd patches I sent late last week [2].
>=20
> I'm targeting this series for v6.3. I'll plan to get it into linux-next
> soon unless there are objections.
>=20
> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=3D216582
> [2]: https://lore.kernel.org/linux-nfs/20221111215538.356543-1-jlayton@ke=
rnel.org/T/#t
>=20
> Jeff Layton (3):
>  filelock: remove redundant filp argument from vfs_lock_file
>  filelock: remove redundant filp argument from vfs_test_lock
>  filelock: remove redundant filp arg from vfs_cancel_lock
>=20
> fs/ksmbd/smb2pdu.c  |  4 ++--
> fs/lockd/svclock.c  | 21 +++++++--------------
> fs/lockd/svcsubs.c  |  4 ++--
> fs/locks.c          | 29 ++++++++++++++---------------
> fs/nfsd/nfs4state.c |  6 +++---
> include/linux/fs.h  | 14 +++++++-------
> 6 files changed, 35 insertions(+), 43 deletions(-)
>=20
> --=20
> 2.38.1
>=20

--
Chuck Lever