Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 3/4] lockd: fix file selection in nlmsvc_cancel_blocked
Thread-Topic: [PATCH 3/4] lockd: fix file selection in nlmsvc_cancel_blocked
Thread-Index: AQHY9gTwwKmHpOWzOECaqHw1tBDcK646LKuAgAAXKwCABICXgIAAA/yA
Date:   Mon, 14 Nov 2022 18:52:22 +0000
Message-ID: <9BD6A469-DE43-4D10-838E-807CA83C8761@oracle.com>
References: <20221111193639.346992-1-jlayton@kernel.org>
 <20221111193639.346992-4-jlayton@kernel.org>
 <1AE4E7CF-F76B-42E8-90D7-5DA52AFDE66E@oracle.com>
 <55593a438387aca9187a8a8ea1e0d3c2cc4efb9b.camel@kernel.org>
 <1e2722cee7cc03f0da0623a7d45b9531973c0906.camel@kernel.org>
In-Reply-To: <1e2722cee7cc03f0da0623a7d45b9531973c0906.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ipg+VbDIhMZkkjvkkDod2laVH9PCTTND3a7jLGABTfaTIGOKOUUMaErJ4mnb?=
 =?us-ascii?Q?CJA8NrtIQ7oZEfslZrZa/jKyo7rHLsZfaT2ZCOgRHeYumks2m1tZPoUTDoT3?=
 =?us-ascii?Q?xuEKE1zrp3WQWxyyG8rs7bXQnC8jnU5M0ef2m6Sbawyk4FdvFzUQfLc7EZYG?=
 =?us-ascii?Q?dJQmze3PDVjT4qk+yjwJbxpKEsVKMjc4dWkm1CvqGavg2I12RMUvZIh4H9Oc?=
 =?us-ascii?Q?b5Ek9ltBG5dvIwnB1Wc7NDDX5G7Kl6JzaGnTAMnpAa1UO/bI1pjgEBF5xg1T?=
 =?us-ascii?Q?68F7VNzVlNTok95sYsIJC+RCUKrM1cZszAron0DE3d5pKoyvOr2bRkgEsP81?=
 =?us-ascii?Q?n1mcqeDvQkdmhGgyvtS3fM37suxX/tpoZ75tLtfLt3hqBp2UaZVBMVjFhB9X?=
 =?us-ascii?Q?RIbsQbhm5tfTkdBw5a0csN8E4kzVMLnkCroSFbf33ZQenHV/R7NiUUTeuzQW?=
 =?us-ascii?Q?MLTEf5Tip/nkyyWqS+GgQLhHDkteq66kJ48rKgch/5eykRGL4LzrxOxWBRs2?=
 =?us-ascii?Q?hWCTws3b1HEzegfaQWEPS9OymwAXcHcmHA52zbGKLYysH4onHqvzNFZLc0dN?=
 =?us-ascii?Q?1SGKYZTeROPe/2bu0Lva/vvNzTp6RS2SqqZKZ80g6wPn8hSDrRRLe9Li4Jjg?=
 =?us-ascii?Q?OKIAE3urUcVAAHHx0thsaJarQ7hs1kj2Ky/2mNiy0V5KRTVg0fINHD7j5fGd?=
 =?us-ascii?Q?7ujwaLhKa7HruEaekiEkDVVwXljNEuh9H7JU5GOmszgfdjemS2L7zz4k8TKk?=
 =?us-ascii?Q?EzCG/YLyBWmqAOPcLqvrZ2UN22y2odMgcB7NsuWmnKs7DI6ks7eNekDYRFvO?=
 =?us-ascii?Q?7bXZaJ1NYpy3C4RAsoQM4hTeXeYs7+vn7oxKz+FYqiLSr/hzdvzPR/ZWxywG?=
 =?us-ascii?Q?7hkcB5prvCSdwRyf7xxkxZ3qVP4lrBLN52wVO7JwvcywR8tRfAlBLuGIGEZh?=
 =?us-ascii?Q?WSaDPSYnRQtm3PNTyYWYawnE6TypWqi9B3o8Rc9af8AAje2wRjx7USyK7H0r?=
 =?us-ascii?Q?+cdkcwm/CBxZZ6YvpJimQ2qvQnM/YcV22oe4R64O6IV+g982pLJYJIrDqtzO?=
 =?us-ascii?Q?6BDBE3T6HwVgW7vuJShprjVXeAlbpM8XslfCz+/FE3D1Z/ToSENKquErOCeo?=
 =?us-ascii?Q?Duj0U4K43o2UNoStl9xjIakmbaLzZDUJJNwp9FanzoXuJesNsm89GCw6INsW?=
 =?us-ascii?Q?0JZtfgD48mXTb1/deYnAC0wg9EtG2sJ3yPXGQzloJZQ1dj0FQslv0rdyJIli?=
 =?us-ascii?Q?Nr8lguUQ+BL3P+/HwN8Li6DaGA3TfEOzVLJ8YvZ1dMe2431VkUS2cm6y5x8j?=
 =?us-ascii?Q?5dV2AQYVLOAs0ijo0RavUWaVMjXREnCbS5zPvmanA5KIApM6PgCQ/iCxCxzZ?=
 =?us-ascii?Q?6esiWyKyagEbsZfnyqkumYcKikWMZUbOh/nRJzze9mNq5WLamMKgxsxfuCFR?=
 =?us-ascii?Q?uUDlm9g3yCHQO1qclPnRhQTw9hHNE5hoJXkK9IRnffWRrSTq4KifvBZ1rjMu?=
 =?us-ascii?Q?yHBHBe+KENssyi00skOdroF2p3KEYmxy8EKwp+zKZDggMMn31VsF3s5Xkta+?=
 =?us-ascii?Q?m85bnSxvlJcQmmOjJudCSQjkT8x3Aw72e0fUPeUxNGXdmWoeIQJKVWwGITB6?=
 =?us-ascii?Q?/w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <EEDA60B4BB7C4D4FB331AEECF3A1FAA7@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: SpxE0qmou56PZ1odBNpkaUab22E0klLLegA41gMQGw8AAsbHjq8ReC6nLhEkt/eUeV6+n4anROiklmRfUxfFxSdVJZ+FxsY3p07x+Z8iUnzvZDSMLb2gZkRynrhamBpH5hRFIEcek1p5KBAiRbxz2eZIsgSn7gtB9rhUoR01XIBGKtK6XK7Wh8TqYQdajRI9rreWOEeNGoqLXioq46vW2udgpAV5brPA7EyV6YyQdHqmsmFuQq7YgbGxJV4dAsOQJtJK4X4N3MWfEEAXKDb5fkVUtRUVnx3JXNgKKrEbRaQGx6Rp4TEeIAhkyHTbBr4NZjVGqcTvvvadLvj3aj/91laHaulu3C6890lUzzq6yWFxzwC0N6rGpA1cMBM+m69MCmSqsFjEKxCNfV/OiIfLYXE6OP24J4AtmpZxB4HPzczNtAp9gHA3NRlPO1GQ/I58bpgGbBj8UKgSyHqCBigbi0d2ZxFavxsKkz7i7rkiOHRVQFa2sfSXjlxHeSF2CWyYPqHOyQIKoQP12IwhLea3lxddziCbqWNEeNmu9Z+xyHou3QzG2B37sQX8ZqhESNocPPgfxK7c2Vo9cBjSHpl5+yMs/QxVXzxIIpbNXYwOIolh4AgXpBzknQNDY5Iu9dMNH9aI2NJH2Z72Ly273E4F0qbt96dsODEerQAiKiLLSkwkzrc/bVm7uXXgB3cj5uustviHeJrI6AmKByZJ5AYX9rLAqocSgHdc5G5zB1yUgCm8ORey+1NGurj6nuIMlssNhf5DhL7+S3cRglHAuoUTGFpkEv7FYjwnmH5LXrLSh/CZaUxbqMBCIZ5S1CNzEZtfQwfVlqouxBgWP2SioeFhLA==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 92d522e1-f9d8-488f-74fd-08dac6715d4f
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Nov 2022 18:52:22.4814
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: /oBU59XbU2w9MrE78McxaEK5KceSqpzZ2MCFyOg5XxE0u9wGjdOgKPsx96SGNl9rK0mYXLu5Bdf5rTgpzuTqWg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6327
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-14_13,2022-11-11_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211140133
X-Proofpoint-GUID: Uk6xkchBFaMxZntqH2RJjBbu1wC-rErR
X-Proofpoint-ORIG-GUID: Uk6xkchBFaMxZntqH2RJjBbu1wC-rErR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 14, 2022, at 1:38 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Fri, 2022-11-11 at 16:52 -0500, Jeff Layton wrote:
>> On Fri, 2022-11-11 at 20:29 +0000, Chuck Lever III wrote:
>>>=20
>>>> On Nov 11, 2022, at 2:36 PM, Jeff Layton <jlayton@kernel.org> wrote:
>>>>=20
>>>> We currently do a lock_to_openmode call based on the arguments from th=
e
>>>> NLM_UNLOCK call, but that will always set the fl_type of the lock to
>>>> F_UNLCK, the the O_RDONLY descriptor is always chosen.
>>>=20
>>> Except for the above sentence, these all look sane to me.
>>> I can apply them to nfsd's for-next once they've seen some
>>> review on fsdevel, as you mentioned in the other thread.
>>>=20
>>>=20
>>=20
>> Thanks. That should say "and the O_RDONLY...". Fixed in my tree.
>>=20
>> I'll go ahead and resend with fsdevel included.
>>=20
>=20
> I reposted the series Friday afternoon.
>=20
> What might be best is for you to carry the first 3 patches in the nfsd
> tree, and I'll take the filelock: patch into the locks-next branch,
> along with the other filelock API cleanups.
>=20
> Sound OK?

1/4 through 3/4 have been applied and pushed. Thanks!

--
Chuck Lever