Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6630303rwb; Tue, 15 Nov 2022 01:07:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7BW5vp1Gf51IXs8qQXVx3xrGWxiSulBZqYxJU+VLZorEOrNepiOxneTYy+E+ooh5fQnsMc X-Received: by 2002:a63:565c:0:b0:46f:e658:a8ff with SMTP id g28-20020a63565c000000b0046fe658a8ffmr15101332pgm.493.1668503247011; Tue, 15 Nov 2022 01:07:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668503247; cv=none; d=google.com; s=arc-20160816; b=Gvs2jxdNA2PzevpqyOdXl9/q1ktCvzNgEiJjPyW+axdlxWbq4iPYHGlPiormtoQgzv Q/0LWMKl1/bPQoHDspsG6bYgucF0ikVI0MxIwONyu8n2l2+zH6Vt1FNqs52Ep1Klxknv NAE2y7zAMobUuw8LL+4SK77OK7OlXEEUFAWSOzz1hlSxnYkKMBx0u4AaPOYv1zWzB6xU E59Icbeerp1s3jiMbi/wEOCXlTBGLabZx7WKD8bAdUS0OSV3fjyr3uSdTE+DOf/aWc0h 7up7YsS09uuAG4lRZX9TOyQKEJKxR/KkV6k8Czd+PaRWuq/x7BQQ710dWmELO69IhhgN Z75g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2ktcTOBWv1rw46CZkOvqkKbXV/n7CpaECq0w5Jjq06Y=; b=YBOGBwTvyMyhaxhSrI6xS87d4mOgJMUaEC82rJ+NyqJXgd4pynvcgoZkWiM8nUk1NM E2AuYq8ct36kWCJVgLpnZNmIkA7fguDXSHqBziVP47eldZEwRKD/2b/gqkVvtKfb33ag Z9YztE2dcSfnGUVtb5UBaghIU74ziyCTOaLKFAwx2TKF2Wjdb8+Snx3mteILO53lw0s7 8pEVpKQ5iLzlQ++IpVzmy74MyEeiweAnGwXLqHXuXc00IUX26WQF92mD39WX820djVWG Ri8fVSr1mkbVGKMtLpfwu1v3LM8AylCx7d/mzcaJdvQTsYwhnSelMyh5TI5lcpCgI+S2 VRgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=z0pEM15M; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a056a00218d00b0055ffebbba91si12872007pfi.112.2022.11.15.01.07.14; Tue, 15 Nov 2022 01:07:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=z0pEM15M; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230120AbiKOI7o (ORCPT + 99 others); Tue, 15 Nov 2022 03:59:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229664AbiKOI7m (ORCPT ); Tue, 15 Nov 2022 03:59:42 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491F26412; Tue, 15 Nov 2022 00:59:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2ktcTOBWv1rw46CZkOvqkKbXV/n7CpaECq0w5Jjq06Y=; b=z0pEM15MibHyHlORd6VWGbqEFh 7+XcKa3MGZqEP9yRggfo2+a42gQU6e3642UczQwfgzQHolzWuGdiJzilswFomRPaOelXvqET7ClUH CV8/ko5ScWOek6gE2V8wicM/LzkDw9d8Coh+Z+6cixb5diIyTwgGxrBMT5P51SDyvksqwTP0vEc5T sUVmhhZ6Aem9Rd0zPobtgKCVxA05rFuZIgyjTEqgXXQtAfteWya64BcsE/tzA/rQxT3Zd4qlGp7Yk WWn18uP+5Ss/PqORtydroGrp0VvwBellibpxTiROsRLeAUHhRI0wXoxXzyxf97xIM+Y/mIPg9Azuk jSwkvwOw==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ourn9-0096L3-0x; Tue, 15 Nov 2022 08:59:39 +0000 Date: Tue, 15 Nov 2022 00:59:39 -0800 From: Christoph Hellwig To: Jeff Layton Cc: chuck.lever@oracle.com, linux-fsdevel@vger.kernel.org, trond.myklebust@hammerspace.com, linux-nfs@vger.kernel.org Subject: Re: [PATCH 2/3] filelock: remove redundant filp argument from vfs_test_lock Message-ID: References: <20221114150240.198648-1-jlayton@kernel.org> <20221114150240.198648-3-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221114150240.198648-3-jlayton@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Same nitpck about the extern as for the last one, otherwise: Reviewed-by: Christoph Hellwig