Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     Steven Rostedt <rostedt@goodmis.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] trace: Relocate event helper files
Thread-Topic: [PATCH v2] trace: Relocate event helper files
Thread-Index: AQHY+DwRDNK42nvg4ES6zBIsBj20T64/r3EAgABbx4A=
Date:   Tue, 15 Nov 2022 14:23:35 +0000
Message-ID: <DF49C9C8-5AD9-42A4-98D9-6DA61D9D3E1F@oracle.com>
References: <166843895843.170837.8663873976042560070.stgit@klimt.1015granger.net>
 <Y3NT6sCGhtf16FaO@unreal>
In-Reply-To: <Y3NT6sCGhtf16FaO@unreal>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jEW6FgkPj3l04/xBYVf79WXh9SlPzBb0UDwloyW+tjoQZsScYFcf3jKfHbdc?=
 =?us-ascii?Q?4BdBRMz9lIIj7bAmA6KctrPTp4VDBP6OvLUqeAoSs10XeUJuHepxATTq1IwG?=
 =?us-ascii?Q?RLQtQ8kpSwDZI3PGsIZ8M8bCQuN2LgTQbgrSlP5BPaWDskAzz3NUoVhqda7B?=
 =?us-ascii?Q?zLg0RohiGzunjvD/AnNJJeAunI7K6BgsMm7SDMINDCb7j75ZKPBIR71Y0vM4?=
 =?us-ascii?Q?P/tpEChKVjlO0mxcVqtDSA7Pcw6EV1U2NYKH+pCt/KLkpoM8f0g3ttugz8Xa?=
 =?us-ascii?Q?C27HOHAJ0ZfUJXYWKMS6ELg1OuxfbA2/6W0AvtDd/vkRDAXk80/s4M1aVhLx?=
 =?us-ascii?Q?io11zEzI+tBwWOrSJ8AXOozw8RpKGuIgVjMsosBMelW5I1H2tc9FbVpTIxWv?=
 =?us-ascii?Q?IxpUH+hvAtp4VDdPqYJKe03/0mlVai38gY197L8P+7oCHF0pFb+uH5vxDD7S?=
 =?us-ascii?Q?2mvYCdYrRSZzYLWlimAOrGt9u2TjC8lHkM8j83pf3b/MhqZjG/Ivnrh5vl3v?=
 =?us-ascii?Q?b3Sewmpiw6tTgDrK7Yg9gpdCHrGybqUGIeKZCT3zYP0Yhz+VX1EO/Zj1jS2b?=
 =?us-ascii?Q?xo9hX1N8KOhyJIGw/8W6BaeaOf0/Wfzm39d+zyoywhEYpBXOcNXzRNhrWte0?=
 =?us-ascii?Q?SArvXlnjfQdoPIdRX15Fzw17ADYz22wpDabe2DXLxjj7k3TR1G/i0/aNTNJQ?=
 =?us-ascii?Q?bInvTcpPYJ/yW7U2Vi+7is0G+2Gu7WR1Bn4pT5yABOYI3rVOK7eOiXR2PjN0?=
 =?us-ascii?Q?NXAiCTt4DPx2XcvH3fqCT9uYfuf8YfSEiLCtWxAZbp4P1fyZ/5ax1AeTexhr?=
 =?us-ascii?Q?IzS10Ox1Zs/j57oxgKyMBQ4A5vbYMsJ7ZZpDr2ukMI7ppki7KLYcQZBoL9W+?=
 =?us-ascii?Q?dYjd6azYzChNNUizJpUceOM52JxeYSE5UYOBz/s9+Omo2CMVYNFsI2NoGKqE?=
 =?us-ascii?Q?3fW/7Rd/lfr8DqZDfh/uGwGeVjO+V4zTKi49IBvyfML4APISdKxUKpcOky+R?=
 =?us-ascii?Q?f4+ZnDTn69lmq5w5f9plHKRa1ae3MjQj0egpknB77ZbXqnFVAmYHyJZ3ts34?=
 =?us-ascii?Q?Th3yMEtWpqrHaSgslN88iR9AigGtxH+XtxnRd5ngn3Igc4P9c2mSHBslPO8+?=
 =?us-ascii?Q?FtRBZtsRyyuO+vIbLf7RyA0dnIJX/KoDQIDw2pAhFa0gd3Aca7lh8i0TfoB6?=
 =?us-ascii?Q?Wkk9ZaO5M/jiX+OlqhNuFc7CwlMLOL2XhTNj7ijbJdrMmfD9ACOHUdyP9L0J?=
 =?us-ascii?Q?F2fz0MESZTfWlUjRboGpfZtnYm3s6auGbEqt6l1qWv/cyVGHCvNMk5iMJTMk?=
 =?us-ascii?Q?GWum7Hhhke/avl9X7Ftid1QsVOkKqUUPN/0er2ibzdDu3IK+zf6xNrn4qUAO?=
 =?us-ascii?Q?Jmt5idcDqm/QHUQAw/mc9daZ5MQkHAsIZm5Qp373ipbrGjncYzq81ahXTH+T?=
 =?us-ascii?Q?nma2ybKYVWOE2pIVSgTdD+n0gELGbB3N+HHQq9mi79IRKA+X7ogB61Kk4NU4?=
 =?us-ascii?Q?lS752J5SA0x89swwXN/0u8v8Syszb/g/voOZzpmpIB7UwEdh77FZA8GDs81N?=
 =?us-ascii?Q?9UI8MulE5FU4bbRnEXcRwZMQQ7HyR0tXMiwZwS+rO7Dn+Y2JsqG1BE6ShWUI?=
 =?us-ascii?Q?6A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2F18D9C5C44FF740A287C0A64374F329@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: qTTq9h/ahpyunGCJqWHKWILYrJm7EVB/iDz8SdvcxguAJoDjpD7Kh2JZnYybW+8YUN2CNopuFVcr0WpOvhdczI366HlIG+DT/8CqTASZYrCJOBzWg6t03nlsowR0baHI5od+5XpALd9h2PtiaQGFr2lhdQ3F5RqiESxESs5mtf0uYK2XldP00yek5ertSJUq8rCfNkVZvInpPRL/OrgH18Q2ZeWIiAyH4Az/OiGB+jmuxiybaR2y+yWgwnLYfN/IryKg+11BTvguQsuF9klAhGf+txm5qjzMhdwjE11m/Gslouj8Y4YumhGMNQQfvmAHP9j0x889tg0OA9ZbwteOEumj1UY3TQHHyV+OE2/OM7gAzhuMhXpLNQRh5JZMFq3DWZ+PcDkCTPacBsR7G22v8lMCWouZYC9Xu0DNjM9htV2geIFhGWfqlNGg9XDxxj2cSKHVnmGiY8mXeS0+QIG4dgLn2Mp+w1VUJrK0b27pvjhiQouPr4ADurX8IwKRAYJZtN3ExccbkJqmRw34e1zD/IzWqMThvl+HyyNOW/x7rs9ko9LJCpfVCJgExVqTLhJP2SopU+mRG2yhk0fsOgQlcQ5QRC8Q3LOL0pvmzzheMcDfZD3e3ZLXIipmAj0H7LYtJkWK8GpRBCdr0v5TGmi2zVFDdLOVWPkDanqkqdQSQoPwkSTxvYg9d7Mu45UOYp4K+ct3+qImeSIieUAbZvqJakGWfct7EYsl9BAfr+mFG636qY450ODTNqLwrXWpQrBJPlJPC6smbPbMnuiejGXDwzX2/uo9nlNprkLqw78/2hQx9594LwQWmUhii23rBxFPfS4dGATG3kNJ047hoLYAhDeMCfa0DNVkxF11arBsw1IaPN2JJQyjqmNf5KQ+3ptIO022H7gxQSYf5go3Km1OMqJj74GQakGxYtFNIcVVPiE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f17c7169-3dbf-4a12-0a28-08dac714fb8d
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Nov 2022 14:23:35.9788
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rKL+rHJwrlKfdwHtU8RBNyJZESPXLNeyynbhYgaiZnuxyHQAa5pTSw/jhAQwKbcKM0f7cxrPpKu8jUe8dvCaHA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5003
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-15_08,2022-11-15_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0
 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0 bulkscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2211150097
X-Proofpoint-GUID: dvEIlnmjVZz2jocSkt0dvhZndATK6Zx2
X-Proofpoint-ORIG-GUID: dvEIlnmjVZz2jocSkt0dvhZndATK6Zx2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 15, 2022, at 3:55 AM, Leon Romanovsky <leon@kernel.org> wrote:
>=20
> On Mon, Nov 14, 2022 at 10:16:12AM -0500, Chuck Lever wrote:
>> Steven Rostedt says:
>>> The include/trace/events/ directory should only hold files that
>>> are to create events, not headers that hold helper functions.
>>>=20
>>> Can you please move them out of include/trace/events/ as that
>>> directory is "special" in the creation of events.
>>=20
>> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
>> ---
>> drivers/infiniband/core/cm_trace.h  |    2=20
>> drivers/infiniband/core/cma_trace.h |    2=20
>> fs/nfs/nfs4trace.h                  |    6 -
>> fs/nfs/nfstrace.h                   |    6 -
>> include/trace/events/fs.h           |  122 -----------
>> include/trace/events/nfs.h          |  375 -----------------------------=
------
>> include/trace/events/rdma.h         |  168 ----------------
>> include/trace/events/rpcgss.h       |    2=20
>> include/trace/events/rpcrdma.h      |    4=20
>> include/trace/events/sunrpc.h       |    2=20
>> include/trace/events/sunrpc_base.h  |   18 --
>> include/trace/misc/fs.h             |  122 +++++++++++
>> include/trace/misc/nfs.h            |  375 +++++++++++++++++++++++++++++=
++++++
>> include/trace/misc/rdma.h           |  168 ++++++++++++++++
>> include/trace/misc/sunrpc.h         |   18 ++
>> 15 files changed, 695 insertions(+), 695 deletions(-)
>> delete mode 100644 include/trace/events/fs.h
>> delete mode 100644 include/trace/events/nfs.h
>> delete mode 100644 include/trace/events/rdma.h
>> delete mode 100644 include/trace/events/sunrpc_base.h
>> create mode 100644 include/trace/misc/fs.h
>> create mode 100644 include/trace/misc/nfs.h
>> create mode 100644 include/trace/misc/rdma.h
>> create mode 100644 include/trace/misc/sunrpc.h
>>=20
>> Note: with an Acked-by from both the NFS client and RDMA core
>> maintainers I can take this through the nfsd for-next tree, unless
>> someone has another suggestion.
>=20
> Please update MAINTAINERS file too.
>=20
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4db8e4e02c05..86e57325eb6e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10054,6 +10054,7 @@ F:      drivers/infiniband/
> F:     include/rdma/
> F:     include/trace/events/ib_mad.h
> F:     include/trace/events/ib_umad.h
> +F:     include/trace/misc/rdma.h
> F:     include/uapi/linux/if_infiniband.h
> F:     include/uapi/rdma/
> F:     samples/bpf/ibumad_kern.c
>=20
>=20
> Thanks,
> Acked-by: Leon Romanovsky <leonro@nvidia.com>

Done. Thanks!

--
Chuck Lever