Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp6998753rwb; Tue, 15 Nov 2022 06:28:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf4enXiaULLWjrb9fsA7PPtBMCZeZC91fNJNPX7ZyZ/kxo3i3MgeolMaVH2NWv7c22IIWkKD X-Received: by 2002:a17:902:b695:b0:17d:95af:fb59 with SMTP id c21-20020a170902b69500b0017d95affb59mr4178581pls.154.1668522538101; Tue, 15 Nov 2022 06:28:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668522538; cv=none; d=google.com; s=arc-20160816; b=LopzPwIHnLlkWyTzrhAQV3Sho6wOvYglyWAOtnnK/EsTsJwnzhd3XMT5YbT7irQihr LY4ccFaynYQ/kFjVtetrRl+EpgPecuo95zbScEvcRnS0WFH8IbObTIrE5moelAJ1fWU3 pyo3Fkv2fufl91zeGrjbqPmFSdF1ELiTtaKzr0E8xiWH9bXNV/ByY18os4VGrNEMnoL1 ayliaUxqO7Fn+rINx51uMXgIN/iHVVlxAt+QfT0LzWSqiCCGVn0nDtGEqw63NigVH0AN k5iT1wGYBpEWJf6iW2TZ9cFBClnbWilkLlyhpd60MdYhLlU1FHKrUq7cByOEaNYOlfXt fzhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=FTjuz4JepReHw1dMiXsYcgXlr5+VI0txGYHK5km3JLo=; b=kS5R1Io2pfgVmS4gGXngYPQMzAP/1pnM0ZxxEZ6vx8P/5W1qLkD2nuePAzO5+b3TIa PUkSMPEA5qjQYBQk87PUAP3l6BD9c+LlAbJ38cjXXsMHs1yYgR4nb2ak+rBhbLqNHeRv Q7bk9E9iAXjx4LfFet+gZ0aw3ysxUuQQcxxgnysWHRdD3ELtGs+yIAUeS98zXSn0c03o 6+sd4OcyDWpAaO5k0iuQ6msDDHTov45Y0lA5LFAfoy651hZxquGTA8YIKVAaGZdMx8kT 8+/9UYokkTvgkegu1GQTBTjMP1s8U0mKqpek57kwOQT40b+iiI77r7IUq73LmYWUCViy TXBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f27-20020a63555b000000b0046efd063864si12117843pgm.109.2022.11.15.06.28.42; Tue, 15 Nov 2022 06:28:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229665AbiKOO0C (ORCPT + 99 others); Tue, 15 Nov 2022 09:26:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiKOO0B (ORCPT ); Tue, 15 Nov 2022 09:26:01 -0500 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8EB32AC5; Tue, 15 Nov 2022 06:25:59 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5E063CE1754; Tue, 15 Nov 2022 14:25:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E86AC433D7; Tue, 15 Nov 2022 14:25:56 +0000 (UTC) Date: Tue, 15 Nov 2022 09:26:38 -0500 From: Steven Rostedt To: Chuck Lever Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] trace: Relocate event helper files Message-ID: <20221115092638.62cb7322@gandalf.local.home> In-Reply-To: <166843895843.170837.8663873976042560070.stgit@klimt.1015granger.net> References: <166843895843.170837.8663873976042560070.stgit@klimt.1015granger.net> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, 14 Nov 2022 10:16:12 -0500 Chuck Lever wrote: > Steven Rostedt says: > > The include/trace/events/ directory should only hold files that > > are to create events, not headers that hold helper functions. > > > > Can you please move them out of include/trace/events/ as that > > directory is "special" in the creation of events. > > Signed-off-by: Chuck Lever > --- > drivers/infiniband/core/cm_trace.h | 2 > drivers/infiniband/core/cma_trace.h | 2 > fs/nfs/nfs4trace.h | 6 - > fs/nfs/nfstrace.h | 6 - > include/trace/events/fs.h | 122 ----------- > include/trace/events/nfs.h | 375 ----------------------------------- > include/trace/events/rdma.h | 168 ---------------- > include/trace/events/rpcgss.h | 2 > include/trace/events/rpcrdma.h | 4 > include/trace/events/sunrpc.h | 2 > include/trace/events/sunrpc_base.h | 18 -- > include/trace/misc/fs.h | 122 +++++++++++ > include/trace/misc/nfs.h | 375 +++++++++++++++++++++++++++++++++++ > include/trace/misc/rdma.h | 168 ++++++++++++++++ > include/trace/misc/sunrpc.h | 18 ++ > 15 files changed, 695 insertions(+), 695 deletions(-) > delete mode 100644 include/trace/events/fs.h > delete mode 100644 include/trace/events/nfs.h > delete mode 100644 include/trace/events/rdma.h > delete mode 100644 include/trace/events/sunrpc_base.h > create mode 100644 include/trace/misc/fs.h > create mode 100644 include/trace/misc/nfs.h > create mode 100644 include/trace/misc/rdma.h > create mode 100644 include/trace/misc/sunrpc.h > > Note: with an Acked-by from both the NFS client and RDMA core > maintainers I can take this through the nfsd for-next tree, unless > someone has another suggestion. Acked-by: Steven Rostedt (Google) -- Steve