Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <eef82083-c158-4afa-645c-0bf1518d5db7@huawei.com>
Date:   Wed, 16 Nov 2022 19:45:02 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH v3 0/2] NFS: check FMODE_EXEC from open context mode
To:     <trond.myklebust@hammerspace.com>
CC:     <linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <yi.zhang@huawei.com>, <zhangxiaoxu5@huawei.com>, <anna@kernel.org>
References: <20220923054015.2890271-1-chenxiaosong2@huawei.com>
From:   ChenXiaoSong <chenxiaosong2@huawei.com>
In-Reply-To: <20220923054015.2890271-1-chenxiaosong2@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Trond:

Do you have any suggestions for this patchset ?

在 2022/9/23 13:40, ChenXiaoSong 写道:
> Currently, we check FMODE_EXEC from file f_flags, and check FMODE_READ or
> FMODE_WRITE from open context mode.
> 
> After converting file f_flags to open context mode by flags_to_mode(),
> we can check all mode from open context mode.
> 
> ChenXiaoSong (2):
>    NFS: make sure open context mode have FMODE_EXEC when file open for
>      exec
>    NFSv4: check FMODE_EXEC from open context mode in
>      nfs4_opendata_access()
> 
>   fs/nfs/inode.c    |  3 ++-
>   fs/nfs/nfs4file.c | 12 ++++--------
>   fs/nfs/nfs4proc.c | 16 +++++-----------
>   3 files changed, 11 insertions(+), 20 deletions(-)
>