Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp760444rwb; Wed, 16 Nov 2022 07:20:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Mf6yjKJanxX4+KDjDREjiJKwNYLqyi66Y2ngCJEH2RQSP1wvTpRdjxJjEJ6wbRMrJRPA6 X-Received: by 2002:a17:906:408b:b0:78d:b88f:1548 with SMTP id u11-20020a170906408b00b0078db88f1548mr18787078ejj.221.1668612034514; Wed, 16 Nov 2022 07:20:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668612034; cv=none; d=google.com; s=arc-20160816; b=oOUeIdjAn1bkJZDW3DKnAY1Mltd/IrJvApMECVqmIdgOpNPgQFBh6522+e0y61WrD9 FpziFrOYIPPfOOxKI6kxCDR5XG7hNXwC3UzX7/3weEQmQjpMT1rWpRPoPuagoTxPDtao y095nxIKsOq6tCZEdfGzz4p0Elhj1Vzz4BVxIptNJG0eEmdn18+B1AshVqAVnW0C6PrK HSNheed112KlMEN0zQ69Tzetrv5HoEH+TzhAwhrVOwPtiecbmKRr+h1LwDUO5aSvcV0C y68Tt7nnCRuEc0/YsUWEvmdGX4HLUskYMfW9RYAKPmvjUaG+nckuvE99cThEYwZeCXOE wVqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YQPFwuZYfi0K51EPDLLIq8PgnsNWyq+dX+qz3nmS4+A=; b=00x2cr9OGGSj8cPV6Hx9H0sU03sWf9VZj+r1txcKXTB5yr9iVwD6yv9UnlQCuWMGwB MvCJPj3qW3sxPnRyyEaKTI82h5BaWrq5B3Rm7pNGUQdvLdFSsG4jh3HkPSja/yA58ckT lQYqN4fqA/b9Mv1lXCZio0uxOgt4XpDI/+zbZjOLxly36gd7Slt+sPpf5xr3RbsO8YCt 71GAWJMveYoqP9ikXpEIgdmQYdRS4BSX82bpqxHP40/yvfJ41HXRX8QymNWd/xgT/sgx JyeElnBoDGslajUXt8ToZQzMvGioRjj0SZ8HF1cqXj6trJO/UNsHwYmNfuwdwXzD5EOO XmPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GFSJEruB; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ke15-20020a17090798ef00b007a6384d506csi11650094ejc.643.2022.11.16.07.20.07; Wed, 16 Nov 2022 07:20:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=GFSJEruB; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233664AbiKPPRi (ORCPT + 99 others); Wed, 16 Nov 2022 10:17:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233340AbiKPPRe (ORCPT ); Wed, 16 Nov 2022 10:17:34 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D86A2B625; Wed, 16 Nov 2022 07:17:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2863B61E83; Wed, 16 Nov 2022 15:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE7B9C433C1; Wed, 16 Nov 2022 15:17:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668611852; bh=yV8M/3emkfa0v+JOTDZ4rZGKsnEb+eyCdX2b35M2HGA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GFSJEruBqD3UjsUIscezAfqvMdcvsa4Sl5KLDACMuWA/jiXclACdRl7MAwGXNgfCX ZRZ3RXGnFqrqcsUWVXmTwi8+XiN3bEZA/bs64yZMZNY3WQ/h9M9CMe8wo6RbhaCFRJ D5SxE48RrgWvuHOJjKziqn/gyrMvHtM6hWzKxCxHByE/IfL+UhHfgtbqp510ks4yRN be/726mUIC3CgM0V0qVa1TxdCFXaDVm/PrazWp6q2Bhy2S079bngjE8w5TWKL5FlhI BxVj0krDMw8KFxT4xtaDEdV5fTVfaMIf3KT/eFx33rCi/AtT6jZGMGDHsnd4d9ziZZ VclL82dby9UUA== From: Jeff Layton To: linux-fsdevel@vger.kernel.org Cc: linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, chuck.lever@oracle.com, viro@zeniv.linux.org.uk, hch@lst.de, Steve French Subject: [PATCH 3/7] cifs: use locks_inode_context helper Date: Wed, 16 Nov 2022 10:17:22 -0500 Message-Id: <20221116151726.129217-4-jlayton@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116151726.129217-1-jlayton@kernel.org> References: <20221116151726.129217-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org cifs currently doesn't access i_flctx safely. This requires a smp_load_acquire, as the pointer is set via cmpxchg (a release operation). Cc: Steve French Signed-off-by: Jeff Layton --- fs/cifs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/file.c b/fs/cifs/file.c index cd9698209930..6c1431979495 100644 --- a/fs/cifs/file.c +++ b/fs/cifs/file.c @@ -1413,7 +1413,7 @@ cifs_push_posix_locks(struct cifsFileInfo *cfile) struct inode *inode = d_inode(cfile->dentry); struct cifs_tcon *tcon = tlink_tcon(cfile->tlink); struct file_lock *flock; - struct file_lock_context *flctx = inode->i_flctx; + struct file_lock_context *flctx = locks_inode_context(inode); unsigned int count = 0, i; int rc = 0, xid, type; struct list_head locks_to_send, *el; -- 2.38.1