Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>, Olga Kornievskaia <aglo@umich.edu>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH] NFSD: pass range end to vfs_fsync_range() instead of
 count
Thread-Topic: [PATCH] NFSD: pass range end to vfs_fsync_range() instead of
 count
Thread-Index: AQHY+dA99BTueKkoaUW8ZOhqLPsIj65BriOA
Date:   Wed, 16 Nov 2022 15:34:16 +0000
Message-ID: <87A52A9B-83F7-4FE6-8ED1-E710BAFF84B5@oracle.com>
References: <20221116152836.3071683-1-bfoster@redhat.com>
In-Reply-To: <20221116152836.3071683-1-bfoster@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wB6lLodV/zQLjZHGGwPu+xABPDSnXhLnBs1qbG68kTUNNXhThAl9iGEobyVx?=
 =?us-ascii?Q?OnbuTh5ug5raXF19NwV6L2Bo9wadyLvWBQryjLhkiXSPxFss+4dOctR/Yf/Y?=
 =?us-ascii?Q?rBNCm3ajcmBS8x/CJhWrGEnBeKQB2aIhlNBKybyTrUF27+ZnJ0HGCxnIaVbc?=
 =?us-ascii?Q?Avt6H0J5GasBKdCBI4II38KuMHf0yQqsScsvxXsdxyU9SQMkEpARbkNjZkt0?=
 =?us-ascii?Q?lbpc0F8d1SS4vU4Nae1LE5NK7kiXWv1CuTfiVHE5ni68Nfkiv+/ji4p+MMsl?=
 =?us-ascii?Q?B56NK3Qkqn8I6VJq3M8W2YSQTnEtNtWSXYQmGHUIGYjFHMZCUPH0n3PvqdQ5?=
 =?us-ascii?Q?GF3qZ1YMZ5HFDOrD8HO/Sm2ZXZd2Mr0GssyI1UW5Cl2PfKqT7O3FTe1hbC78?=
 =?us-ascii?Q?F5tBkPGrS4Mc/4CIrq9FPgYmQmCnnOEmoSHtMFQsAHeCXSDVCk7+d6fhdetT?=
 =?us-ascii?Q?zLpvjqnMvm11vRX5a3bEatdHHCHALK3WWO5Q1PcW1SvXcqW10bNanQfffiNl?=
 =?us-ascii?Q?yZgk2sKdOBoOxgI7BJaGWt9pE4R11TaVDE2/ObbytGJ/Tbd5rG+4JGzAV7FO?=
 =?us-ascii?Q?odm7A4fZDRhRmvbq4bMY80IdCmrHj8Kd5Wb9VChkIUMeGsmXbo0eCy/r/w/Y?=
 =?us-ascii?Q?woz8Rjdq0F8+sUc7Oq0+PMpivmQlnzJK8L6qIkm8HSpstToilz0zOlfmJa8o?=
 =?us-ascii?Q?XdGndPXYDdday87DAwsaX7YLHFBpEI6C2nxDWOrUgeiJc9ws/n4Wjcd+myZt?=
 =?us-ascii?Q?2xf3LrSl/oXCXviS1p1J367iGuR7lduYP4VKh8RfuVlPUiyCYcKJnVjsLVgY?=
 =?us-ascii?Q?TpA7pohY53PLiZMngLkkmnvanf4hZh7+/HvXA4LZd1bw+yXvfzz9Tk7/rvGn?=
 =?us-ascii?Q?C620Ux1lzehy+2BaTUxC+0oA71g8+fAbmrXlDEpZY0vDqxKzZR+grVrXOG1D?=
 =?us-ascii?Q?sNtCK6Rj470OITIQWDBEndcClOZZn4bcD8Jo+E/XvsB3m4o7BNz9pm4JDuyx?=
 =?us-ascii?Q?BeoXgxOXqeKq1N6jxK/i4Y2sHCjh05ipRNvwPRbUOM++uQ5YkQB+fYCrAQdQ?=
 =?us-ascii?Q?jJUCv7tj0uuG1adjsx3qZNiWskYdFgwuz1ffru7HH7FAzXK2wlbnFp43gdip?=
 =?us-ascii?Q?H8zeHvFBsHwVy56/h10FPFZKUzg+GsYiR5x6f4SBDiQToFxi8zTjvGgpvww1?=
 =?us-ascii?Q?cuxws3XRW/BASBsK02yrcwty382aOHwC/6kwMSeafJMRbZRo+YVmdxjasVBz?=
 =?us-ascii?Q?0T5X3oEscbCmJDEB/LEuML2pHH+kU7GV/nClVGAsGztE7t9R0mFP1kfRisPb?=
 =?us-ascii?Q?wjHbto2I3kxyJKmyBTXgnAvSv5a3DVQR+P+Nlt1Gst4a3JyGzw/V1kL8vcE9?=
 =?us-ascii?Q?R23GuccV5LUbOoDRgEdpWJS1niGpme9ihk2aKdhg/mxX7QUvI6Fuk7gujCv6?=
 =?us-ascii?Q?TjGrZfwJylAS5q43IUPKUcMcrk5J3mA72Y6HXZskGIHwW8rzqFg09mB/T2Id?=
 =?us-ascii?Q?Lo0tKPZrQouiN1+I4GFaoeh3OKLS34oX3rvgCw33CV0e3gJElWnJ8sKyfTrb?=
 =?us-ascii?Q?x9+olSaZCFnwh1WlguEdY2CgCwMXIEDVOvu8keJTBYZUGoxAgBWSFndEcqCR?=
 =?us-ascii?Q?Xw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F99D53267A2FA34C94C2E13148864605@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: +lic2oUZGYxoWEkuBOijWLkOvwfmZdpCYqfK5+b4cez2RFYy4U2+/8L2/qoNzTcMgkhJM1SpU6JO700sJThlosRoceD8/AgCa4AzkkzvPAdpLyy0vX8YBwvBjTBQmtu7MIjT2JqVtQ6zM6/e8YzYlkE4fM53p+dN3Cc1g5m43r1FRfzvBjKj0mluWHLuJARxpqKbd6HzxNd+U3Szy2kQ8HlTbmXIB4jPzWfZ4u9BanVRltrSp78wPYR3RWufp7oL9C42u1rNQDcMx8sOOmw2ZtZPHn42dtWPhFSVn3KTA0iK+mz28YZv2Hn0ZJw46U4f6ut15UtK5VDv/JOta8C/7mbxopJsb6xZZoNG1c+wztnpK2Qo4SCIqzCxmYZF+Q3mRszk+KAZvDM8xe6mGu+KqvHAQ4utHkIWZXduAau2dgSehV3yVkKeSrS9WitVFPeVcAM3RrEj8rEnP2nFEnqZXCRnQyTIj9MqLhgIrbMrPZMAW1xQaG+ZO2Hs8IIXQderYRoNkAsN/OFG6bevD+FbhBX2A7CJD+CSLXy6mpKIHqj0kDbjpwgxFZj2QS+Pv1MEdXgRTxLTE6DZhrOAnDKHc2MAchBief+xPXnq0NRnuFDk1rGwh8KdKYZzVeHthCBG82JeNjSi6eTPnYuPjG2xqhglXwr6WtvZRzxk6VVkevsu+hP5nSxaH/rptrrxngHCZ0NUuSgWPwFiIhNvWCifMG8gIc7JPWPfRApxtBU4Cn02ihdTO2w7JGmKwhPUlA737udQ9pcyHrkkrCLxXp3fwpbjuO+6O3oGgxzS/KOvDsgGjY0MsedyhnxD0A9F4Wnu
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cc3c51ab-8927-4f87-25c4-08dac7e80586
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 15:34:16.4739
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lbsln9MTeciJFIR6YVXfBrtkcwjGPZn0HEVERt2NFzBYxYOXPETz7BFYOQGuzjNrMtTX+Etdh6AQSHurkjddsw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4663
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 spamscore=0 adultscore=0 malwarescore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211160108
X-Proofpoint-ORIG-GUID: KDB86ltdJ4hFKO4q0isqI07TLt9cHkle
X-Proofpoint-GUID: KDB86ltdJ4hFKO4q0isqI07TLt9cHkle
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 16, 2022, at 10:28 AM, Brian Foster <bfoster@redhat.com> wrote:
>=20
> _nfsd_copy_file_range() calls vfs_fsync_range() with an offset and
> count (bytes written), but the former wants the start and end bytes
> of the range to sync. Fix it up.
>=20
> Fixes: eac0b17a77fb ("NFSD add vfs_fsync after async copy is done")
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>=20
> Hi all,
>=20
> This is just a quick drive-by patch from scanning through various flush
> callers for something unrelated. It looked like this instance passes a
> count instead of the end offset and it was easy enough to throw up a
> patch. Compile tested only, feel free to toss it if I've just missed
> something, etc. etc.

Dai, Olga, can you review this, and one of you test it?


> Brian
>=20
> fs/nfsd/nfs4proc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 8beb2bc4c328..3c67d4cb1eba 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1644,6 +1644,7 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_c=
opy *copy,
> 	u64 src_pos =3D copy->cp_src_pos;
> 	u64 dst_pos =3D copy->cp_dst_pos;
> 	int status;
> +	loff_t end;
>=20
> 	/* See RFC 7862 p.67: */
> 	if (bytes_total =3D=3D 0)
> @@ -1663,8 +1664,8 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_c=
opy *copy,
> 	/* for a non-zero asynchronous copy do a commit of data */
> 	if (nfsd4_copy_is_async(copy) && copy->cp_res.wr_bytes_written > 0) {
> 		since =3D READ_ONCE(dst->f_wb_err);
> -		status =3D vfs_fsync_range(dst, copy->cp_dst_pos,
> -					 copy->cp_res.wr_bytes_written, 0);
> +		end =3D copy->cp_dst_pos + copy->cp_res.wr_bytes_written - 1;
> +		status =3D vfs_fsync_range(dst, copy->cp_dst_pos, end, 0);
> 		if (!status)
> 			status =3D filemap_check_wb_err(dst->f_mapping, since);
> 		if (!status)
> --=20
> 2.37.3
>=20

--
Chuck Lever