Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp827891rwb; Wed, 16 Nov 2022 08:10:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf6qILZsl6zdpqGWW7C8RPbPvsiQ3EiRyAVScCO8oDpsIP/Wx4JIENfwYFNeCuGGYj9my9Mb X-Received: by 2002:a17:902:b081:b0:187:3932:6422 with SMTP id p1-20020a170902b08100b0018739326422mr9431426plr.135.1668615037544; Wed, 16 Nov 2022 08:10:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668615037; cv=none; d=google.com; s=arc-20160816; b=Jg+EqfvOnjf4qeE8hxprNJTA2jA3A5M8VWlNaHkcpKhivTL2SDeFeFfb55loz6qcko gInamzFYPQTJvQtPiTfDq/fTYehF9FYkA6yjvXZGeSRjkVkVPcWkXNgjJmeWIWBMKzNV cUquyCJyJeeZy8o6H71ub3AUVUEKcnmp6t/+HwmGrgMd5uxVklVvRdTMfrpcQ5oIwxks vMfsa74nGTDruccuL+SuvBQ6GleHaN55RN32+07cPBq22WajkKv941RKzcjkJOeCD4IT c2cI+dt/v0whi6fneDSNAy7n8fPQbIY82HplzTIcvGnuv97g9WaX7UX+GxwY9CfDn89p 9X0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MkALmH4XzOeEQFfjeCdhiQfItADg4fLsnbQ9RHdaOPg=; b=X5cxCQEckXUv4X2YZzn1yMhsQtLiC60b4l/FFWf6+vj3WMTQ4gB1OuNPImft51I/2O kAA4YXoR/aVcdRiy84rlSUuJLv60VUgHpX2YBz9FvX9317f+OT3rR+mXxrFUWcbteDL2 sIN3fBdMCQDVFKasl5/ev+hZfa4hXsb/iCgfq5AT05XyDyclUDkXKpT/Q/XzJkuQF4i+ aB07SRkjXr7lOcVupmOK7n/hcE42pHVVxlcm6vjtHWGOl9ddsn/3AE4LDpNhRR7sOOFG wYE7HGhDSICZ26SuFiDqIbipCVIbOUI8VAn5l+MhWX/UJBAFMG3PnzrFBvdUb/NEGlkE DTQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mRKwU1kk; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f14-20020a63dc4e000000b00476d73d3a98si3490484pgj.510.2022.11.16.08.10.16; Wed, 16 Nov 2022 08:10:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=mRKwU1kk; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233207AbiKPQIk (ORCPT + 99 others); Wed, 16 Nov 2022 11:08:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230204AbiKPQIk (ORCPT ); Wed, 16 Nov 2022 11:08:40 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE1A2AE7; Wed, 16 Nov 2022 08:08:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MkALmH4XzOeEQFfjeCdhiQfItADg4fLsnbQ9RHdaOPg=; b=mRKwU1kkn/9LgKr8+RnldYHXjp VZrOOfPwE5uXiGCdMF7jyYGwNtB4uFnvLDpGcy08ESRR50VOU7+6APQwYf2RNpPsWIddI/vvbUAPh QdZSTAp56N/1LO4hYhM8GpP19HHaHT0Dy5MOYn97HGBqNmJ/8+8Pv+laMHyUuO9mrndlxJI6DjG2L o3zr9tpa3GYyn+4Goj2+fC8P9m8gboFXyLdqVCelkXNtlp1nvY4NzMkkuD9PH1A/0ijqG0m/28Cd/ SmQmRDbLJzuaPiKtWWDl3kd+9tKUShI8TQqZt1k3HJAWSlUvEoUW06FNhfA80QcfBqKNhEG1rGYZL T8rxw/Gg==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ovKxp-005i96-22; Wed, 16 Nov 2022 16:08:37 +0000 Date: Wed, 16 Nov 2022 08:08:37 -0800 From: Christoph Hellwig To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, chuck.lever@oracle.com, viro@zeniv.linux.org.uk, hch@lst.de Subject: Re: [PATCH 1/7] filelock: add a new locks_inode_context accessor function Message-ID: References: <20221116151726.129217-1-jlayton@kernel.org> <20221116151726.129217-2-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221116151726.129217-2-jlayton@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, Nov 16, 2022 at 10:17:20AM -0500, Jeff Layton wrote: > - ctx = smp_load_acquire(&inode->i_flctx); > + ctx = locks_inode_context(inode); Nit: this might be a good time to drop the weird double space here. Otherwise looks good: Reviewed-by: Christoph Hellwig