Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp831893rwb;
        Wed, 16 Nov 2022 08:13:22 -0800 (PST)
X-Google-Smtp-Source: AA0mqf7CwetCoPRsoR2Bvh5e4U0Vnid9xVWvkDs9Wxb2Eje4g9pUIzpvGc8Tt6GWVbvqd90W0EOF
X-Received: by 2002:a17:903:40cb:b0:17f:6aef:3c83 with SMTP id t11-20020a17090340cb00b0017f6aef3c83mr9617748pld.9.1668615202011;
        Wed, 16 Nov 2022 08:13:22 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668615202; cv=none;
        d=google.com; s=arc-20160816;
        b=BmTfW1irUt529OtoH2mvCie8T9lLjlyfg3tA84J4tJpAAmaiyw2adv2Rrjdck1M/1F
         chq+F89bOEyOM0jE9S3fV6szi466nqAXEXjtmh1gZjhzgrMtMzqdlODaxjM1kvFI/ebu
         4PrVr1rHbnsPlZnA6b8Rz7ri74VswkdShOS0Pu1iKJFUmDuZC9vCfUnuaQdlXRVcOoA3
         JGYbkRdwZSnXptZDj9jGCBpTV3QvnDPLFVNz3VWW/n0ePADMZJ8ZeL97ewliXl6G9a8O
         i88PIvYzbG1F378mYW9z+8rmaV5LZYH//h1zMEaj1EeN59Fkka7RTBuXWwPSykScCfvE
         EASw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=B0kDkUWYUK/q8mtpuh1BWXWaKhsWYAxYUFkjbnqVJH8=;
        b=MHgAu5ZVs4I3Hs5ovr1/j3yDDjYIy9NVb/DQWQiwDX3+1akPIgX8UZ0V5yBoQZYlmN
         1YQ0vbeiuUcWV7DijAHCX+d5yRiRcfd8+m0tBYVLOpZfNdHTRgJTxuyruYfmX3xEzViv
         nSNkAzmhnl35/tIf5ExeEtBJXUkTvxFlLEgppXuQH90q11LdVkWhVwg6mdc8FtVS5yU3
         LKhRtg3HiwabuGua/TE/4l9C/BQxIAEI9X8BxlLafb+RRzxrW0QkRT/QwCRqscNunQLN
         NAVsXh/KJVBsXOUW9u2+NOWV1mr05OH9ggqjxU9IyvfBGeRdcbgiSZjy/It6m9jHrwdz
         lJOQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=thO7BiFg;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id y12-20020a63494c000000b00463dbc5cebfsi3727824pgk.67.2022.11.16.08.13.08;
        Wed, 16 Nov 2022 08:13:21 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=thO7BiFg;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234047AbiKPQK2 (ORCPT <rfc822;rosenp@gmail.com> + 99 others);
        Wed, 16 Nov 2022 11:10:28 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48896 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233936AbiKPQKZ (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Wed, 16 Nov 2022 11:10:25 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45B364C267;
        Wed, 16 Nov 2022 08:10:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=B0kDkUWYUK/q8mtpuh1BWXWaKhsWYAxYUFkjbnqVJH8=; b=thO7BiFg5aqpLnc3cgzT1wKqnO
        IILQd1fVsSULH5hj6XWy4ooH4xNP+lEFabVKnAXM6z2X4JxUxK4V8WymD/iypvQyYfkLMyjxccyqG
        bpua8iH1KdMd7EY6dWA8Ommi23UQWsFT4lshnghq569/nq/B3UWcC+96xFztx/s6vWYXDjmd13zOb
        sXY14NMpvb/BO274axghAT/40yJ4MyLwpGPBU0Df6Hced2deBF2BmWGoYXwhQCq96QP9YJcEmm6lz
        ZyN2659O2bYGtUstv8HFf82dzaWIfRdf/rP5oAIk9D648rX4nJSlqoGaYI4ptgL4CxAm+NxO9x68q
        eVXwsYkw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1ovKzY-005jDu-SW; Wed, 16 Nov 2022 16:10:24 +0000
Date:   Wed, 16 Nov 2022 08:10:24 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
        chuck.lever@oracle.com, viro@zeniv.linux.org.uk, hch@lst.de,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>
Subject: Re: [PATCH 6/7] nfs: use locks_inode_context helper
Message-ID: <Y3ULcJhkjCno4Hrg@infradead.org>
References: <20221116151726.129217-1-jlayton@kernel.org>
 <20221116151726.129217-7-jlayton@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221116151726.129217-7-jlayton@kernel.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Wed, Nov 16, 2022 at 10:17:25AM -0500, Jeff Layton wrote:
> nfs currently doesn't access i_flctx safely. This requires a
> smp_load_acquire, as the pointer is set via cmpxchg (a release
> operation).

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>