Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp831938rwb;
        Wed, 16 Nov 2022 08:13:23 -0800 (PST)
X-Google-Smtp-Source: AA0mqf6Ra/VvwqzI0q5zzbcMXVOuKobeyEWN5dvhJD19RrEttrDTrY09KQfqF0LLvtWIb6nhj8Xx
X-Received: by 2002:a17:90a:8a96:b0:213:e8b5:2d50 with SMTP id x22-20020a17090a8a9600b00213e8b52d50mr4435776pjn.211.1668615203547;
        Wed, 16 Nov 2022 08:13:23 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668615203; cv=none;
        d=google.com; s=arc-20160816;
        b=WmuBgApUjM8VpnoWweP7lqP+VMLGIQIvrV3/W9CoJIRCH4MzZpJTx6ZblsMuIVzCxC
         YMfnwjt/1kV+aGz9m07/iw7ZfJoTVDCYCnkjxJj+q2AEwyLpmIUGxfn+diVH4GvsUk5e
         PHpSz2cDbPCgyl7H6mW8rS6gBumIlYQYvVIVFImE6o0xwzC/nFuxHfVKqfRlgD1X/Q38
         wuNUMje1Vp5Ijn0FxeLPC23u2MYVzjWYrkzbVUAdmzmWcmhtrNNW/mMiTsUWxacBikfA
         xINfiGnJshAb4rKtaSEm84mSpLN7NxEl0ZwgcsbfRkdw3fVwe7cNIaoXfkmQteCjSa6t
         mhWA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=u8pM+4vUJLzA9wegq8Q2wocQoUHI07oy0+pM6z59248=;
        b=lpvrPk9i5hSzm6uv8ZrBTLSCInHQ7kG1W0Xi9KLUl18r9GJnP9CUQV/dcZ0buMB2Q+
         a40hM9yBB2KcOEA49QEJCi0HIXjwXCY4Za/RD1xD2Pb/9eftNvFsuY6sIoeT+/c5C7VB
         VnjrWj06XibHv3WyTG5NT958ewQZH+vVE2xmr9R0Rhm7bq0a3LuxmQ0gek1B/AtTqFgW
         qtFNi1AGhEVnFjzbZTWPPsvofaw5KCfemkMgvLKXQTAQNB2Du3J7Lip8l0REsz9ztJIq
         x9inpwTSoEbqvdyo7Uyvaod76vCv/vo2u8AwXqZRqhelqBYzdd+g4Kkr8tZGnRsIjYWj
         aPwg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=BgK8yGuk;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id b2-20020a056a00114200b00571d38602bcsi13428649pfm.295.2022.11.16.08.13.10;
        Wed, 16 Nov 2022 08:13:23 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=BgK8yGuk;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233815AbiKPQK6 (ORCPT <rfc822;rosenp@gmail.com> + 99 others);
        Wed, 16 Nov 2022 11:10:58 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49300 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233016AbiKPQK4 (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Wed, 16 Nov 2022 11:10:56 -0500
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C91E957B5E;
        Wed, 16 Nov 2022 08:10:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=u8pM+4vUJLzA9wegq8Q2wocQoUHI07oy0+pM6z59248=; b=BgK8yGuksK/8uEchNJ6oPqmee9
        AWJOeseN9XlptFYcaTLa5l22iBLR8xdSqghiKpGs5RTFV5mq4evZ5e7fUxTDu45M8exR+tcfDktDK
        lPYsfJ+mLIpvLL7EhI0T1Lw/wI7fdygJP4NlOx6rWdvdLmD8JxRxUtpQYLqiOhTQUxPcvwJ9F3FSB
        5W5wpQPHEkbpr1+atUN9cPbCzBSWF0n6bFLwRRIV8pe0kB3UxijdyCcu/hPg7b0i24Xy2tjIJjgLT
        54h7SpYHo9UjX51s3nPZuS+0xKGoj1dWIvgp8fDyZ3ym8tT2sJUcxOv1O2OSEmkDdrT1jUUORgOrL
        9HWsb9Vg==;
Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux))
        id 1ovL03-005jUr-F6; Wed, 16 Nov 2022 16:10:55 +0000
Date:   Wed, 16 Nov 2022 08:10:55 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
        chuck.lever@oracle.com, viro@zeniv.linux.org.uk, hch@lst.de
Subject: Re: [PATCH 7/7] nfsd: use locks_inode_context helper
Message-ID: <Y3ULjxdeB2GnijAr@infradead.org>
References: <20221116151726.129217-1-jlayton@kernel.org>
 <20221116151726.129217-8-jlayton@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221116151726.129217-8-jlayton@kernel.org>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Wed, Nov 16, 2022 at 10:17:26AM -0500, Jeff Layton wrote:
> nfsd currently doesn't access i_flctx safely everywhere. This requires a
> smp_load_acquire, as the pointer is set via cmpxchg (a release
> operation).

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>