Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e51e721d09fb875c52247d71051728a6bfd0ab97.camel@kernel.org>
Subject: Re: [PATCH 1/7] filelock: add a new locks_inode_context accessor
 function
From:   Jeff Layton <jlayton@kernel.org>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
        chuck.lever@oracle.com, viro@zeniv.linux.org.uk, hch@lst.de
Date:   Wed, 16 Nov 2022 12:43:47 -0500
In-Reply-To: <Y3ULBXgnUvt4amrc@infradead.org>
References: <20221116151726.129217-1-jlayton@kernel.org>
         <20221116151726.129217-2-jlayton@kernel.org>
         <Y3ULBXgnUvt4amrc@infradead.org>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Wed, 2022-11-16 at 08:08 -0800, Christoph Hellwig wrote:
> On Wed, Nov 16, 2022 at 10:17:20AM -0500, Jeff Layton wrote:
> > -	ctx =3D  smp_load_acquire(&inode->i_flctx);
> > +	ctx =3D  locks_inode_context(inode);
>=20
> Nit: this might be a good time to drop the weird double space here.
>=20
> Otherwise looks good:
>=20
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Fixed the nit in my tree.

After sending this, I converted locks_remove_file to use the helper too.
I also think we probably need to use this helper in
locks_free_lock_context.

Folded all 3 changes into this patch, and pushed to my linux-next feeder
branch.

Thanks Christoph!
--=20
Jeff Layton <jlayton@kernel.org>