Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Olga Kornievskaia <aglo@umich.edu>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH] NFSD: pass range end to vfs_fsync_range() instead of
 count
Thread-Topic: [PATCH] NFSD: pass range end to vfs_fsync_range() instead of
 count
Thread-Index: AQHY+dA99BTueKkoaUW8ZOhqLPsIj65BriOAgAA28gCAAALlAA==
Date:   Wed, 16 Nov 2022 19:01:16 +0000
Message-ID: <F8A4FD38-41F4-4B03-99D9-7043CD3977FF@oracle.com>
References: <20221116152836.3071683-1-bfoster@redhat.com>
 <87A52A9B-83F7-4FE6-8ED1-E710BAFF84B5@oracle.com>
 <5163ae19-b78b-d047-f700-93b3ad651eea@oracle.com>
In-Reply-To: <5163ae19-b78b-d047-f700-93b3ad651eea@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KUmZ6HmnuP/1vpBolONQiJjoagwWrRhBqHmcDr6okGoXFQJjrWHak6RP3abm?=
 =?us-ascii?Q?sfNxE3oH1Ese/v5PlHmkbO48ZkZIKRUD+imquG9IQpnpeShX12Ij1FGLO/g7?=
 =?us-ascii?Q?wwJ5bsOcLx7TUwANkfCjIFvrs/Aao8QBPZAfMliM/RLJ0gcQtL0QTzlLSPSs?=
 =?us-ascii?Q?UvHHkII7AA0a6zdmb9dlJtQdbxYW6NTt+PMHPBG8qelT8I/296ogcQMs9a5I?=
 =?us-ascii?Q?p425hFmtKNtu9YGvm90fN67mhb9ClAwpNWhoYF7J8EupRhG5/VpTXsqkGy/O?=
 =?us-ascii?Q?VOSwXAGPoLC6EJ78ueWuky4Z9PqHyavqRjCyQ8f/JBVhX5Gn2CvcbpGmm3tw?=
 =?us-ascii?Q?oWjZ2aFiWOkR52O32PhQRz8vUKq36lHb2oU6QeQXbFFv1YCp/Jj+2ewbnfwQ?=
 =?us-ascii?Q?ijGyqLvTXooROEq+wBZ7FY9y5YdwPLyReavuLh17quYcrrZHWUK05bgKl2vx?=
 =?us-ascii?Q?IjFIurmOIdGEdPl+cYvxeV7P779P7Ycu4TKBIcejRfqvOwziYugkTzJhSaMb?=
 =?us-ascii?Q?47wXMnthAREHRtcUfKW8kZYIEppRZ4LKMruhSltRhwAbNVx8LShuatMxbX+a?=
 =?us-ascii?Q?fTePKiZihQjur7uwndRef5sV9hYxtzeXmCvO+ALgvl+ul699JpsX6+cvyTmR?=
 =?us-ascii?Q?zgcKFOku72Fo/mW+aaPpAqX+FTzOM+v1MSbpYEsPOfOdrzf+8R/k7r/qAvjJ?=
 =?us-ascii?Q?xW/tu5yBIUFmj1Y7E3VWoDk9ELMulGzUffQbqPlZ9UDhaOCq+/3o38K0DHvw?=
 =?us-ascii?Q?e0mUNLYWn66amjPEe7/g84yqXC+XmfV+rBwrn4ahJhPsfUa/XHEuw/C6l39f?=
 =?us-ascii?Q?HgqZSMDbnYYc0/0qI8M/vAU9rW/stE9+pHt0wTumi+dbiLjwP7CuVWBlBQjO?=
 =?us-ascii?Q?mzJwvKjNmNRrbjaCG0NGOmUdbjz9CM3i/oxdsLAtRFVaLyilZMM+XZkZR9E7?=
 =?us-ascii?Q?Z1du/20gcqe/4WKfZaB8KrGM4hm2DlNoF8Zm7NcR7N0UOFc+NB52OysGv9SZ?=
 =?us-ascii?Q?i6AothdN8t3v4tng/NNo5AmazWlQKsiWEx0lTom8C5xZGsZy931o4CudRRXB?=
 =?us-ascii?Q?TEnKDxlEaOSVNMnIyQdS0D5bvvpy8JyIJy4Mq44mM6JCF1MMjxDeRtO9EF9z?=
 =?us-ascii?Q?/IjT3w3u/y6Zu3jt4jxiLcyNDK5SblZycX9MVV3MyEy+v2LBIbFdAjH9yOJ7?=
 =?us-ascii?Q?1IboK1hffvbS4P/U2ZwrNiN5GceVwP08sDvHbou8Q6qFozP5A91ipOPQvmPg?=
 =?us-ascii?Q?cSRbMr1wcYbOZPbuoiq7sS68HxKvRfoLvdOjpSCOVc+uwsZUqC7IvF4GVpv5?=
 =?us-ascii?Q?Lc/LfSYw/Q1PPIY/m1HuUaBAqIgjQ2suZNn4EM19dSk2rHnrZEYixR+6Q16A?=
 =?us-ascii?Q?kgtd0T9g8g0WvRXxMpCjOKKFdnnsDFH5eDNQNHEU9mq+gnkGYKe3+12kXocY?=
 =?us-ascii?Q?JNgOYRvFe+KswURf6zydEbrk6ScltQoOBFFD5fcshYwsT4a/9c2gIc0juC34?=
 =?us-ascii?Q?IzdLukrLVfps+NCqCT8gaV9hZymNxNcXZ2qhlgaHoIqgzo38vth4Pf5oJdw+?=
 =?us-ascii?Q?EaUfEg39LpNGwXZYYQi+dYWY7HOb/Lnjrz46wb+D/uYG8UjCGWwW1FJv9yHT?=
 =?us-ascii?Q?GQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <52CC496E73C1744D80E439791A7EFA30@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 87b88tRZzUQlv8m2NbKqzRLE8KreRSbLTNA4LJRdrvRvIokwxAZAAbaDH0pFdIvpt9iyv2mHV4/re1Ati+EKxIsf1zcn4+Swg/ASmbEB1Q4FfLhucAEju4ZyaAbXb5IIiZqkTwqRev8TFpuaGXF0W3PuTVda1/3f9ZmRRmNoIIKiofikBRomR4L4gKlaTVOd9AHGJVQXWeECK2KWJURZ4O4yRAcoPHuq7eyNilGQsA3Zzt8eNt6PH/qZ3lC8GWzQmFnjf6eHY9WgAWn+cjlZFOYO/b+kZdFDOVBO6JtY8FQ4Sug779ijcvNJfunOErGBv5/eqeSNSMKOIfSPW6ly4MyT48OKArgEMSRfkTIBWMjgCCvfWpJ/AwNLV1cCF5OjBstNGIH0HdX7FBRd4AI+/1DOz/1E25y9dDm2RrCI0qH9mSoO8ulbt8x/JA8sYRz1AqIFR9klCGBpLdNAsY607L0pZDw1I6+s/mQ1U3aJg/8ZxGSZca1Mvg8aiR+yALEvKqIQwjuzeqc0TSu/15TrwQyXFsC+r+hZtuSyOLkn2wEQjFQ/Pk5hO919MJJ1DEz6HcM/Qr552EOc4UmvcmpmAQXoeVlKsZt4cDneQJi85edMNF2pMJeVfcb33kC5v0+4b/aaBeA023T6xgQe/AyYDDWTCtU6setcJQOSfOay3rG03bPJxcSG6xrHJf/7Ako1oxqlx2FF4k1QSSZUtknsCC0jVdFGLaFumRxxXLO8rxjqKSMv+5DEtG9jPmbE/Abnym9Xv7JySCYVfiZ7xuEC9d3CEWQTcxuDa8MJ6XAObbVsdx734nBK71GyCZtpFC2F
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: faed2fc1-8e74-47f5-04fb-08dac804f090
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2022 19:01:16.7272
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DC6ByW/OFdLANJ+evfV/jOqwskvnCzHTo5b/7nfxl4GkF2zWUe5JL6LPtAh80YNh2W4FHjvYTXHM6TwVvFeo/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6163
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 adultscore=0
 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211160131
X-Proofpoint-GUID: ufr48iD5Nb9ZrGsU6tWTUEoz1YqpTF2-
X-Proofpoint-ORIG-GUID: ufr48iD5Nb9ZrGsU6tWTUEoz1YqpTF2-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 16, 2022, at 1:50 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
>=20
> On 11/16/22 7:34 AM, Chuck Lever III wrote:
>>=20
>>> On Nov 16, 2022, at 10:28 AM, Brian Foster <bfoster@redhat.com> wrote:
>>>=20
>>> _nfsd_copy_file_range() calls vfs_fsync_range() with an offset and
>>> count (bytes written), but the former wants the start and end bytes
>>> of the range to sync. Fix it up.
>>>=20
>>> Fixes: eac0b17a77fb ("NFSD add vfs_fsync after async copy is done")
>>> Signed-off-by: Brian Foster <bfoster@redhat.com>
>>> ---
>>>=20
>>> Hi all,
>>>=20
>>> This is just a quick drive-by patch from scanning through various flush
>>> callers for something unrelated. It looked like this instance passes a
>>> count instead of the end offset and it was easy enough to throw up a
>>> patch. Compile tested only, feel free to toss it if I've just missed
>>> something, etc. etc.
>> Dai, Olga, can you review this, and one of you test it?
>=20
> LGTM, tested ok.

May I add Tested-by: Dai Ngo <dai.ngo@oracle.com> ?


> -Dai
>=20
>>=20
>>=20
>>> Brian
>>>=20
>>> fs/nfsd/nfs4proc.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>=20
>>> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
>>> index 8beb2bc4c328..3c67d4cb1eba 100644
>>> --- a/fs/nfsd/nfs4proc.c
>>> +++ b/fs/nfsd/nfs4proc.c
>>> @@ -1644,6 +1644,7 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4=
_copy *copy,
>>> 	u64 src_pos =3D copy->cp_src_pos;
>>> 	u64 dst_pos =3D copy->cp_dst_pos;
>>> 	int status;
>>> +	loff_t end;
>>>=20
>>> 	/* See RFC 7862 p.67: */
>>> 	if (bytes_total =3D=3D 0)
>>> @@ -1663,8 +1664,8 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4=
_copy *copy,
>>> 	/* for a non-zero asynchronous copy do a commit of data */
>>> 	if (nfsd4_copy_is_async(copy) && copy->cp_res.wr_bytes_written > 0) {
>>> 		since =3D READ_ONCE(dst->f_wb_err);
>>> -		status =3D vfs_fsync_range(dst, copy->cp_dst_pos,
>>> -					 copy->cp_res.wr_bytes_written, 0);
>>> +		end =3D copy->cp_dst_pos + copy->cp_res.wr_bytes_written - 1;
>>> +		status =3D vfs_fsync_range(dst, copy->cp_dst_pos, end, 0);
>>> 		if (!status)
>>> 			status =3D filemap_check_wb_err(dst->f_mapping, since);
>>> 		if (!status)
>>> --=20
>>> 2.37.3
>>>=20
>> --
>> Chuck Lever

--
Chuck Lever