Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8e055819-9f3b-e751-99ab-85682c28081b@oracle.com>
Date:   Wed, 16 Nov 2022 11:08:19 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.4.2
Subject: Re: [PATCH] NFSD: pass range end to vfs_fsync_range() instead of
 count
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Olga Kornievskaia <aglo@umich.edu>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Brian Foster <bfoster@redhat.com>
References: <20221116152836.3071683-1-bfoster@redhat.com>
 <87A52A9B-83F7-4FE6-8ED1-E710BAFF84B5@oracle.com>
 <5163ae19-b78b-d047-f700-93b3ad651eea@oracle.com>
 <F8A4FD38-41F4-4B03-99D9-7043CD3977FF@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <F8A4FD38-41F4-4B03-99D9-7043CD3977FF@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ulp0b1lBaFVPMEVRQW11RDYyakwzSlM3S2lZeElHQ3RyanRUOEs1eFY4anFO?=
 =?utf-8?B?dkxRaUZkMXFYK0NvbkU3OGlwNzgwK2I0RUIzcGYvaUtsN1dHbS9tdW5USXBS?=
 =?utf-8?B?QjNKRHlOa1dOMWZWQis0Rk5lWTBwZ3Rmbm1lK0xxUUNnNDNaRXByVC92KzQ4?=
 =?utf-8?B?NFBxV1VkeWdSc2tNQlhkVGFTUVFZUjNCK1FEc0dEcWVMM0VqT0ZGM0dnU0Nz?=
 =?utf-8?B?NGlTbXh2UWxHWGxXRU1YNGxvSjdVRkFrM1NVcFVDbDBEaXA0NDhTZkVTQzZE?=
 =?utf-8?B?em1qbDZDdnBIUnVhZUg5UWlKOW9ZNG9QdnNOMnk1dENHblRTaThmdUJ0aUFB?=
 =?utf-8?B?VU1FRW5oZDNpeXNrajNvT3p0a3dxbEcyNUVSUXM3MHZNN0Q3dERHT2lDWVhG?=
 =?utf-8?B?MlVDNldwQ0tESElYMEpmZndvdUc4TGt3WTFwT21LZitLUWNuT21pcTArdkdi?=
 =?utf-8?B?K1VrWFVpZVJNdTJUcGRqT1c5Q0R2azNsUHpwdm80bjlNWEZOMXFhbDJFQ3My?=
 =?utf-8?B?MVAzRFcrTlRDWEVpOWZtM28rczA0dnlOUE1ZVmM0L0k1RzhYNzRsZnpLaTI1?=
 =?utf-8?B?SnVPM3BVUVZxS1BxTFQrWGJtWWgrRmlzdmFrSVltcmFqUW5HeC85T3hYWXlr?=
 =?utf-8?B?RTFYcGZmU3MrOTVYRjcrODAxSXlqZzZKczVMSHQ0OGdLTG1JNm90S2NHNFhu?=
 =?utf-8?B?SEttRGQzVWQ2aERkZzhaeS9NU1I1c00vZE1qN1FMNGNrbFhpeCt5QTBVVVBU?=
 =?utf-8?B?SzN2M3V4ZXZPQ0tIaVZpSTBmeEVlWFBDbzhrQlgzUTgvN0txcTRZbDArR1cz?=
 =?utf-8?B?U2tLMTd4YVIwZmQ1QUY1cjFuMkRBbGpZZVRuVjBDWGlFcDNMWUVLcnlHSW9Y?=
 =?utf-8?B?YkpnU1UwbGNpNUFJSHUrVEVUVit3SDBmSk9RcEp6czlkcUg1RHgreTZwTDcr?=
 =?utf-8?B?U25mN3owRnYvWU5UVTc0UUpidjZMbUVzeDBDdGFVSGZSdjV0TjRyTGY3M1Uv?=
 =?utf-8?B?Z0lzdHlzVDRRR0ZBdGYzbGhEMUIxeGRYU0hJazZERkpRVTdCSzJRQVRKQVJy?=
 =?utf-8?B?OFRYYThCT0dBOXJvaWlyVVFQWk5QNDZlOUZ1akJMdGd4M2ordVlwS08ybFNq?=
 =?utf-8?B?Q0JLT1Q2cjNJREJmNFFZcU9TbFVnNnM2YVNnSjk5WkFqa2RsUXJwcXdjV2NS?=
 =?utf-8?B?WmJHMlRJcnQ3Z0o4WXBkUVdYT296UUtuTVYzQ01lRmZQdUpHYitHUUhIa3Bj?=
 =?utf-8?B?aVhsaXlWTVAvWDd5TkhLSm9xSXVHZWcydEJBbFREWWJPM3VKa2ZveklKaWYw?=
 =?utf-8?B?ekRqSEJJNVdBaGdmU1JLVVF3TUV4clBqU1VzVDRxYno4aVgvQWtmNmwvaEw4?=
 =?utf-8?B?cTZSOHQ4NlRUclB3cS9GQ2tTY1lndysycGRXT1ZxNGhma05Pb3hhNkd2dVBV?=
 =?utf-8?B?Skdyb05NZ1BMMHNmNzg3RTlwb0w1b3JBZEo4ZktET2lpWll5Y0dtMTQ4VCtj?=
 =?utf-8?B?NVlYeStQVmRiaVpTelhPQktGTW1sSjh2Wm8zLzE3eElKMkkxNFByRStpYUhI?=
 =?utf-8?B?eVNtTm1PUkdZMTJMQjdVV3l4L3RjSE4rMTZTNU5RdjhsUzI0RERCSXFHSFA1?=
 =?utf-8?B?VEw5Z0lGeEsrU1d5eW1jZVVUZ0pZMExuN2JXdUU5UXRJKzA1alpzMGF6TDVT?=
 =?utf-8?B?M0luRExMZ212Zzh0U2pNMHBNc2p0LzlmK09xdW53UVRESVQ0dUZqcWhPdHFw?=
 =?utf-8?B?OHR0VWVKMFU1ZTFVMEFDdHFRY1MrT1ZrREQvWldLTTFxZFY1MjNITlNhYkRr?=
 =?utf-8?B?ZjBtMHhsd3JienFCdkRvSDBsQm5vNDEwa21RdWdGQWNGOVhJcXhqNU4zUUJz?=
 =?utf-8?B?ZkJrMmNRNk1xTnNVN2xyTmFIOFNVK2srVUdkWVR5RitiZHdUakl0VVhsWTF2?=
 =?utf-8?B?S0hiVWhkaHJNYnovRUl3MlVMTEtMUjBrTW9Ic0lCbWEwcmo0R3pxa2FlL2tQ?=
 =?utf-8?B?blBnRXpnUElsTHBtSzFKY0dBNmZ1ZHVQUHJXaHlvYjc3d2VVaC8zMnBEa2pp?=
 =?utf-8?B?RHBHb0o2UDJ2NGt2dnZmanFzeUgzRHloZlgzSWhvV2RibkNPUUk4OFQvWlJj?=
 =?utf-8?Q?t7nXISVJ8pVC3e3To6TMIQk16?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: QkXd9h8LgnTYkGMK6FBZHtOc3j4AsnJGBNoy0FcBg8rDyz70CuCeQhNk92D/0aORp4hW8HDWBbVuUi8HACy9Tk/irRp28JJ9SbP3371TtAlR5445KuXfoc+2YlViQQ3q8xw3d0c2otASyriA/olCJe1VYhlV96mjhwY9iw0nIYO6sU7j3GdxidLL6X+fkbbxRP7Ll/pWf+GCbfXKCwZy/fji5CYxvESO/36MZbGpDKtfjmjOGaJYynkY1AI2NsH4cntjQ2Vkl1hX0B15zqmeZPpgNZsaElvn8MvVXTpVi3hw11hD6m8DG1Lm0+m+kyVcW+T/l3O+30OLtBLzzoXLiNmsaRH673upiehaB6zJuqIKls+fOqcEjG2KEDwNDKHTSI99bDoT1MQHIADHz+y8CmbffDeBFWgJ27+tS0l+qjrJsjn8ZGkeQBLQGtrQJJIF/p2eWtmypSaBX0djh6bj/T/VVp1uQrXvbdm1hTpnprqGMsN7hGTUVjthmYdTYTXjn5c8PUvotNJtgT64srJyX2QMUYA1x/H3/ucXUx/0yKGmxkZXE1E16yLZB2v7tZeueNVzH6KeT9OJAfGYZ76CXCekBQ7096iC3zMMqQHeUjT5oW3V4VAn2QsWZQEYDfR06FnyeY6CrHMglW2lRFC+SUQFKWV/NLRLPZip/hq0//iQlH5GgbwQCjZ1fsp7j9g6kBZy8npdeDc5+8tuFaxNXz4H0COQwnKzPG5839O4MbxbaKtJI8xYli1RSM5H16L26Hc9MoXfIXpxUw8QXfI4EAm25RMhf1wG/4EFV0VhtUyAwP3XZXn53bXoNqsdzJlo
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6993f3f6-8a79-466e-112b-08dac805ee36
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2022 19:08:22.5133
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yq595uLPCBHSCklUiiZ6rYLWrHNStj/wtlAzpOZecO5Hdc00/vPaWCMTnOR708vr4Z5BTKlFS2iLHlklFKawXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4465
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-16_03,2022-11-16_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 adultscore=0
 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211160132
X-Proofpoint-GUID: W0Mn6KWdiBCujQetv97W9TA37paWDCq9
X-Proofpoint-ORIG-GUID: W0Mn6KWdiBCujQetv97W9TA37paWDCq9
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 11/16/22 11:01 AM, Chuck Lever III wrote:
>
>> On Nov 16, 2022, at 1:50 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>
>>
>> On 11/16/22 7:34 AM, Chuck Lever III wrote:
>>>> On Nov 16, 2022, at 10:28 AM, Brian Foster <bfoster@redhat.com> wrote:
>>>>
>>>> _nfsd_copy_file_range() calls vfs_fsync_range() with an offset and
>>>> count (bytes written), but the former wants the start and end bytes
>>>> of the range to sync. Fix it up.
>>>>
>>>> Fixes: eac0b17a77fb ("NFSD add vfs_fsync after async copy is done")
>>>> Signed-off-by: Brian Foster <bfoster@redhat.com>
>>>> ---
>>>>
>>>> Hi all,
>>>>
>>>> This is just a quick drive-by patch from scanning through various flush
>>>> callers for something unrelated. It looked like this instance passes a
>>>> count instead of the end offset and it was easy enough to throw up a
>>>> patch. Compile tested only, feel free to toss it if I've just missed
>>>> something, etc. etc.
>>> Dai, Olga, can you review this, and one of you test it?
>> LGTM, tested ok.
> May I add Tested-by: Dai Ngo <dai.ngo@oracle.com> ?

Yes,

Thanks,
-Dai

>
>
>> -Dai
>>
>>>
>>>> Brian
>>>>
>>>> fs/nfsd/nfs4proc.c | 5 +++--
>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
>>>> index 8beb2bc4c328..3c67d4cb1eba 100644
>>>> --- a/fs/nfsd/nfs4proc.c
>>>> +++ b/fs/nfsd/nfs4proc.c
>>>> @@ -1644,6 +1644,7 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy,
>>>> 	u64 src_pos = copy->cp_src_pos;
>>>> 	u64 dst_pos = copy->cp_dst_pos;
>>>> 	int status;
>>>> +	loff_t end;
>>>>
>>>> 	/* See RFC 7862 p.67: */
>>>> 	if (bytes_total == 0)
>>>> @@ -1663,8 +1664,8 @@ static ssize_t _nfsd_copy_file_range(struct nfsd4_copy *copy,
>>>> 	/* for a non-zero asynchronous copy do a commit of data */
>>>> 	if (nfsd4_copy_is_async(copy) && copy->cp_res.wr_bytes_written > 0) {
>>>> 		since = READ_ONCE(dst->f_wb_err);
>>>> -		status = vfs_fsync_range(dst, copy->cp_dst_pos,
>>>> -					 copy->cp_res.wr_bytes_written, 0);
>>>> +		end = copy->cp_dst_pos + copy->cp_res.wr_bytes_written - 1;
>>>> +		status = vfs_fsync_range(dst, copy->cp_dst_pos, end, 0);
>>>> 		if (!status)
>>>> 			status = filemap_check_wb_err(dst->f_mapping, since);
>>>> 		if (!status)
>>>> -- 
>>>> 2.37.3
>>>>
>>> --
>>> Chuck Lever
> --
> Chuck Lever
>
>
>