Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     "jlayton@kernel.org" <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v5 0/4] add support for CB_RECALL_ANY and the delegation
 reaper
Thread-Topic: [PATCH v5 0/4] add support for CB_RECALL_ANY and the delegation
 reaper
Thread-Index: AQHY+jb3b6PpTwE2G0+HfmxJhBZEiK5DMdoA
Date:   Thu, 17 Nov 2022 14:44:49 +0000
Message-ID: <8517F18C-9207-4DE4-A217-2A0EA4C4484C@oracle.com>
References: <1668656688-22507-1-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1668656688-22507-1-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9lxrMAOtr0evpyB4x68y6sFSt489m8WRtUW8BqOUQ4hwTRX8I5PWABfHzw61?=
 =?us-ascii?Q?j0UA1ZD+4HCd5ahVbj9cOdn4gdUPV9KxWJ8JeuNQ6E0UMBKVOKpgVy/6VqEX?=
 =?us-ascii?Q?em6k1AVGhxtL2yCSNVMptL54QloMRJW9WUArhvC26FbvXWVORFn/p5G1Qpea?=
 =?us-ascii?Q?ZZqiH1SwkI9eoTWkDYbyvReSETgSiMfpgzstaXQb93vSXoUPTZKy7CMyTj/d?=
 =?us-ascii?Q?C7YM4ol5YbhHUg8UNaayy/aQqUUoU3fMTbEP1rNfgB0dVVApwcPGxfnp5vvI?=
 =?us-ascii?Q?m4cm9GAQL1+kuucrbNSrbPB1JBIHeAwnmTYg54yTSSudE6RaucjQhmH6fAmW?=
 =?us-ascii?Q?RCzUtfo9Wz3Xm6kXACFRwpTtYkJCUQRwhaWodES4rvOyoB9c9eJSIWBZT36B?=
 =?us-ascii?Q?vtbClvj1MwpbJ2WRztpLz2kHOJb8jVFV8JHw3KngVaYWvEZp+/smaQYzR2lv?=
 =?us-ascii?Q?VKovlebC487KmCsm7FLeo3Mj4IE7UjmcokZTFGuX5+y2ubyWYNXM9NWfV0+x?=
 =?us-ascii?Q?IARiBKofziYpC/6MMYngpB/tSEPkXlNRJS0xsytFLhdl68VSZgIrPiqBE+6l?=
 =?us-ascii?Q?UqeqyrA+ng8BT0SdNc5poIVCXW8TrKl0SYhWFHJiV4CDq+9h2apY5KEDmcZW?=
 =?us-ascii?Q?6fz2KHNMKGXMRVTCXrDdbA1c07wYFH6z6h7pMzYMrezlcwyTmAOF4OCmDimR?=
 =?us-ascii?Q?/sd3INZ0PWZxE0Ve+TKcChIoX+jngjR0AcbAo+A0Nb47bocydZH/DbgCis16?=
 =?us-ascii?Q?+NjRSMcdGk2Hg+A/Cd+JC5bLHl/RuzYAtkZoRDARM6Kue9TF9QHBWPK5ZrOX?=
 =?us-ascii?Q?d3In8SuPhCpH6sq0on2Nf/fwwYTMTpD8D2vNsSbFF3fZDDD1DOcNbqJbnk3B?=
 =?us-ascii?Q?0l/L2muW5j0j6aEIhG7Il8lYlS17ufqTIuqE9UVFVhQfvoFCVrIki4c+FpUv?=
 =?us-ascii?Q?0R4PDPiB86uplvVkyV5zYuaYCWE8i9f9VT3uJhegR0F4XdVhttiCt85/lHUj?=
 =?us-ascii?Q?Vux3rCbJX2tAXHKWbqmLZiSfbSFC9LOX0NZflsyHE9Ba86QvZ9veYQcvQT7Z?=
 =?us-ascii?Q?beRI6z1EztsTUJl1og7sDFOeb70/GQfVPLjpbKlOSjqnPYLf+W53oNvsDCuK?=
 =?us-ascii?Q?swDrzCJQzYF4JCiapZ7WPRt4gxqphdIU71K/tp6rWsSadB8tGBcRPXhrBQSr?=
 =?us-ascii?Q?JrLJlaTZBXE97laVHHsGLVtKnjxfC+AWvDYP3ynoE5/o0E3RVbxpP+y0YYEM?=
 =?us-ascii?Q?NF7CMCJaSc6dYMtJGCuoFk2mRw/mb07WRUExnFZT7bc7HnUnxw4OEXxicXPf?=
 =?us-ascii?Q?c+gx0LvVR89upOM4cHidi4RFY5MIAfdOfk9HQ55dCf+mSqKy1Xn4DENPRIGI?=
 =?us-ascii?Q?+ZuizgkQWBQcJFUe/1MNLYB/p4auZN7uKiv7lFDy/vZGSgUl8ZCIUtAQX4Ls?=
 =?us-ascii?Q?gM/NnlxAAWDZd0f8Vxv4G4jkcwFZ9NAw/wQ/yXf1uMjBJtitR90jTirUU/Bw?=
 =?us-ascii?Q?hjWWfhh2xzuWWVJGyjhqEtL92RCN1u8TGszUX7ajJM82tNKBLt4x3UsXh8Jz?=
 =?us-ascii?Q?/bxX01/VHCqx4Ub7ZbhGILe1SoO5puYePASU1XnWImj6spwFggvOAztIAots?=
 =?us-ascii?Q?sQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A6321631B62B0C4AAEF619B9B073D2B2@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: zr/4fECuXKyM1iRqED3hdG1gTcrl4x8LtGOD1LVjrreuOHCf5x9FVE4nCpnvVXvTQ8yTYjNtviNR3w3Culbm7P1QILngixpfCc5pm3ktyjmRb8NHp7LYmByh084K1317S283iYX79D458SuQChTe5SQQBpd1zNhJpw/uAO+KwJ2hdHjr9qYdlSk3ZC3yoZDOW5c/lj5MFWpDJOitt+MP0IlMp33ln2F4l/M93yl1S5psMC/GEKUTYTuRfipaJpRIclTqTLB3tWeM7qIRKNFb8JfdJrGK3nZ4WAWF4XO91CM7ryTdqD83rQ5G/qLGPGuuDBdOpdxX679nPafE1/10vt7P4NYyK1k2fIaBhLWt5T1hc10S8szt0n7e8nvOeWpyX0RbhuczYwuMSSoNjPNv7wSRTMCWzVcKddiFhBOAddfnzzmCq08w2FOlRELmhq8M7Qz93t8nRA/msf31nx55rkOng9ckJnc60evOrCZ27uL22j8OFqNuUat73lIrBci/JCKgZJ1FnUnA03Lf482HFPqyNmw67RyGX+XxFlHgAh2Pk4GFwJYQ93Wtx9YfZ2QkneqiO+Pwgt1rquqmh6SOnjHHLdsDEsjY5FgacbEnfz1Qd9Kj4Rvvlj71+7i8A3OAz0/gO9OKW8R40sDK6lGQ8g4eiDu8S6oW+8ovtgxz2xEfhHs97cC7wIDdkIumRlJ0GfSvg7pKV2hIu0vpBLaXVRcryxZt/ZUEsmB7KWe1+bXhlyBlH1JIBXZ4SN/2+LHjak+hTMMGlcgvIsoXj8egq8TCZyXlMkHK9XGn3ZwnNnM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a626201-412f-43b9-fdc4-08dac8aa4766
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 14:44:49.4117
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 75zuWqp+NcDoPclyKTS0dd4D6r/yFb3Hdt36vHA60Shf5/QiooTGn8Eq5gYmIi8w2AheOguuVhPKu7pFwP3VDw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR10MB4426
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_06,2022-11-17_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 adultscore=0
 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211170111
X-Proofpoint-GUID: KiXFjDZVmzKAbpPqUTjE3DDlK2yjGvuR
X-Proofpoint-ORIG-GUID: KiXFjDZVmzKAbpPqUTjE3DDlK2yjGvuR
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 16, 2022, at 10:44 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> This patch series adds:
>=20
>    . refactor courtesy_client_reaper to a generic low memory
>      shrinker.
>=20
>    . XDR encode and decode function for CB_RECALL_ANY op.
>=20
>    . the delegation reaper that sends the advisory CB_RECALL_ANY=20
>      to the clients to release unused delegations.
>      There is only one nfsd4_callback added for each nfs4_cleint.
>      Access to it must be serialized via the client flag
>      NFSD4_CLIENT_CB_RECALL_ANY.
>=20
>    . Add CB_RECALL_ANY tracepoints.
>=20
> v2:
>    . modify deleg_reaper to check and send CB_RECALL_ANY to client
>      only once per 5 secs.
> v3:
>    . modify nfsd4_cb_recall_any_release to use nn->client_lock to
>      protect cl_recall_any_busy and call put_client_renew_locked
>      to decrement cl_rpc_users.
>=20
> v4:
>    . move changes in nfs4state.c from patch (1/2) to patch(2/2).
>    . use xdr_stream_encode_u32 and xdr_stream_encode_uint32_array
>      to encode CB_RECALL_ANY arguments.
>    . add struct nfsd4_cb_recall_any with embedded nfs4_callback
>      and params for CB_RECALL_ANY op.
>    . replace cl_recall_any_busy boolean with client flag
>      NFSD4_CLIENT_CB_RECALL_ANY=20
>    . add tracepoints for CB_RECALL_ANY
>=20
> v5:
>    . refactor courtesy_client_reaper to a generic low memory
>      shrinker
>    . merge courtesy client shrinker and delegtion shrinker into
>      one.
>    . reposition nfsd_cb_recall_any and nfsd_cb_recall_any_done
>      in nfsd/trace.h
>    . use __get_sockaddr to display server IP address in
>      tracepoints.
>    . modify encode_cb_recallany4args to replace sizeof with
>      ARRAY_SIZE.

Hi-

I'm going to apply this version of the series with some minor
changes. I'll reply to the individual patches where we can
discuss those.


> ---
>=20
> Dai Ngo (4):
>     NFSD: refactoring courtesy_client_reaper to a generic low memory shri=
nker
>     NFSD: add support for sending CB_RECALL_ANY
>     NFSD: add delegation shrinker to react to low memory condition
>     NFSD: add CB_RECALL_ANY tracepoints
>=20
> fs/nfsd/nfs4callback.c |  62 +++++++++++++++++++++++
> fs/nfsd/nfs4state.c    | 116 +++++++++++++++++++++++++++++++++++++++-----
> fs/nfsd/state.h        |   9 ++++
> fs/nfsd/trace.h        |  49 +++++++++++++++++++
> fs/nfsd/xdr4.h         |   5 ++
> fs/nfsd/xdr4cb.h       |   6 +++
> 6 files changed, 234 insertions(+), 13 deletions(-)

--
Chuck Lever