Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     "jlayton@kernel.org" <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v5 0/4] add support for CB_RECALL_ANY and the delegation
 reaper
Thread-Topic: [PATCH v5 0/4] add support for CB_RECALL_ANY and the delegation
 reaper
Thread-Index: AQHY+jb3b6PpTwE2G0+HfmxJhBZEiK5DMdoAgAAj2wCAAAMyAA==
Date:   Thu, 17 Nov 2022 17:04:35 +0000
Message-ID: <A5796183-BE7E-4B05-A620-4BC76A2608D1@oracle.com>
References: <1668656688-22507-1-git-send-email-dai.ngo@oracle.com>
 <8517F18C-9207-4DE4-A217-2A0EA4C4484C@oracle.com>
 <7ee9c36b-b3d8-bb84-36bb-393eaa2369f2@oracle.com>
In-Reply-To: <7ee9c36b-b3d8-bb84-36bb-393eaa2369f2@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1VwBI2L9GSlAdwe/H3D//4Gk7XRg+KzldhfR+e2PLEndcJ08zRNs3Kd6vP9m?=
 =?us-ascii?Q?kEeoPj6FyHY8qv554YWRi150gGKuk2CgawzJdv4dAW7V4N1JGlkShW2zNQO4?=
 =?us-ascii?Q?JSkFijW5N1DdvknF996k3pbKsEwd56cHyvtSJaKBw3W3Vqv5DBSDwYfyNXSQ?=
 =?us-ascii?Q?fnD0ji73WSD4g12SbMCp6UyPXfDAkd365N6ki0SRrgm3lIb5YJodWIOeF1gJ?=
 =?us-ascii?Q?tFMPHl+461kHhJF8KuYpy+P5oVhm+0oHT06QRSpwAKMOs+cAI4kSoJPlwHxY?=
 =?us-ascii?Q?Mxm7byNa37i8NbXpXR0qikklA/eV+DiXRapqDVqwyKf1guTbdZG8GRk1pj4Q?=
 =?us-ascii?Q?ypQQ31gE/MHf5pgPf/xqvARpaz2060lPR/i0Mhqoc8Z+kDGCC4EqvihvwNaV?=
 =?us-ascii?Q?wtiwfbbV+oq7SBas67a8Ww3DLCpDLAi3cvS7pcwQHKrKVXsGE4ZXznSQuoGa?=
 =?us-ascii?Q?+ZOyrskDyvDOaFfIJd/YEPtpsgkQBxgMLz6cVXN7aapNP9f7GcKn59zpgyVh?=
 =?us-ascii?Q?DkdiatoDAZZ41MrH+clommCq/4F5u4OqjfugCh1LP9m1ZY+syQnkd0IUcCan?=
 =?us-ascii?Q?T0fEKXb4GJr5GXeWcgZ8Le5qd+bHV4gcLt0fnagt3YUheqZ5FBX154bY4Iv0?=
 =?us-ascii?Q?iCLGaOew6ExLts+hV6AxyUd//q0DkA4GTllaS2V7jNnxLpwhKzj73X+xjx+F?=
 =?us-ascii?Q?pvKv51Nka+/o8TWwvdY4fONhqL+hzcIvNGPeopRateJvse7eY/hJKQRWvpWK?=
 =?us-ascii?Q?cWUR2wihiyrJFn1CqkGgafn7IJ6GsCb2sY6M8Uwrmjj0R1FZPicaywi+ZJHa?=
 =?us-ascii?Q?y8uHzaR9B98AZsQT1g2oTInK/Ka7xlq5FS5/IAT2dloSkjGGZq1/PQh3pw8U?=
 =?us-ascii?Q?D/IhClfzH7Cdy3FrGORaqEcm3WdPRMX1gWB+d+qygSnMkUtn7AzEjUGved4B?=
 =?us-ascii?Q?Ba/P4nUgdMLsg+gZdgR3HZgVSJnW20vaVRHqT68I7OKapxNX1E5zTVcKCooZ?=
 =?us-ascii?Q?3wPHypBs82sEappQOa3QJly1btW3CjDDVU+xt8EYvRbt7vYcjFQK3RD67yff?=
 =?us-ascii?Q?gLYCo55+jWKwd5pJ3NFoEXwNbyZ9sDz3RcC8zaK6aCdKtiW1gg8hV6So3DLt?=
 =?us-ascii?Q?867zOHBn4yYp4to/JQ35ckSMO0j8ndz6ZxI5rVEaLt2FXopxsbXgj3lgaOAD?=
 =?us-ascii?Q?MAKGvTJJa6gyvGY7rOs4+/WZR2fye3d1MCGtIpLuhA9U4QqQyCN8eJXODxRa?=
 =?us-ascii?Q?3iyZW7mhTB236HAOybBFIrs4fN74eMfB40HbXKyObrxU1oGmiwmdeV/0bfDd?=
 =?us-ascii?Q?sygzfChPAYU4UALG5p1pJMeHMctWVv4DmNKyOzZefzDRsDh9SyLsNNNfwrDj?=
 =?us-ascii?Q?89SSkjGQZTWJycLRA6YTH4pA09DnqsLhQfokTu68agTvtOANwungabCCgC9r?=
 =?us-ascii?Q?agfUVgM+f3gQbtgEBj3MJVM16jd1L+ZJxynfi4css5LPncSxSW6FK3TNUD8F?=
 =?us-ascii?Q?pQWckxf184sZZDmOrjEdV6jbZ5PuSkyDIUSJ5OCZc7QO+ECC1AldpFPV4ZSR?=
 =?us-ascii?Q?6pO8oOqRNevJd+8GRK/qvDhQFxtKZppbHDaWswlYpzHamT/4HHfznoAYWMfP?=
 =?us-ascii?Q?qQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7672F8A6AEC0F04782EDE9A61DCFCFAB@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: gALaPiYw8/MMynSIqW/oTZbYp6GTzKp6p3/GdwC+7OcfhZWFUICNfImKfwJwn2v13nKRlEJ1ndfcIdHbVNk8B7xDWCHvhuZNPYBmMEo5flCvFStBQYR4DB6KgzDZmD0VAwwya1PrCs/mPSPQv3f3aGSqRBOi8Qo+/YOoTX3LbdATscqsuEcyDjcjKM57pfpItp7106kGomxwe5fs9VAObCldl7gOuHx1FbpplPH0i+Q0rvAd4qmaKNA2oSq453Tu7PSwaPGl27TTCGbobxDP12BW/J/oZUI6YvymL52icjirBogAM1RRgdAFyW3Ywdh5791NCnTRn+74Ke3edh0HBtFyqsLFdWu1uhdKuhlYBwbUDC/BXPsN4srhRVJynFjFLASEG6TGc31s/3Snfxrgo0MAhEpr586ggBsEwc0YJc4Si/Ud/e65V3oNW1IQrfTlm5XvIfFz+AHBmt+jrBMCjVQvXJkehKXL3REbwBDIA3cPbjkgrCjviqEpMRzRW/p2JKBVHEFdQTguWdv8uB96hOzZt9VDQwyaelJBMaLqrwiBEAx9grDaS16yDenkKyAMd9h96NlY1Cs1ppss2OSIn2/GuVPZT0mXdzAZoR84qlfMK+NqK8mbIdhankstmCWCIQhY0EmyV3aKRMa5GIgX3X+FW4GkxkUAY6JHG/6IP9eX390QzymtqhGa+t258rWLAvAiGZwDhboKUoX4ATySTvgzU8aTLnAXOfa4hNUt4kmeghYmlDv5I/repfKfaj+l2nnvTO8ZWs7jUl38DFjULVDZ+5lba3DkE4k6H1GKBC4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f2517c5-886e-474c-55bf-08dac8bdcdc9
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2022 17:04:35.2775
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Kn91qyK/03gYQSN+14KEusB41t5/zuICirK6uPUlcW5vgeuc/5KiA7Bxkr+lQf0ycGl+A0XkD2/sNu+Z+bvw5A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB6809
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-17_06,2022-11-17_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 phishscore=0 mlxscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211170126
X-Proofpoint-ORIG-GUID: iQnvRuQsleJYS2Ebqh9MKcyQXfMHztqv
X-Proofpoint-GUID: iQnvRuQsleJYS2Ebqh9MKcyQXfMHztqv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 17, 2022, at 11:53 AM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
>=20
> On 11/17/22 6:44 AM, Chuck Lever III wrote:
>>=20
>>> On Nov 16, 2022, at 10:44 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>>=20
>>> This patch series adds:
>>>=20
>>>    . refactor courtesy_client_reaper to a generic low memory
>>>      shrinker.
>>>=20
>>>    . XDR encode and decode function for CB_RECALL_ANY op.
>>>=20
>>>    . the delegation reaper that sends the advisory CB_RECALL_ANY
>>>      to the clients to release unused delegations.
>>>      There is only one nfsd4_callback added for each nfs4_cleint.
>>>      Access to it must be serialized via the client flag
>>>      NFSD4_CLIENT_CB_RECALL_ANY.
>>>=20
>>>    . Add CB_RECALL_ANY tracepoints.
>>>=20
>>> v2:
>>>    . modify deleg_reaper to check and send CB_RECALL_ANY to client
>>>      only once per 5 secs.
>>> v3:
>>>    . modify nfsd4_cb_recall_any_release to use nn->client_lock to
>>>      protect cl_recall_any_busy and call put_client_renew_locked
>>>      to decrement cl_rpc_users.
>>>=20
>>> v4:
>>>    . move changes in nfs4state.c from patch (1/2) to patch(2/2).
>>>    . use xdr_stream_encode_u32 and xdr_stream_encode_uint32_array
>>>      to encode CB_RECALL_ANY arguments.
>>>    . add struct nfsd4_cb_recall_any with embedded nfs4_callback
>>>      and params for CB_RECALL_ANY op.
>>>    . replace cl_recall_any_busy boolean with client flag
>>>      NFSD4_CLIENT_CB_RECALL_ANY
>>>    . add tracepoints for CB_RECALL_ANY
>>>=20
>>> v5:
>>>    . refactor courtesy_client_reaper to a generic low memory
>>>      shrinker
>>>    . merge courtesy client shrinker and delegtion shrinker into
>>>      one.
>>>    . reposition nfsd_cb_recall_any and nfsd_cb_recall_any_done
>>>      in nfsd/trace.h
>>>    . use __get_sockaddr to display server IP address in
>>>      tracepoints.
>>>    . modify encode_cb_recallany4args to replace sizeof with
>>>      ARRAY_SIZE.
>> Hi-
>>=20
>> I'm going to apply this version of the series with some minor
>> changes. I'll reply to the individual patches where we can
>> discuss those.
>=20
> Thank you Chuck!

Changes folded in and pushed to nfsd's for-next. For the trace
point patch, I've rebased your series on top of the patch that
relocates include/trace/events/nfs.h so that the new
show_rca_mask() macro can go in the common nfs.h instead of
the NFSD-specific fs/nfsd/trace.h.

Feel free to pull and test to make sure I didn't do anything
bone-headed.


--
Chuck Lever