Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        "linux-hardening@vger.kernel.org" <linux-hardening@vger.kernel.org>,
        coverity-bot <keescook@chromium.org>
Subject: Re: Coverity: encode_cb_recallany4args(): Error handling issues
Thread-Topic: Coverity: encode_cb_recallany4args(): Error handling issues
Thread-Index: AQHY+29Ez3jSJACRC0y9Pul+LiiJ4K5E+L8A
Date:   Fri, 18 Nov 2022 18:01:41 +0000
Message-ID: <CCDFCD7E-8844-4F13-B160-E9867B3D8AC2@oracle.com>
References: <202211180900.6F94436@keescook>
In-Reply-To: <202211180900.6F94436@keescook>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?asABTlpjaG8qLuKuPRdbizTsiHcHreup1SP/dHrBk3AH6pfe5mzJtjVYZZTu?=
 =?us-ascii?Q?Xxn0ij1OweTW8AZsG0U62XrHpnRP6m95gmX76AVSTbeAPaa3dVR+cSNAneWC?=
 =?us-ascii?Q?LmSmb2GqN4QfhFhIydzY78WEzreXQrS8QxuVp66+xGp7H9EejLQeVLOOo+a9?=
 =?us-ascii?Q?TxMUUmdB4tNM3s59BibnmejVryFaWVT3QDrjmML5/jPlj2pDnmH9stydNY0s?=
 =?us-ascii?Q?dpy57Z6tzrztgpX73fOnnFjNNxsE72+C33T70s25uK9725DQ5A5oadwLfAYO?=
 =?us-ascii?Q?/MakNNw5rzHJiWZHAyzdqyiutU0K/oQF/gd8V3BRZEc7IsyFRytTro18kigo?=
 =?us-ascii?Q?z4nVEE59tkL1raOExNl2DceoAy4GbZsAtiAMkaCM+c6qdk1g2ssrwMchS+8O?=
 =?us-ascii?Q?JXVdTfmKkWKOtxPNSzStW4GQe9d/J7N86EPE6ew21lJVI4j7Git32pLCgJ6k?=
 =?us-ascii?Q?qmbnYKRoiAfJTEBQoGzpawbHhOZRfAPK88vNzrGC5W5Mmi2jC/zX9ckht4V7?=
 =?us-ascii?Q?FzxlkIS1Zs1g6/E7TVQFjAMLdlMj8jyuV/qlR2ZknLSnAn8sGRc/voDS30gr?=
 =?us-ascii?Q?VkLH0SJXRKH8wbIi3BkB573SgMIx/mg7tMsC0s6sisJYvlmQt0H3RxWsxrLV?=
 =?us-ascii?Q?SCyHLRKG+HcqRoLG9+8H7+cYWpuQKLbfHdTiAUOyMr/LnSIeysQ4/Ofdl9iD?=
 =?us-ascii?Q?1tMyCNvWHAuzJVAEbfsQGxpxCQqSB2F+Ib3WQ311DkjMiWQLR6XufdBlI/sg?=
 =?us-ascii?Q?aHqtKFym/ocLuYtYBV1TNF7d2KtLXHyhKZQhA/USSBdNjT9ZjCk06UsFgaUj?=
 =?us-ascii?Q?FLH93b084dPQuY93YX6iP0/teNtWLjjB7ameE3RYOLXQBWDKJf5jRq3IcSBd?=
 =?us-ascii?Q?WhM9/Ahsb3wLyV5AUkRex2NsrdGqPQO6bws2oF2HGyU6eMzZ5M51YunGEGT+?=
 =?us-ascii?Q?FX0v2OWS8roc6hW3Q7aHzQ3szaFXNrbqx+ACeV1pgZq8PXiJS3s6BZa5S0D+?=
 =?us-ascii?Q?yeCIGuVzWwWN7J3cLy+fq3GJOWG5lPWUTHouCtZQ+e0/g6s5B7RV71GTilDb?=
 =?us-ascii?Q?Hj2MBJ9uCeo8ZKtbpKK8i55Z9KUsahXH124D1LjtaDak/ZnEoJnc1WLz7qSt?=
 =?us-ascii?Q?F804cad4g7TGXPJy0+z1BxNe37s/Q2hPeNr1j6OVrTc/tWDp4o3kSbPI1kPT?=
 =?us-ascii?Q?BhIlrLW5IA1ysaOt8jFbMdgtRBGaaxTCV5gyxy2RQSUlqSK/qXJ1BndNShkH?=
 =?us-ascii?Q?QXUP6H0Hwbnwf4B72+VJg+1b2xVM4yLtasJAQiyY3dD6dzzfvKo3uWMNmW/4?=
 =?us-ascii?Q?OP/17odJ7rNZQ6RBfBOMXSW8AC8VRn90F9pI2ND+TzMtILtmb8Os3yPUDH8a?=
 =?us-ascii?Q?TPluziFdt2bHtO8uWwJOIWzPT0+/PFiqXTsMVOJi24H8ILmxL5eh6k8/RP74?=
 =?us-ascii?Q?ynNJTH5mjgXEEkSstocZhViaxkO9rZko5TPDnEypDBsk6PNdG9dO/rIy9dMl?=
 =?us-ascii?Q?6crhXyw2mFkhsZgrkhOnA1ngu52MY6mIJETlJr9mZNrOhOQLaRpsQlBMHoct?=
 =?us-ascii?Q?5YYOYfExqercXUDiVeo5vsOEJrSO63L8IZTHPFlslHKDkNZlky6y/SkNcpY/?=
 =?us-ascii?Q?qw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A9B8E2D466FE45459849905A83A567E1@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?Dw3tnGi6ufPdRa8E/nu9wy1BK7fEDlM8JDhelAbZq4YlXcZxAx1BooRHjjO2?=
 =?us-ascii?Q?yUe/cTfdmrXcw5lw2R6pcYFnl8oHBF5pByJg0N1UyTN8O1TqqDMU5vCB3aYd?=
 =?us-ascii?Q?SIw0/lg2NWjFBOmeKj+keasVDIRbyrKDoHT1czpnISWwc41dygt7UOnnnvYw?=
 =?us-ascii?Q?JnSodfJXWfMN0zj7y0EzQuMZQ94WQxN1WgI7+kiNzKsttBr9uvvrRZk8VR6/?=
 =?us-ascii?Q?AUkHTkhE/Yb3N3BaJMggvnOWxcLQ/oYdYSwmx83aHlnHG3hLSfain6GLgnmE?=
 =?us-ascii?Q?YLClFvd0kzEgoOv0kbvnv/b5VtMQbWFCazvvwBmROdxtElUbfUvYvyggoFFE?=
 =?us-ascii?Q?gTeMzxAT8TgvJHOG78d4mwz2vNGiBrDYIcbuAtqFY/zHPyV3oKIJKdS5vi2B?=
 =?us-ascii?Q?5A9VN5gQFvKM15f+lZpeTIJdyCXKQFpT4AX+ctD+6K9EsDd/lyLFblGAupPo?=
 =?us-ascii?Q?vA5orNy1YAJzLzFW/amD/K4z5ok/Pp333ZVaI8kAhJGqXYfeFL+6xm7JPqGc?=
 =?us-ascii?Q?/117gDtlzHFyXMEjU26mi6kvb1PZUa/VEt32TRbC7EDzjddzx35ePzrMLa0J?=
 =?us-ascii?Q?Yp1u9DU6ZbdNJRiz5WT/aBVoqdueayywNXhshFrhVN5TmBxR5YysyZ3CZyWa?=
 =?us-ascii?Q?/HWfo+MRjwgQGraAYTIM2toIp8GnDCltJ64VchN3f+bgY7eVpEHedtV/Ya8z?=
 =?us-ascii?Q?GZhiiURLDha7fORmoCdELUAyVdMsvguxWArLdBDmT0M7roCeuhj4isXsx07c?=
 =?us-ascii?Q?vs5vxqjZLin31V4GCA+CU7N5RmlQDOdmPEsHqrOhgOAf/ISRSpMLGkpzhISH?=
 =?us-ascii?Q?UNBTVUA9Wead9loaJIaa3fPXFVVB0zkzjdNBTGvallUjMn54bBNxjKsa0Vfh?=
 =?us-ascii?Q?hVqiqAAYPxazRFIn7gdVLX0OpkoaXcbnVgk6H3FBUHBaqvJmpQXwG/KXBlJY?=
 =?us-ascii?Q?Ipmo4rLPuzyitH9bBKld5gKa5IiKQhXB3mHARfu/qLwfR3Sc9CbAW13+sZ4x?=
 =?us-ascii?Q?mFUi?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d66c936-0a3c-433e-6b27-08dac98ef226
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Nov 2022 18:01:41.1333
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Djx+krVG8WZvPJKdqKK2WVVWKdby1jLVRPGyTdxLzwEVMVrgiMFBCI56cnjz3oqzdAJYPP1QW80ZmvfiMPIcgQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6643
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-11-18_06,2022-11-18_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 phishscore=0 suspectscore=0 spamscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2211180107
X-Proofpoint-GUID: yT5Ed33wUmyBeCwpofWIaYnLQ8fZwllZ
X-Proofpoint-ORIG-GUID: yT5Ed33wUmyBeCwpofWIaYnLQ8fZwllZ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Nov 18, 2022, at 12:00 PM, coverity-bot <keescook@chromium.org> wrote:
>=20
> Hello!
>=20
> This is an experimental semi-automated report about issues detected by
> Coverity from a scan of next-20221118 as part of the linux-next scan proj=
ect:
> https://scan.coverity.com/projects/linux-next-weekly-scan
>=20
> You're getting this email because you were associated with the identified
> lines of code (noted below) that were touched by commits:
>=20
>  Thu Nov 17 11:55:28 2022 -0500
>    32dce0f9611b ("NFSD: add support for sending CB_RECALL_ANY")
>=20
> Coverity reported the following:
>=20
> *** CID 1527365:  Error handling issues  (CHECKED_RETURN)
> fs/nfsd/nfs4callback.c:344 in encode_cb_recallany4args()
> 338      */
> 339     static void
> 340     encode_cb_recallany4args(struct xdr_stream *xdr,
> 341     	struct nfs4_cb_compound_hdr *hdr, struct nfsd4_cb_recall_any *ra=
)
> 342     {
> 343     	encode_nfs_cb_opnum4(xdr, OP_CB_RECALL_ANY);
> vvv     CID 1527365:  Error handling issues  (CHECKED_RETURN)
> vvv     Calling "xdr_stream_encode_u32" without checking return value (as=
 is done elsewhere 23 out of 24 times).
> 344     	xdr_stream_encode_u32(xdr, ra->ra_keep);
> 345     	xdr_stream_encode_uint32_array(xdr, ra->ra_bmval,
> 346     				       ARRAY_SIZE(ra->ra_bmval));
> 347     	hdr->nops++;
> 348     }
> 349
>=20
> If this is a false positive, please let us know so we can mark it as
> such, or teach the Coverity rules to be smarter. If not, please make
> sure fixes get into linux-next. :) For patches fixing this, please
> include these lines (but double-check the "Fixes" first):
>=20
> Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
> Addresses-Coverity-ID: 1527365 ("Error handling issues")
> Fixes: 32dce0f9611b ("NFSD: add support for sending CB_RECALL_ANY")
>=20
> Thanks for your attention!

My fault. I removed the WARN_ON_ONCE() wrappers, which are clutter
(though they are clutter that is already used elsewhere).

I will update linux-next with a fix.


--
Chuck Lever