Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3864879rwb;
        Mon, 21 Nov 2022 00:00:40 -0800 (PST)
X-Google-Smtp-Source: AA0mqf735ZBD/cD7A+OK+l/jELVLFSKqD3VqDZKdJS0nIyBLPT+uGu2E1ZuW2h1JWzUilnSyDAmv
X-Received: by 2002:aa7:c7d5:0:b0:44e:bee5:4242 with SMTP id o21-20020aa7c7d5000000b0044ebee54242mr1645230eds.128.1669017639772;
        Mon, 21 Nov 2022 00:00:39 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669017639; cv=none;
        d=google.com; s=arc-20160816;
        b=FFLXfpW2Aq2UMIrlqIub8uIluHE3qhsJfBqsAQk/HtXNSndHAoWoHnJmiuSk2KCXSy
         7qHG8lxbxl+JX2kFg5VEPcEC6Q21HNRJlvQJIwZw1ptZYkno2zlrwwxoCaqzyCf8YS/z
         w5vTZi1OU2nc57IeiXsO3CcGInDJWaXhtdkiGkfdY4EMn0zqxJBxNC1F0r3T+Nqn5UM0
         QZ+10LpQwxcGjwvYlNNRyVxcU3cJv7kpnblKUyu6M5+V2aMy005k13EEVnvQZCtlhXNt
         oPdq0+2CFveeClOccokeNNU5/Qyy2mSQyie6KS7B1caCwyQhrp5YhYlQ9kzw4kGYtON9
         p/Dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:user-agent:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date;
        bh=epTd5jMMpPQ3E7czo3hQO3SfTf/vqHGb8C+urqM6C2g=;
        b=f4+udn7ZbUMrWkAz+gnFU6Kdf7ZhL/paxpOJExR23b0ywIh3rE8xYfMJUzeWZLLZdP
         vg1/rD/7MJ3Z6odDspWAIUpUk+UfzOm31IhMKOqxxERxMT3dJf5GpzlY2h9mipxz4AQg
         fGW1izFRTC/QHP3molvD/Sp1iucNjM2hfvbkZiaDEgOI56LXNIVgJ6b6TwvLuqTlzKqp
         cQORRAgqTuxREG7fITH5MikFn9HxZ7mKmSCCF+q2Ti9dBDxq8Sc0N+ZtwQtnz+T6vT8o
         i+mn4+/JBVX3DeKRFW+htaAyUpNwu3Z6pOxQEsfRiJPo0B3/JFaDXVnWR2RmmTJAaJcV
         Mdkg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Return-Path: <linux-nfs-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id hs40-20020a1709073ea800b007ad976163f4si166453ejc.254.2022.11.21.00.00.01;
        Mon, 21 Nov 2022 00:00:39 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229633AbiKUH76 (ORCPT <rfc822;rosenp@gmail.com> + 99 others);
        Mon, 21 Nov 2022 02:59:58 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36152 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229590AbiKUH75 (ORCPT
        <rfc822;linux-nfs@vger.kernel.org>); Mon, 21 Nov 2022 02:59:57 -0500
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6ECBD124;
        Sun, 20 Nov 2022 23:59:56 -0800 (PST)
Received: by verein.lst.de (Postfix, from userid 2407)
        id 4B01168AA6; Mon, 21 Nov 2022 08:59:51 +0100 (CET)
Date:   Mon, 21 Nov 2022 08:59:51 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     Eric Van Hensbergen <ericvh@gmail.com>,
        Latchesar Ionkov <lucho@ionkov.net>,
        Dominique Martinet <asmadeus@codewreck.org>,
        Christian Schoenebeck <linux_oss@crudebyte.com>,
        David Howells <dhowells@redhat.com>,
        Marc Dionne <marc.dionne@auristor.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Xiubo Li <xiubli@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>,
        Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
        Ronnie Sahlberg <lsahlber@redhat.com>,
        Shyam Prasad N <sprasad@microsoft.com>,
        Tom Talpey <tom@talpey.com>,
        Christine Caulfield <ccaulfie@redhat.com>,
        David Teigland <teigland@redhat.com>,
        Chuck Lever <chuck.lever@oracle.com>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Bob Peterson <rpeterso@redhat.com>,
        Andreas Gruenbacher <agruenba@redhat.com>,
        Namjae Jeon <linkinjeon@kernel.org>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        Mark Fasheh <mark@fasheh.com>,
        Joel Becker <jlbec@evilplan.org>,
        Joseph Qi <joseph.qi@linux.alibaba.com>,
        Mike Marshall <hubcap@omnibond.com>,
        Martin Brandenburg <martin@omnibond.com>,
        "Darrick J. Wong" <djwong@kernel.org>, hch@lst.de,
        linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net,
        linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, cluster-devel@redhat.com,
        linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        devel@lists.orangefs.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH] filelock: move file locking definitions to separate
 header file
Message-ID: <20221121075951.GB24878@lst.de>
References: <20221120210004.381842-1-jlayton@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221120210004.381842-1-jlayton@kernel.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

Although it would be nice to drop all the pointless externs in the
new file while you're at it.