Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp3941668rwb; Mon, 21 Nov 2022 01:27:15 -0800 (PST) X-Google-Smtp-Source: AA0mqf6G8l2E8Y/pMDzGz3dCYYHJzYjjHJZPxNV3kuE7Fo4I/pECSxfo7iiM2HdaYzpKbajyqgiD X-Received: by 2002:a17:906:6a8e:b0:78d:a136:7332 with SMTP id p14-20020a1709066a8e00b0078da1367332mr14528420ejr.355.1669022834942; Mon, 21 Nov 2022 01:27:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669022834; cv=none; d=google.com; s=arc-20160816; b=zk1ZOgDONyMT68aVeBLp2tOaX884rCWcc27E/bDerMQGy4Ii3orGIETeHVYKyiVXr0 +pXfLTvDN48jW5lrJJ3yvEihisqWi4NWq2C+eQJuVGrVhJtmDJAT+r5c+G5bcveV0ZM3 yhvYWMTlFJN+66RhQaILthqbThpeGLgaw8qvcTwLNqXsqbvr1GtIxGY48NQI3as7a0F+ 5zhUQT3sxjtp4VM+O+EldtsEt0d/IcWU4UWUr2V32C0rESeXJfajVJ3RmEgtw1TFbEm4 TLDjJ/oUsKobTkgQRNiSPksnpG9t4zdT4iqgp223QqPRz0aMR3PpfeVWcZNE/1zM2igD waow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OGkxOou+BFCxzhmgYIR3dXgS0X+5SRauyNMovfNuRSA=; b=LyLXd23TQj2EsVhbXw08q9VJ9dgDcacMNNaYMkv3aFxkrJ6siLGkNFonqJuCJdISQ2 nesgNFMvFwielXE4Yc77nBEMRlsetnJosgQ8dB3DhDO5ND9hELf8ScfzyArnjQx9csvA faxMGN0FtYGMJw2wJJRvDwA20EO4zF4DfGBZG0/d3AekGLaskYApY2lObfHwm1rSW9pm MJyFoHrg8ZDPdVy8FO0NRpOJo/7yIPfo3SnpcBIHkCnITmC5TREtUTeiSqckAJ6KsVM9 +1M9mJktuCB9vbJjFt/L4EzbAag/0iRaOaEXdzf/6MD+uwMOywVX+3SqhkXDRHhWFx7d BhWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AwhEY/dD"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc39-20020a1709071c2700b0078d4b2754b5si10295434ejc.332.2022.11.21.01.26.39; Mon, 21 Nov 2022 01:27:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="AwhEY/dD"; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229791AbiKUJUQ (ORCPT + 99 others); Mon, 21 Nov 2022 04:20:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiKUJUP (ORCPT ); Mon, 21 Nov 2022 04:20:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03ECC2A737; Mon, 21 Nov 2022 01:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9302760F73; Mon, 21 Nov 2022 09:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F592C433C1; Mon, 21 Nov 2022 09:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669022413; bh=Rod4QLy3YHTf6Pn4dep500jsC9mccpeOXc9og6+BDkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AwhEY/dDW/xAQXKQY06ZdkenKH1tWXsfjYhpJkI7EXSR2DgDwEwDCSHzNF9BXj9SQ SRmwXBtkXFLo5i45Xf9DkLbPHTkzLhgSyU6Ewy+/E0iimScwd7sLrltK4hfnHmfW7d 8oOYBFprjXXNqmeSRYCEp55DvWIHg95tusp6OMpmYNe5vkGsQYiv1ais/6fskFZuzK uUbHhjNrsueFnhzd2mOqwd0qe/UoMHjckc6z+qtLRQY3ZNPeN5L9zkefeakhpbiPjO 9DJMO1GukybzD83AVos0vGE7HL0vhvIWV/ZtQqIyXq/7BH3gAP7oHnpceMszm/pILM yD+FZeeIzoiPw== Date: Mon, 21 Nov 2022 10:19:59 +0100 From: Christian Brauner To: Jeff Layton Cc: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Alexander Viro , Xiubo Li , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , hch@lst.de, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] filelock: move file locking definitions to separate header file Message-ID: <20221121091959.nzcunop3byncxa77@wittgenstein> References: <20221120210004.381842-1-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20221120210004.381842-1-jlayton@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Sun, Nov 20, 2022 at 03:59:57PM -0500, Jeff Layton wrote: > The file locking definitions have lived in fs.h since the dawn of time, > but they are only used by a small subset of the source files that > include it. > > Move the file locking definitions to a new header file, and add the > appropriate #include directives to the source files that need them. By > doing this we trim down fs.h a bit and limit the amount of rebuilding > that has to be done when we make changes to the file locking APIs. > > Signed-off-by: Jeff Layton > --- Looks good to me, Reviewed-by: Christian Brauner (Microsoft)