Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp4343549rwb; Mon, 21 Nov 2022 06:36:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf5e1495S9HvhrsKVBJfpRmtRftay58YCs6orQuFZlR3UL+/JB9Xlg2QRiMiOMOAKKjz7wud X-Received: by 2002:a17:906:710a:b0:7ae:3684:84b3 with SMTP id x10-20020a170906710a00b007ae368484b3mr7250579ejj.652.1669041393126; Mon, 21 Nov 2022 06:36:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669041393; cv=none; d=google.com; s=arc-20160816; b=XFXvH2njcsvSLreINV9LFfzeTi/Le8JlesH3fW4pnePmyv4cMA5tSLzRJDltlUBgF/ D794tDMTnI6LBRUNnGMUJa/8vl8LrUN+RR6ooXFEM+wZdj5u4xjdJ0ctiymw1l/Es/ek oM63l6HfOr0BadHiJkYJtAxS5U7ARbbHi4pRs+mdVa1xvdhMvsyJfFUsSjygvn5HuD3M nA1Lt3aWquvT4zBg5DayRms9Yd8t6Tni41RqTAoT5gO7qPqGfC/zhMgP5WaIS4av4IBH NNQKdZI5gDkmYNgTtrcQwlB3DvsW/njOrFBQxrL90m+W3sA98Y/AqKE+nQuIcLkfbYp3 9LGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=181ZHweS4wHRSdLySvK3fpfT7WMJLPwn/rNHBgW8rAk=; b=zgJ4AHSZIKXouJ0VwDQcbu7aUScEDYKaHeTxcC/0UTnzC3jEwkIfbfXiBnjArvp9tx Vdsxu+H5Gn47iSoP5BWlmq1xyDeeel3lPfW4MWVBAwngQrki4jlEHkHT+hkfsW3aLZCr 2om75gd2DQ7jgNU94DGJLZ1MOlPvKpgPHj108mjmPH7P0FYJx4FljuWuT1X7EJfbxnKl e3skwI0jWuCJBtqTPCuHSa9UpzM8RzI64BqiLgRIEC1Vp3dAtbdciM/O87dVA3YQoOit JTJlsBuOExLdO1+r9GL5PzTakRwx8NLsFRQLResZGU3VQKxv3AWug0vJ0OrfCzr0mUJL v7ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fxt1T7Fn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k9-20020a056402048900b00461ea502defsi8313842edv.350.2022.11.21.06.35.59; Mon, 21 Nov 2022 06:36:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fxt1T7Fn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229480AbiKUOfz (ORCPT + 99 others); Mon, 21 Nov 2022 09:35:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiKUOfy (ORCPT ); Mon, 21 Nov 2022 09:35:54 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAB6063CC for ; Mon, 21 Nov 2022 06:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669041299; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=181ZHweS4wHRSdLySvK3fpfT7WMJLPwn/rNHBgW8rAk=; b=fxt1T7Fn/Jp1aKcoJT9kSwIAdNSxyQyq0EQU5puz4xvZhS2BtpUTYPU+a+Z6A3G6ZFjthf Zk5aqRa0oZW1p5nx0rz/F97IakMwvtDfcdY1BYYsiKJDijNxmU9vxJmBujJCvCNicBdyrR PaH3G+zBcIORxbNzIpjFjk6mls0oWIc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-220-cKpJPG72PVO5ijDDtOCqbA-1; Mon, 21 Nov 2022 09:34:58 -0500 X-MC-Unique: cKpJPG72PVO5ijDDtOCqbA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1521B811E7A; Mon, 21 Nov 2022 14:34:56 +0000 (UTC) Received: from [172.16.176.1] (unknown [10.22.50.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 61D8E492B06; Mon, 21 Nov 2022 14:34:47 +0000 (UTC) From: Benjamin Coddington To: David Howells Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , =?utf-8?q?Christoph_B=C3=B6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Date: Mon, 21 Nov 2022 09:34:43 -0500 Message-ID: <51B5418D-34FB-4E87-B87A-6C3FCDF8B21C@redhat.com> In-Reply-To: <382872.1669039019@warthog.procyon.org.uk> References: <382872.1669039019@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 21 Nov 2022, at 8:56, David Howells wrote: > Benjamin Coddington wrote: > >> Since moving to memalloc_nofs_save/restore, SUNRPC has stopped setting the >> GFP_NOIO flag on sk_allocation which the networking system uses to decide >> when it is safe to use current->task_frag. > > Um, what's task_frag? Its a per-task page_frag used to coalesce small writes for networking -- see: 5640f7685831 net: use a per task frag allocator Ben