Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp5270148rwb; Mon, 21 Nov 2022 19:53:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf6tyKpGMCHVVv12d1cro/Rm9u1qTdrCDfoo/sUxG73Zfd9QBvsI/SwdZWbeXzCZBnUOikva X-Received: by 2002:a17:906:1484:b0:7ae:6746:f270 with SMTP id x4-20020a170906148400b007ae6746f270mr4688999ejc.728.1669089201712; Mon, 21 Nov 2022 19:53:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669089201; cv=none; d=google.com; s=arc-20160816; b=utfNhsaRIznUOzARq9eXC6mE3IwS2w+SfRrgznNzaQq+pdPXrYGu3Ws9yx1ccYkT6w whuIpfnINbSpXtO6u9Q6uRYnWt6OMOY59Ye5nHdWg1hNbK5qaMVdeyi+Sf4cpWQPYHb6 YNcNLSR3FyBfRFpMlRV8nsiAhASJ1J9r2uJEX4gTMIbZ3VzdqO0p8O0s/sPVLj1awCnS lTVFxIFJa5RK49jdJ7o5AT2NSUksmTAH7FIk7VT8FoJ/d8dVGltUO/al0yUh7OgZx+9k 88aFGSN+mW0u6mtlCgvOtdpRwU46eBfTxUEl0VDKUL7ULk170vZMqGHQJbWk07dCenYk 3VNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=uiFDQ6s5XgAcT9HYz21ROzPo6ZCyN/YsiViP9JuL2Vc=; b=rWQowfK1i0RZv2IRnqR4vof3Z0TqvkrVrNhnF3XF1xEVaGIprHO8BIEAkFemwnSqKQ IyPyl2g99tIYzL6b3jntvASqLnRxNQ/2nyG8pQIOr3ikcQFhb38istLgDWTHjVb/mnO+ pHthOb39aKzew2eWTkPZuFZ6M1IntitCAwItlopMaDLgJD3Op0BjyNf31wu9M3r8AJmt 6E0U4lUW4lLS5qAvNPl/PfUwUBDA9RYYxnSoiIy/gMokvbhxjNx/q5kedBiqXL7IyRD4 k/Zzvf7L3etp1xxhjekpxblRCtdqlXYKQRZl/O08cNTVOqVcTpCUKiky3F2o9GxaALq9 sBuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NJJwrm6I; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd9-20020a1709069b8900b007a1b49ca799si11380480ejc.385.2022.11.21.19.52.47; Mon, 21 Nov 2022 19:53:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=NJJwrm6I; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232252AbiKVDpq (ORCPT + 99 others); Mon, 21 Nov 2022 22:45:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232251AbiKVDpp (ORCPT ); Mon, 21 Nov 2022 22:45:45 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A71529371; Mon, 21 Nov 2022 19:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uiFDQ6s5XgAcT9HYz21ROzPo6ZCyN/YsiViP9JuL2Vc=; b=NJJwrm6IpzOJ+nUmhrd1OXfoCk G7FtSuALDx10w2NwiIqoKiG9ykgmyUGgqgtM+aJpa2oS2fQRQ+RCGSFLUVL1nV3H67iQsoM+ZXI+P 75G75qOGTBUz2j3XL00qgcUTJotjzi0OfiKIf+ALXzMf3ZoQMf3KRnGWl+fsNnIUD5GBw7fYM0qpK 68xmJhc99PpF71YEvdwSpdkfVDQQinCYdj6BfJplncqBsPQyicO+REFgABedNNQo6QpK9GD/KJOMG I2YH4RdEbuSk9AKSGChXb1wwhkouk4nfTA4WUiJD8aJEXUyng2vGvKiEnZPT7EPwwj7AX43JZiVeT eCgYCCfg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oxKCp-005u2i-VP; Tue, 22 Nov 2022 03:44:20 +0000 Date: Tue, 22 Nov 2022 03:44:19 +0000 From: Matthew Wilcox To: Xiubo Li Cc: Jeff Layton , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Howells , Marc Dionne , Alexander Viro , Ilya Dryomov , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Christine Caulfield , David Teigland , Chuck Lever , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Namjae Jeon , Sergey Senozhatsky , Trond Myklebust , Anna Schumaker , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , "Darrick J. Wong" , hch@lst.de, linux-kernel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, devel@lists.orangefs.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] filelock: move file locking definitions to separate header file Message-ID: References: <20221120210004.381842-1-jlayton@kernel.org> <6627384e-5514-048f-308e-57414d0c5b31@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6627384e-5514-048f-308e-57414d0c5b31@redhat.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Nov 21, 2022 at 09:26:16AM +0800, Xiubo Li wrote: [1300+ lines snipped] > LGTM. > > Reviewed-by: Xiubo Li You really don't need to quote the whole thing. Please be more considerate.