Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0f8da54c-b442-e4ae-770c-4e9919bb7bfa@suse.cz>
Date:   Tue, 22 Nov 2022 11:23:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: Files in include/trace/events
Content-Language: en-US
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Chuck Lever <chuck.lever@oracle.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        LKML <linux-kernel@vger.kernel.org>, linux-nfs@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Hyeonggon Yoo <42.hyeyoo@gmail.com>,
        Matthew Wilcox <willy@infradead.org>,
        Michal Hocko <mhocko@kernel.org>
References: <20221112072742.065df70a@rorschach.local.home>
 <20221112073305.0346b827@rorschach.local.home>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20221112073305.0346b827@rorschach.local.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/12/22 13:33, Steven Rostedt wrote:
> On Sat, 12 Nov 2022 07:27:42 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> Hi Chuck,
>> 
>> I was just looking over some files in include/trace/events/ and noticed
>> that there's sunrpc_base.h, fs.h and nfs.h that are not event files.
>> 
>> The include/trace/events/ directory should only hold files that are to
>> create events, not headers that hold helper functions.
>> 
>> Can you please move them out of include/trace/events/ as that directory
>> is "special" in the creation of events.
>> 
>> Perhaps we could create a new directory include/linux/trace/ or
>> include/trace/linux/ specific for these types of files?
>> 
> 
> Hi Vlastimil,
> 
> I also noticed that mmflags.h is in that directory too.
> 
> I'd like to keep only headers defining TRACE_EVENT() in that directory,
> as files there have special meaning.

I guess we could move that one to e.g. mm/mmflags.h as it's used also
outside of trace events anyway (mm/debug.c), but it's not something to
expose to general use in include/ But most includes are from proper
include/trace/events/*.h headers so dunno, maybe
include/trace/<something>/mmflags.h would be more appropriate.

> Thanks,
> 
> -- Steve