Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a731e688122d1a6fdb2f7bdbd71d403fa110e9f2.camel@kernel.org>
Subject: Re: [PATCH] filelock: move file locking definitions to separate
 header file
From:   Jeff Layton <jlayton@kernel.org>
To:     Joseph Qi <joseph.qi@linux.alibaba.com>,
        Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>
Cc:     hch@lst.de, linux-kernel@vger.kernel.org,
        v9fs-developer@lists.sourceforge.net,
        linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org,
        ceph-devel@vger.kernel.org, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, cluster-devel@redhat.com,
        linux-nfs@vger.kernel.org, ocfs2-devel@oss.oracle.com,
        devel@lists.orangefs.org, linux-xfs@vger.kernel.org
Date:   Tue, 22 Nov 2022 07:20:35 -0500
In-Reply-To: <0c6a44ff-409e-99b2-eaa9-fd6e87a9e104@linux.alibaba.com>
References: <20221120210004.381842-1-jlayton@kernel.org>
         <0c6a44ff-409e-99b2-eaa9-fd6e87a9e104@linux.alibaba.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-11-22 at 09:51 +0800, Joseph Qi wrote:
> Hi,
>=20
> On 11/21/22 4:59 AM, Jeff Layton wrote:
> > The file locking definitions have lived in fs.h since the dawn of time,
> > but they are only used by a small subset of the source files that
> > include it.
> >=20
> > Move the file locking definitions to a new header file, and add the
> > appropriate #include directives to the source files that need them. By
> > doing this we trim down fs.h a bit and limit the amount of rebuilding
> > that has to be done when we make changes to the file locking APIs.
> >=20
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> >  fs/9p/vfs_file.c          |   1 +
> >  fs/afs/internal.h         |   1 +
> >  fs/attr.c                 |   1 +
> >  fs/ceph/locks.c           |   1 +
> >  fs/cifs/cifsfs.c          |   1 +
> >  fs/cifs/cifsglob.h        |   1 +
> >  fs/cifs/cifssmb.c         |   1 +
> >  fs/cifs/file.c            |   1 +
> >  fs/cifs/smb2file.c        |   1 +
> >  fs/dlm/plock.c            |   1 +
> >  fs/fcntl.c                |   1 +
> >  fs/file_table.c           |   1 +
> >  fs/fuse/file.c            |   1 +
> >  fs/gfs2/file.c            |   1 +
> >  fs/inode.c                |   1 +
> >  fs/ksmbd/smb2pdu.c        |   1 +
> >  fs/ksmbd/vfs.c            |   1 +
> >  fs/ksmbd/vfs_cache.c      |   1 +
> >  fs/lockd/clntproc.c       |   1 +
> >  fs/lockd/netns.h          |   1 +
> >  fs/locks.c                |   1 +
> >  fs/namei.c                |   1 +
> >  fs/nfs/nfs4_fs.h          |   1 +
> >  fs/nfs_common/grace.c     |   1 +
> >  fs/nfsd/netns.h           |   1 +
> >  fs/ocfs2/locks.c          |   1 +
> >  fs/ocfs2/stack_user.c     |   1 +
>=20
> Seems it misses the related changes in:
> fs/ocfs2/stackglue.c
>=20

I was able to build ocfs2.ko just fine without any changes to
stackglue.c. What problem do you see here?

Thanks,
--=20
Jeff Layton <jlayton@kernel.org>