Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8ca382fa391a08313ba8dc5ce115e1832e32aebb.camel@kernel.org>
Subject: Re: [PATCH 2/3] fs: namei: Allow follow_down() to uncover auto
 mounts
From:   Jeff Layton <jlayton@kernel.org>
To:     Richard Weinberger <richard@nod.at>
Cc:     linux-nfs <linux-nfs@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        chuck lever <chuck.lever@oracle.com>, anna <anna@kernel.org>,
        trond myklebust <trond.myklebust@hammerspace.com>,
        Al Viro <viro@zeniv.linux.org.uk>, raven <raven@themaw.net>,
        chris chilvers <chris.chilvers@appsbroker.com>,
        david young <david.young@appsbroker.com>,
        luis turcitu <luis.turcitu@appsbroker.com>,
        david <david@sigma-star.at>
Date:   Mon, 28 Nov 2022 06:49:36 -0500
In-Reply-To: <1045320558.283423.1669584585412.JavaMail.zimbra@nod.at>
References: <20221117191151.14262-1-richard@nod.at>
         <20221117191151.14262-3-richard@nod.at>
         <f31d4114f363ed9de0eba66ad6a730fe013896a6.camel@kernel.org>
         <1805608101.252119.1668719538854.JavaMail.zimbra@nod.at>
         <29d007755c6066552ac2a1b5bc498ce1ce28ab3b.camel@kernel.org>
         <1045320558.283423.1669584585412.JavaMail.zimbra@nod.at>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.1 (3.46.1-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Sun, 2022-11-27 at 22:29 +0100, Richard Weinberger wrote:
> ----- Urspr=FCngliche Mail -----
> > Von: "Jeff Layton" <jlayton@kernel.org>
> > > So, in nfsd_cross_mnt() the follow_down() helper should use LOOKUP_AU=
TOMOUNT
> > > only
> > > if exp->ex_flags & NFSEXP_CROSSMOUNT is true?
> > > Sounds sane, thanks for the pointer.
> > >=20
> >=20
> > Yeah, I think so. I do wonder if we ought to make any provision for
> > "nohide" exports, but since you have to enumerate those explicitly, it
> > shouldn't be a huge problem for someone to just ensure that they're
> > mounted beforehand.
>=20
> TBH, I didn't invest much into the nohide feature wrt. NFS re-exporting.
> What problem do you have in mind?
>=20

nohide is sort of complimentary to crossmnt. You can achieve the same
effect as crossmnt by adding explicit exports for all the children and
marking them "nohide".

The point here is that you have to explicitly create exports for the
child mounts in that case, and if you're doing that then it's not a
burden for the admin to make sure they're mounted before exporting.

So, I don't think we need to worry about nohide here after all.

> I wonder also what NFS client folks think about my changes before I send
> the next revision (with Jeff's comments addressed).
--=20
Jeff Layton <jlayton@kernel.org>