Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp836558rwb; Tue, 29 Nov 2022 06:04:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf7uPbXa66GhdavUk2cNmMPkqLuWrmurvLNXdtO8Slxz7iVrpr5n9e3Y+1UpmyXRrCs1XlHW X-Received: by 2002:a63:ea17:0:b0:477:9a46:f57b with SMTP id c23-20020a63ea17000000b004779a46f57bmr32478969pgi.319.1669730665166; Tue, 29 Nov 2022 06:04:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669730665; cv=none; d=google.com; s=arc-20160816; b=i079FNCR2yS37qj9lIzxTwbJefDMgexJbPNNKqAMmWZmN1e1kwyfnDwzFUCiBg+ab0 /SOLy8V2ZCKIppTjqm51E1lSR89R0wqgexJESfJHlnGcqujcOeH9mBtfLYbdRNu7LGk2 vZ/8oOAY9pMtfP+H5nFg9OE6Of6GCrNOZhTs2XG7FacQ23hNCxHesh7otUuPO5mg3ujG ro7/Poo8X6d2DWF3BKgpou/hdThAkGd6AfveEgXx8xmiQ/pf8gFp91U7qSY6l8cOnZ3J /p3eAVsmJztGpYQWC65FFszvr5aQvUhlmiwC72Qtq5XhVuteaNZU88rV1tJCf6p71ZUb nK4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dxMrIRuI8XL9/2L/5QCWGQzHb14K/VQG03dRspTYCG8=; b=nsGSs8oSrjFyFu3LJcLmHXNFbmojca+apuecxpCl6aSFke0+zW0djnyDv3DqnUGV1M 7C4RJbrepAMJarkFSq1i1tGzR+V4AtbfKZwLYuP23WUJ/YfwQNlYSS+6yrJr9ffXyWfo Ihdn8ijbjMMgmzZ20IqjbAISguby1vS/o3rYAewzAtpXUckMrH7iSenfqzucrYNltGAt 6e+zhrcaNSZBkFFdpTqdniQIiGVAophnbJ7PkppTFQf00w8C2cO30AaiJ00q+4dRt9sI ysm2MuRskH4hotecLDURBd9yBO0fbZoOhelhPmFsfdUBrmMmWKzhM6u7tAukwSuynw2e cBtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id oa17-20020a17090b1bd100b00218af09d1f4si1864966pjb.37.2022.11.29.06.03.57; Tue, 29 Nov 2022 06:04:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234098AbiK2ODJ (ORCPT + 99 others); Tue, 29 Nov 2022 09:03:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233706AbiK2OCt (ORCPT ); Tue, 29 Nov 2022 09:02:49 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0251813D20; Tue, 29 Nov 2022 06:02:49 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 7710168BEB; Tue, 29 Nov 2022 15:02:42 +0100 (CET) Date: Tue, 29 Nov 2022 15:02:42 +0100 From: Christoph Hellwig To: Benjamin Coddington Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Philipp Reisner , Lars Ellenberg , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , Jens Axboe , Josef Bacik , Keith Busch , Christoph Hellwig , Sagi Grimberg , Lee Duncan , Chris Leech , Mike Christie , "James E.J. Bottomley" , "Martin K. Petersen" , Valentina Manea , Shuah Khan , Greg Kroah-Hartman , David Howells , Marc Dionne , Steve French , Christine Caulfield , David Teigland , Mark Fasheh , Joel Becker , Joseph Qi , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Ilya Dryomov , Xiubo Li , Trond Myklebust , Anna Schumaker , Chuck Lever , Jeff Layton , drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, nbd@other.debian.org, linux-nvme@lists.infradead.org, open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 2/3] Treewide: Stop corrupting socket's task_frag Message-ID: <20221129140242.GA15747@lst.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Hmm. Having to set a flag to not accidentally corrupt per-task state seems a bit fragile. Wouldn't it make sense to find a way to opt into the feature only for sockets created from the syscall layer?