Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b4474890-4d36-730c-af29-2d4541a9c362@redhat.com>
Date:   Tue, 6 Dec 2022 08:32:24 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v2 0/4] Replace sysctl setting invocations triggered from
 udev rule instead of modprobe configuration
Content-Language: en-US
To:     Salvatore Bonaccorso <carnil@debian.org>,
        NeilBrown <neilb@suse.de>, linux-nfs@vger.kernel.org
Cc:     Andras Korn <korn-debbugs@elan.rulez.org>,
        Marco d'Itri <md@linux.it>, Michael Prokop <mika@debian.org>
References: <20221125140656.1985137-1-carnil@debian.org>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20221125140656.1985137-1-carnil@debian.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/25/22 9:06 AM, Salvatore Bonaccorso wrote:
> Hi Neil, hi Steve
> 
> In Debian for the update including the systemd/50-nfs.conf there was a
> report that sunrpc is not included anymore in the initrd through the
> initramfs-tools hooks.
> 
> The report is at https://bugs.debian.org/1022172
> 
> Marco d'Itri suggested there three possible solutions, of which one
> could be done in nfs-utils (whereas the other two are either in kmod
> upstream or initramfs-tools upstream). The nfs-utils one would be to
> replace the modprobe configuration with a set of udev rules instead.
> 
> This series reverts the commits which introduce the use of the modprobe
> configuration and instead replaces it with an udev rule which triggers
> setting the sysctl settings when the respective modules are loaded.
> 
> Regards,
> Salvatore
> 
> Changes:
> --------
> v2:
>   - Fix a series of spelling and typos in the commit messages.
Committed... (tag: nfs-utils-2-6-3-rc5)

steved.
> 
> Salvatore Bonaccorso (4):
>    Revert "configure: make modprobe.d directory configurable."
>    Revert "modprobe: protect against sysctl errors"
>    Revert "systemd: Apply all sysctl settings when NFS-related modules
>      are loaded"
>    systemd: Apply all sysctl settings through udev rule when NFS-related
>      modules are loaded
> 
>   configure.ac         | 12 ------------
>   systemd/50-nfs.conf  | 16 ----------------
>   systemd/60-nfs.rules | 21 +++++++++++++++++++++
>   systemd/Makefile.am  | 15 ++++++---------
>   4 files changed, 27 insertions(+), 37 deletions(-)
>   delete mode 100644 systemd/50-nfs.conf
>   create mode 100644 systemd/60-nfs.rules
>