Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Anna Schumaker <anna@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        Eric Dumazet <edumazet@google.com>,
        Guillaume Nault <gnault@redhat.com>
Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of
 current->task_frag.
Date:   Wed, 07 Dec 2022 06:47:43 -0500
Message-ID: <16B6A2FD-3ED4-40FF-9776-E4BC341139F2@redhat.com>
In-Reply-To: <20221025111525.GA4415@localhost.localdomain>
References: <de6d99321d1dcaa2ad456b92b3680aa77c07a747.1665401788.git.gnault@redhat.com>
 <Y0QyYV1Wyo4vof70@infradead.org>
 <20221010165650.GA3456@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com>
 <Y0UKq62ByUGNQpuY@infradead.org>
 <20221011150057.GB3606@localhost.localdomain>
 <a0bf0d49a7a69d20cfe007d66586a2649557a30b.camel@kernel.org>
 <20221011211433.GA13385@ibm-p9z-18-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com>
 <20221013121834.GA3353@localhost.localdomain>
 <20221025111525.GA4415@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On 25 Oct 2022, at 7:15, Guillaume Nault wrote:

> On Thu, Oct 13, 2022 at 02:18:37PM +0200, Guillaume Nault wrote:
>> Still, that looks like net-next material to me. Reverting sunrpc to use
>> GFP_NOFS looks better for an immediate bug fix.
>
> Could we please move forward with this patch? This bug really needs to be
> fixed. So please let's either revert to GFP_NOFS or actively work on a
> different solution.

Hey Trond, Anna - I think the right thing to do here is send this patch to
-stable as stable-only while we try to get this fixed up.  Any objections to
that?

Ben