Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
To:     <trond.myklebust@hammerspace.com>
CC:     <anna@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-nfs@vger.kernel.org>, <yusongping@huawei.com>,
        <hukeping@huawei.com>, <artem.kuzin@huawei.com>
Subject: [PATCH] fs: NFSv4.1: Fix memory leakage
Date:   Fri, 9 Dec 2022 10:18:23 +0800
Message-ID: <20221209021823.1232874-1-konstantin.meskhidze@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type:   text/plain; charset=US-ASCII
Precedence: bulk

This commit fixes potential memory leakage of 'calldata' memory chunk
in _nfs41_proc_sequence() function.

Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
---
 fs/nfs/nfs4proc.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 86ed5c0142c3..b7aa66167341 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -9416,8 +9416,10 @@ static struct rpc_task *_nfs41_proc_sequence(struct nfs_client *clp,
 	task_setup_data.callback_data = calldata;
 
 	ret = rpc_run_task(&task_setup_data);
-	if (IS_ERR(ret))
+	if (IS_ERR(ret)) {
+		kfree(calldata);
 		goto out_err;
+	}
 	return ret;
 out_put_clp:
 	nfs_put_client(clp);
-- 
2.25.1