Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Anna Schumaker <anna@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Al Viro <viro@zeniv.linux.org.uk>, Ian Kent <raven@themaw.net>,
        "chris.chilvers@appsbroker.com" <chris.chilvers@appsbroker.com>,
        "david.young@appsbroker.com" <david.young@appsbroker.com>,
        "luis.turcitu@appsbroker.com" <luis.turcitu@appsbroker.com>,
        "david@sigma-star.at" <david@sigma-star.at>,
        "benmaynard@google.com" <benmaynard@google.com>,
        Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 3/3] NFS: nfs_encode_fh: Remove S_AUTOMOUNT check
Thread-Topic: [PATCH 3/3] NFS: nfs_encode_fh: Remove S_AUTOMOUNT check
Thread-Index: AQHZChf9fDsgUtMhNUKtyOAuOArmha5th9sA
Date:   Wed, 14 Dec 2022 15:09:12 +0000
Message-ID: <92B44C88-61B5-4450-B027-60F9F7A614FF@oracle.com>
References: <20221207084309.8499-1-richard@nod.at>
 <20221207084309.8499-4-richard@nod.at>
In-Reply-To: <20221207084309.8499-4-richard@nod.at>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xrlKzS/m/LxNVxxxrgcBNUY40cCEhmTimJXxJTfWVr7ocfhSYEquvdCJxcQe?=
 =?us-ascii?Q?4K9OLWyTrbqMNTxBta8AAHMlggrbTy54byM/tQw7H3rTpYLVSkgHcE/y3ilN?=
 =?us-ascii?Q?zjRI4YAJ3SSYkoeqa0B4rV364TW7KAa4DvDPXhXS/COL2MM14TNFr8ZdDZlc?=
 =?us-ascii?Q?IlGvkwLklWv0SOazVRt0F76QNsw3dA0XRYmdHrChNOdctjXEHvKSCjc2mcbP?=
 =?us-ascii?Q?acp5FdBJnGxBWB4/ueCvGmPxAu/mRS+8nhvl65KUt4uop6qnUB3QzDjeZd1X?=
 =?us-ascii?Q?jOQZTRHZ6TrPMaJxpm/UKZ/5YZwnyfImM4Ojg1N7CAPz2l6wTYB4voyi9XV1?=
 =?us-ascii?Q?LO+PQd+JmmdVIhMfGAZw8Fxgl1n7P9vJYdTU9joov8Qe/tKk1cDXTxdKGfB7?=
 =?us-ascii?Q?o59BkaCziV96cGis7RE+t7lGV9I34jAiNjWRcUr1CXCb6AUpvOAYvl4Gs5ek?=
 =?us-ascii?Q?5Oia0us9Ypmch3oWtI9OiIs1otUCgpgxYvfUPsRYgJO3iklsXQaK6KjuHVJN?=
 =?us-ascii?Q?2BbE7mVHnnefweQK7NYGYOB4WSGlkGJiZAqbqj9mk0G6sh4iPV4GpeiFAkEM?=
 =?us-ascii?Q?UkYTKBysJNhCntpb/CyL1/cvWcOtOqBmTIui0HtqGmCP2G4YzPCauKwIclxO?=
 =?us-ascii?Q?ZGntg/+a8912uI3T/fVNzVKh/IJ2Hb8jf38LVgcOyX/iSXPpa8DaOgNuHR0r?=
 =?us-ascii?Q?YSWSfxCsBoBHdOZ7vgttBPw+h87M+OjBMXDsm44YZIuXPrtbe2E4j00ELdN/?=
 =?us-ascii?Q?lmtnlFjvYfmngQfwyxYapXKaiTxCi1kLmsQDPWY2jtJ4Vsl8S0v01HRYBvN6?=
 =?us-ascii?Q?LuCJ4U3MXd4UuGQ5LoDOa2hohk/uQ1RtoehkSOgEqT1y4Bpy6vznXKHIPeb2?=
 =?us-ascii?Q?C51r+r+bdocmuBGdkOSdEsNvhd9PzM+WvITHmlvFlIQrcwRqS16gLHCObIlO?=
 =?us-ascii?Q?W6MaliK9+3Rcwdv7VLo6r5+aA37kU7wcjquRbc/13/z5WRQXC2pL1NJbym+r?=
 =?us-ascii?Q?taeYMGpVC7f3Hfi59FqvNKN5C2UDA8iWGEH4KllOhwDMh0lfutm00f5XD+bf?=
 =?us-ascii?Q?+jae2v9Kb+iZaYk8dDOLAcvI084II7L4we+a3eeZQCpPnnA+aMnBzgTO95PF?=
 =?us-ascii?Q?9lZlpJaZ4kx9sSWnrPQm6IRmZ0MvkqeoA7iwOM81n8MMXm/YP8R5Qr5pBkBw?=
 =?us-ascii?Q?mi9en7iXuitAUjBXliwEGmxjIYjzTNeh7sqbTlmZX4EyLMQQBKpiDsuyCWIx?=
 =?us-ascii?Q?1nP7HZRa4+Ozek9nj8x1xqjJOuu0QrtJ1Km29dDuir1XQGSWCIf3/oj5HRiS?=
 =?us-ascii?Q?74S5bRx96c3sFychuD+NMC/6wRhPepTVULSxvK0EZ8WFhzkLcdLEQA6ZR0wN?=
 =?us-ascii?Q?8pIfmsvLoy1XOJBiHtiP6FFi6pwRPJiHA0obsH2+oMSsAPWR8L+a9mQI5+M2?=
 =?us-ascii?Q?NhKToJb5hgDXcpu1qNzC2vjFzoDRrkT7wUJ85cf+3Sw0geR+e1ZasYzFDnPd?=
 =?us-ascii?Q?PZa/S038X5OfC6tffp9DBVwWQ12C59sau5LsaD/sooxJvvD3o4b5+oiKppm/?=
 =?us-ascii?Q?8z57PNRkChrDmumVu7oeB2jLpc4JetJlf4KmZ+zmJcZ+G4QtCYtovbXtP4MQ?=
 =?us-ascii?Q?Sg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BB3FCD4B09512C43A59F138EF848BAC8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5134.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: eae3a383-a789-42e4-15ef-08dadde528da
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 15:09:12.8820
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Z2nSujQR1/O/Z2HJxvD25FYykRCI1idEsdiR5BDoile9Js4SsgAlwaF/zARAuqrcmLO7og5UDJHmczOkS30aYA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6974
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-14_06,2022-12-14_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 suspectscore=0 bulkscore=0
 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212140121
X-Proofpoint-GUID: 3nzQb0tYHnovcu9Cd1QfkEQlZoCuiRRe
X-Proofpoint-ORIG-GUID: 3nzQb0tYHnovcu9Cd1QfkEQlZoCuiRRe
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 7, 2022, at 3:43 AM, Richard Weinberger <richard@nod.at> wrote:
>=20
> Now with NFSD being able to cross into auto mounts,
> the check can be removed.
>=20
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> fs/nfs/export.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfs/export.c b/fs/nfs/export.c
> index 01596f2d0a1e..0a5ee1754d50 100644
> --- a/fs/nfs/export.c
> +++ b/fs/nfs/export.c
> @@ -42,7 +42,7 @@ nfs_encode_fh(struct inode *inode, __u32 *p, int *max_l=
en, struct inode *parent)
> 	dprintk("%s: max fh len %d inode %p parent %p",
> 		__func__, *max_len, inode, parent);
>=20
> -	if (*max_len < len || IS_AUTOMOUNT(inode)) {
> +	if (*max_len < len) {
> 		dprintk("%s: fh len %d too small, required %d\n",
> 			__func__, *max_len, len);
> 		*max_len =3D len;
> --=20
> 2.26.2
>=20

I plan to take this through the nfsd tree, thus this one needs
an Ack from the NFS client maintainers.

--
Chuck Lever