Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Al Viro <viro@zeniv.linux.org.uk>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Jeff Layton <jlayton@kernel.org>,
        Anna Schumaker <anna@kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Ian Kent <raven@themaw.net>,
        "chris.chilvers@appsbroker.com" <chris.chilvers@appsbroker.com>,
        "david.young@appsbroker.com" <david.young@appsbroker.com>,
        "luis.turcitu@appsbroker.com" <luis.turcitu@appsbroker.com>,
        "david@sigma-star.at" <david@sigma-star.at>,
        "benmaynard@google.com" <benmaynard@google.com>,
        Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 2/3] namei: Allow follow_down() to uncover auto mounts
Thread-Topic: [PATCH 2/3] namei: Allow follow_down() to uncover auto mounts
Thread-Index: AQHZD87isjNJtSzjWUmQcIhiw7etvA==
Date:   Wed, 14 Dec 2022 15:15:21 +0000
Message-ID: <C5BAFE20-5325-4DA8-B933-364E0A0E27D6@oracle.com>
References: <20221207084309.8499-1-richard@nod.at>
 <20221207084309.8499-3-richard@nod.at>
In-Reply-To: <20221207084309.8499-3-richard@nod.at>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xk7+UzLjzdZ25szJuoPwYMvt+lLP97UiXkS5M+sbuvAQsTYRxbMpxwotKwRU?=
 =?us-ascii?Q?Xx1jLpUEA33bt3I/Hj8QjcxuwzgglF9f2wGeH32sKZkgYzcAocWfSufgl9/w?=
 =?us-ascii?Q?bgUR/O7M03I/4Z/bHXVFSM8lbPEMw0ObuOC6qrfz5HxoIyYe10gi1l+aY2ra?=
 =?us-ascii?Q?gQA2vE4Kr9T5PxlN4q+ypCNMjyBS/7wIO3dDMPneUqRW4PlAZaj2zyWDETfS?=
 =?us-ascii?Q?f2M5r1u6otBdTPiyBYTkWF92L3e5fUykRu3NK+uE0ONoJJr/lvgwLtSTK14K?=
 =?us-ascii?Q?50i14W3Q8l7N3E4MAScmF8qgw4p6VK3328fRF4lTjgEKZTtqtfIvD+BMa6Mt?=
 =?us-ascii?Q?UfvTM94gogZq+1EAlZlzr+6eAB5heD6nzu+9tPTwaZE3nAWych1VHMqiy/ri?=
 =?us-ascii?Q?I8R0aqdLF/JDesVkf2JJ65Fphg4qRXOA68k9p91OiKDduWcn0F+b89n7SIxT?=
 =?us-ascii?Q?k2sqUo6HloQIeR7uk8sr9YzKlvg5iY5uk8T2CMeHQYkiSAKMA/CN56z020LQ?=
 =?us-ascii?Q?pygBuWx3cxEwKhM0qFthWf7qX8KDkYPD85jYm8TPBbYGtcd4QVwE+EJi96Q0?=
 =?us-ascii?Q?bOVys892WrjhnQyD+zqX2ZqO0UMAdLbhRVPEhNmldSZyFwxbBg0mB5CZ2+WP?=
 =?us-ascii?Q?ge8HS5CPNQfCj3N+S6hJFdwfCxQts1m2Ezw+3Pylh0Zr/BV6gdYF+cAw8riE?=
 =?us-ascii?Q?0BiMdDNafu31NSFv01A8I55LPu5XmEnESgjfRj4VNeY/aizDIkHjxa6CLk72?=
 =?us-ascii?Q?wDp9vov30OCRohCaQv8OBb1PGRPhnf9E03TFNL5VjqiXNsTYzR8Qr5yx5nst?=
 =?us-ascii?Q?qbvz0pUxHHJGiZGtBhMX3zL5SrCGckD2n33vpgI1/MX3639FvIsmTpUNHwy2?=
 =?us-ascii?Q?5JDjqkAdJoHhV1Y3ykdz13ffsVkDui+m4tv15xkoumu0nbKGPUqIk+Kf/i7f?=
 =?us-ascii?Q?0KJ4xNdlcybBNkvsQ2eKlgwKhZd+oaGWcrmC3NXDI+aVGT0y0blluMzkLkh2?=
 =?us-ascii?Q?krmy4mmOoyBKD2SUw0D2Q/rZ4eCxn7UbppX+TdTOOo16mX2tAcgCIKyWIoAi?=
 =?us-ascii?Q?43JAOXGwTi8A9XghzQPrkBjNb8+7DFIBfakQqsZDieeS91iq79M5DYiGuE77?=
 =?us-ascii?Q?vjpdyoYc77AUJ6uFJ/4+REUyhAgnfRmrthE8bTaAS7tyiHC6CKdOFQII0d5w?=
 =?us-ascii?Q?8Me9sE9/8vkRes8YrZGiHBCqJx7eNMf1YI2VDpdzuv5BNaOcSMuaL8l8cV8i?=
 =?us-ascii?Q?GLoomA76JUxXO497kO+tCloAjtCQNgUfdeDwi90DpsrK+GXI23q/0CKfTEMU?=
 =?us-ascii?Q?QVN+R6P90JfckXLdU/OWKTjWLJZ2jlYL4Qsq47xnvKhZGv/lujCItaNFazVQ?=
 =?us-ascii?Q?GuVRvhsuP52dlwuQQvkHFRGgQCOd/G8BFp8YVDeBXrhqS/9IRuodDViKsNv6?=
 =?us-ascii?Q?cBlTQep8ByE8uNj0o73yKMNv01jdcow4Jn7YEtvGyBhc+yw+fjc4k0g3/Ur6?=
 =?us-ascii?Q?F7bbhSeQZJcT4e/tUyiQFseJ1Xen/s3n6dhTNpfZErjx856lahDGIW1ATiz+?=
 =?us-ascii?Q?mwCzL37lPBnvTpRP5pZt3rQ02ht/jbvTFSqg8jME7KuRZNxdh2QX35LK6230?=
 =?us-ascii?Q?Hg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C479F86C1A280A43AFFF5E23F5384D9B@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5134.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 21f1f2fd-9c36-40c9-c8b2-08dadde6049a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 15:15:21.5503
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: wwEczsci9EbAgVbQiLkhR+wsU7VkuRGQNbNhg5S/osnjsMh7tj+JTBCLCBJw5XQyZ2WCkiuaFa0baj7Ze6NPtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6122
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-14_07,2022-12-14_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 mlxlogscore=955 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212140121
X-Proofpoint-ORIG-GUID: Bs2Az3BC9072V3Crga_-E9pj9CrUnadh
X-Proofpoint-GUID: Bs2Az3BC9072V3Crga_-E9pj9CrUnadh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 7, 2022, at 3:43 AM, Richard Weinberger <richard@nod.at> wrote:
>=20
> This function is only used by NFSD to cross mount points.
> If a mount point is of type auto mount, follow_down() will
> not uncover it. Add LOOKUP_AUTOMOUNT to the lookup flags
> to have ->d_automount() called when NFSD walks down the
> mount tree.
>=20
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> fs/namei.c            | 6 +++---
> fs/nfsd/vfs.c         | 6 +++++-
> include/linux/namei.h | 2 +-
> 3 files changed, 9 insertions(+), 5 deletions(-)
>=20
> diff --git a/fs/namei.c b/fs/namei.c
> index 578c2110df02..a6bb6863bf0c 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -1458,11 +1458,11 @@ EXPORT_SYMBOL(follow_down_one);
>  * point, the filesystem owning that dentry may be queried as to whether =
the
>  * caller is permitted to proceed or not.
>  */
> -int follow_down(struct path *path)
> +int follow_down(struct path *path, unsigned int flags)
> {
> 	struct vfsmount *mnt =3D path->mnt;
> 	bool jumped;
> -	int ret =3D traverse_mounts(path, &jumped, NULL, 0);
> +	int ret =3D traverse_mounts(path, &jumped, NULL, flags);
>=20
> 	if (path->mnt !=3D mnt)
> 		mntput(mnt);
> @@ -2864,7 +2864,7 @@ int path_pts(struct path *path)
>=20
> 	path->dentry =3D child;
> 	dput(parent);
> -	follow_down(path);
> +	follow_down(path, 0);
> 	return 0;
> }
> #endif
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 157f0df0e93a..ced04fc2b947 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -63,9 +63,13 @@ nfsd_cross_mnt(struct svc_rqst *rqstp, struct dentry *=
*dpp,
> 	struct dentry *dentry =3D *dpp;
> 	struct path path =3D {.mnt =3D mntget(exp->ex_path.mnt),
> 			    .dentry =3D dget(dentry)};
> +	unsigned int follow_flags =3D 0;
> 	int err =3D 0;
>=20
> -	err =3D follow_down(&path);
> +	if (exp->ex_flags & NFSEXP_CROSSMOUNT)
> +		follow_flags =3D LOOKUP_AUTOMOUNT;
> +
> +	err =3D follow_down(&path, follow_flags);
> 	if (err < 0)
> 		goto out;
> 	if (path.mnt =3D=3D exp->ex_path.mnt && path.dentry =3D=3D dentry &&
> diff --git a/include/linux/namei.h b/include/linux/namei.h
> index 00fee52df842..6f96db73a70a 100644
> --- a/include/linux/namei.h
> +++ b/include/linux/namei.h
> @@ -77,7 +77,7 @@ struct dentry *lookup_one_positive_unlocked(struct user=
_namespace *mnt_userns,
> 					    struct dentry *base, int len);
>=20
> extern int follow_down_one(struct path *);
> -extern int follow_down(struct path *);
> +extern int follow_down(struct path *, unsigned int flags);
> extern int follow_up(struct path *);
>=20
> extern struct dentry *lock_rename(struct dentry *, struct dentry *);
> --=20
> 2.26.2
>=20

I plan to take this through the nfsd tree, thus this one needs
an Ack from the VFS maintainer(s).


--
Chuck Lever