Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221214084730.296936-1-chengen.du@canonical.com> <2B6CD9C5-EE21-4275-9F6E-AF1C1C5E164F@hammerspace.com>
In-Reply-To: <2B6CD9C5-EE21-4275-9F6E-AF1C1C5E164F@hammerspace.com>
From:   Chengen Du <chengen.du@canonical.com>
Date:   Thu, 15 Dec 2022 11:03:04 +0800
Message-ID: <CAPza5qdWzbNcBt7ZvUxtonB38v07cDVPkBOtdBPvK=3_Y+rWgg@mail.gmail.com>
Subject: Re: [PATCH] NFS: fix client permission error after adding user to
 permissible group
To:     Trond Myklebust <trondmy@hammerspace.com>
Cc:     Anna Schumaker <anna@kernel.org>,
        Charles Edward Lever <chuck.lever@oracle.com>,
        Jeffrey Layton <jlayton@kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Trond,

Thanks for your information.

Best regards,
Chengen Du

On Thu, Dec 15, 2022 at 3:42 AM Trond Myklebust <trondmy@hammerspace.com> w=
rote:
>
>
>
> > On Dec 14, 2022, at 03:47, Chengen Du <chengen.du@canonical.com> wrote:
> >
> > The access cache only expires if either NFS_INO_INVALID_ACCESS flag is =
on
> > or timeout (without delegation).
> > Adding a user to a group in the NFS server will not cause any file
> > attributes to change.
> > The client will encounter permission errors until other file attributes
> > are changed or the memory cache is dropped.
> >
> > Steps to reproduce the issue:
> > 1.[client side] testuser is not part of testgroup
> >  testuser@kinetic:~$ ls -ld /mnt/private/
> >  drwxrwx--- 2 root testgroup 4096 Nov 24 08:23 /mnt/private/
> >  testuser@kinetic:~$ mktemp -p /mnt/private/
> >  mktemp: failed to create file via template
> >  =E2=80=98/mnt/private/tmp.XXXXXXXXXX=E2=80=99: Permission denied
> > 2.[server side] add testuser into testgroup, which has access to folder
> >  root@kinetic:~$ usermod -aG testgroup testuser &&
> >  echo `date +'%s'` > /proc/net/rpc/auth.unix.gid/flush
> > 3.[client side] create a file again but still fail
> >  testuser@kinetic:~$ mktemp -p /mnt/private/
> >  mktemp: failed to create file via template
> >  =E2=80=98/mnt/private/tmp.XXXXXXXXXX=E2=80=99: Permission denied
> >
>
> Thanks, but the correct way to deal with this is to log out and log back =
in again, the way the POSIX gods intended. See commit 0eb43812c027 ("NFS: C=
lear the file access cache upon login=E2=80=9D).
>
> _________________________________
> Trond Myklebust
> Linux NFS client maintainer, Hammerspace
> trond.myklebust@hammerspace.com
>