Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Wang Yugui <wangyugui@e16-tech.com>
Subject: Re: [PATCH] nfsd: shut down the NFSv4 state objects before the
 filecache
Thread-Topic: [PATCH] nfsd: shut down the NFSv4 state objects before the
 filecache
Thread-Index: AQHZFhTlqfDHokRUHkmZ89RJc2hqb655/puA
Date:   Thu, 22 Dec 2022 14:55:10 +0000
Message-ID: <3858C5C1-342C-4599-A1B5-BF55953D0CBB@oracle.com>
References: <20221222145130.162341-1-jlayton@kernel.org>
In-Reply-To: <20221222145130.162341-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?67Gpjp9GMvRJD7462sSanITt+XJGGOBTuXEWM7nlIJEeI0mJp6Th+WS/tY+y?=
 =?us-ascii?Q?nac+8NYmWKBMsjEzeSryn54fJzUD0+ei7+wlKR4WKadC0FtN488sZqg8hWlv?=
 =?us-ascii?Q?f4Z8kGw8QqS/ryzgtwvWiH3STpfIId7wgEOj9lordgUUBhgBhKk+OBF0jAXV?=
 =?us-ascii?Q?Rv5BUx2lMh9q0ulLABgj9wZL18o8ovuvD9BYLgg6rqt3MgEMraL95j5/5PsO?=
 =?us-ascii?Q?Ntltz6iaca6vgTBQWacNkvoX/Y6ltL0E2Rk+56xolu8me8BjUV9h19+RO+Kn?=
 =?us-ascii?Q?emufubPQ+m8Ct+sT5k7b7hAqCBYJupLapfCjYS8RzFHRC+CIOeXEhYUg3xyD?=
 =?us-ascii?Q?eHvuWqhWAV/ndK19SHctZK6pRd0VIYs+JqfYZJF/zUuont4/6pNGdWMVwZYf?=
 =?us-ascii?Q?RHWDPw3/DJUkQj8aiPfHbEkCjpDnzMzBV1O15zTJyxN/S2f47LxxC6U6rC00?=
 =?us-ascii?Q?tmOjAzwSNmEw/W5CyG4fT6WmINHSbuZRa7ixL52qjLpy9f9n6RxaSlIRmwcm?=
 =?us-ascii?Q?1oidNDG/HP6RseJI0sBrsDUOvU+B+mqiaJi38X7M6Ej8K5r+1S7o42BpXhGr?=
 =?us-ascii?Q?HTMdZ1mPEtLNffjl7x+DMnMgS2JyqWE88p54LetiR5AxP2cSEMROPMHC6g9e?=
 =?us-ascii?Q?IzfnMvThaWA4IRKI4vh2JOg9atqyLqE8gIY/5KZ7+lgvLqyAQ0RYMgAftsR5?=
 =?us-ascii?Q?VFgId/EWOIsqwvamgH/DeO30xSOKjntHC63jY447I68yUSV2jjOi1k8/f7Tn?=
 =?us-ascii?Q?cwCvqW4D81hFjVVhtCkw1+yJ87Gz/s2NHxi1Gwqp3l3zvgeKwe6sC0DB75Qj?=
 =?us-ascii?Q?+3wZBIh+udqdcq3YWU4HxkQhAM6fzThH9MlCChnTPbPRepFiJw9J4c5NDhK4?=
 =?us-ascii?Q?U15o2bcqXpGIIVhcjkchcfkucjYTeA9OMbZ/ekzYrw8IBYwcF9vItGDM8esm?=
 =?us-ascii?Q?LQT4GKhTGRAkkantHjr9K5Oa2+bhd2fO+D6ctzU/H3+FoHwcEBgVgI0+YcAS?=
 =?us-ascii?Q?Wk6k32VsMRQvR5/xaU7MgzkNSNz3AAkM4H/Jfh7AshvWEs/Ijmhs04lj4pP8?=
 =?us-ascii?Q?72U5rcQjsgBajnlt83NEelyVottjo4+ockXm0ag/mO6YBerx1Qld0Hw0QbSw?=
 =?us-ascii?Q?EOIy9JcuLv4hKTAwr8brWdaCom7vU8tX2t2GEWake9VbcjQTTH4t66gQS3An?=
 =?us-ascii?Q?sPg+58SRivkLsC0ciJ4ZoM2JE4Szl3nR4ISa5TnZiU1sLBeb4iDL7oDBXjy2?=
 =?us-ascii?Q?EWXHcJUjQqm87JaKXj2DxMyjhACR1jAB4jdyRQJSZL2lmS0j0WKlUlc7a0r0?=
 =?us-ascii?Q?ppvRClCGB9tlVXSewFOu2X3Apvv6ubh5hCc1dWRiDZQR5MANtqjVHLnfwdpZ?=
 =?us-ascii?Q?NkZP3k9AUSRorfhskuoj78WjbYGlVl8ooiUC2Xd88VCtM8Scg33DSbLZjN3+?=
 =?us-ascii?Q?vTL2BFAakSmEDyCu/UoOd5AgVjMVQbVktKoDNp48DbFBdkEDqyiguVdK/Oyx?=
 =?us-ascii?Q?C4H3G7hgrdcx3M80H96O9IeAxbzirx1Xpjo/217Xh+RtETD3eS9OkqxClGpr?=
 =?us-ascii?Q?ApQUckJkSTccWqRSyD7R50tUQtqP00LPhRxEHoeZ7knPwKq51Vvn5A6EYWPw?=
 =?us-ascii?Q?8Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <5DD894DF58968B4D835C56CFC16D1042@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 91d5afa2-d5ed-4cb8-519f-08dae42c85fd
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Dec 2022 14:55:10.3386
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: SZZeYKQuESZ7xea6QQeavOPEh8vKjx0RZxWPDdcGFPQrREbhy+ZCPzcBmEaXWrAXXep8vXa4SzTJULxiRHW3WA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6471
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-22_08,2022-12-22_03,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 mlxscore=0
 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212220130
X-Proofpoint-ORIG-GUID: SY3HAIJC5JGEwnbcYhqaRMWFg6QR0Kk3
X-Proofpoint-GUID: SY3HAIJC5JGEwnbcYhqaRMWFg6QR0Kk3
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Dec 22, 2022, at 9:51 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> Currently, we shut down the filecache before trying to clean up the
> stateids that depend on it. This leads to the kernel trying to free an
> nfsd_file twice, and a refcount overput on the nf_mark.
>=20
> Change the shutdown procedure to tear down all of the stateids prior
> to shutting down the filecache.
>=20
> Reported-and-Tested-by: Wang Yugui <wangyugui@e16-tech.com>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/nfsd/nfssvc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 56fba1cba3af..325d3d3f1211 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -453,8 +453,8 @@ static void nfsd_shutdown_net(struct net *net)
> {
> 	struct nfsd_net *nn =3D net_generic(net, nfsd_net_id);
>=20
> -	nfsd_file_cache_shutdown_net(net);
> 	nfs4_state_shutdown_net(net);
> +	nfsd_file_cache_shutdown_net(net);
> 	if (nn->lockd_up) {
> 		lockd_down(net);
> 		nn->lockd_up =3D false;
> --=20
> 2.38.1
>=20

Hi Jeff, seems sensible. May I add:

Fixes: 5e113224c17e ("nfsd: nfsd_file cache entries should be per net names=
pace")

--
Chuck Lever