Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <46416c9d66e5c64feb3093d3f1f6b6248d49467b.camel@kernel.org>
Subject: Re: [PATCH] nfsd: shut down the NFSv4 state objects before the
 filecache
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Wang Yugui <wangyugui@e16-tech.com>
Date:   Thu, 22 Dec 2022 10:10:08 -0500
In-Reply-To: <3858C5C1-342C-4599-A1B5-BF55953D0CBB@oracle.com>
References: <20221222145130.162341-1-jlayton@kernel.org>
         <3858C5C1-342C-4599-A1B5-BF55953D0CBB@oracle.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Thu, 2022-12-22 at 14:55 +0000, Chuck Lever III wrote:
>=20
> > On Dec 22, 2022, at 9:51 AM, Jeff Layton <jlayton@kernel.org> wrote:
> >=20
> > Currently, we shut down the filecache before trying to clean up the
> > stateids that depend on it. This leads to the kernel trying to free an
> > nfsd_file twice, and a refcount overput on the nf_mark.
> >=20
> > Change the shutdown procedure to tear down all of the stateids prior
> > to shutting down the filecache.
> >=20
> > Reported-and-Tested-by: Wang Yugui <wangyugui@e16-tech.com>
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/nfsd/nfssvc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> > index 56fba1cba3af..325d3d3f1211 100644
> > --- a/fs/nfsd/nfssvc.c
> > +++ b/fs/nfsd/nfssvc.c
> > @@ -453,8 +453,8 @@ static void nfsd_shutdown_net(struct net *net)
> > {
> > 	struct nfsd_net *nn =3D net_generic(net, nfsd_net_id);
> >=20
> > -	nfsd_file_cache_shutdown_net(net);
> > 	nfs4_state_shutdown_net(net);
> > +	nfsd_file_cache_shutdown_net(net);
> > 	if (nn->lockd_up) {
> > 		lockd_down(net);
> > 		nn->lockd_up =3D false;
> > --=20
> > 2.38.1
> >=20
>=20
> Hi Jeff, seems sensible. May I add:
>=20
> Fixes: 5e113224c17e ("nfsd: nfsd_file cache entries should be per net nam=
espace")
>=20

Yes, thanks.
--=20
Jeff Layton <jlayton@kernel.org>